Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-11-06 Thread Eric Seidel
I've filed --32-bit support as
https://bugs.webkit.org/show_bug.cgi?id=71634, per your request.

On Mon, Oct 31, 2011 at 10:22 AM, Gavin Barraclough
 wrote:
> On Oct 27, 2011, at 3:00 PM, Eric Seidel wrote:
>
>> If you're still using old-run-webkit-tests for your work, I would
>> *love* to know and fix any issues you may have with NRWT.
>
> Hi Eric,
>
> Unless there is a trick to this that I am unaware of, I think NRWT doesn't 
> support running 32-bit tests on a 64-bit platform?
> ORWT has a --32-bit switch to do so (albeit requiring some kludging these 
> days to get it to work correctly).
>
> cheers,
> G.
>
> p.s. NRWT is awesome, yay to parallel test running.
>
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-11-06 Thread Eric Seidel
Thank you.  I have a patch, I expect to re-land it this week.

On Fri, Oct 28, 2011 at 5:57 AM, Antti Koivisto  wrote:
> On Fri, Oct 28, 2011 at 1:00 AM, Eric Seidel  wrote:
>>
>> If you're still using old-run-webkit-tests for your work, I would
>> *love* to know and fix any issues you may have with NRWT.
>>
>
> The lack of locale independence is a showstopper for me,
> https://bugs.webkit.org/show_bug.cgi?id=68691.
>
>    antti
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-11-06 Thread Eric Seidel
I've filed this as https://bugs.webkit.org/show_bug.cgi?id=71633 on
your behalf. :)

On Fri, Oct 28, 2011 at 2:57 AM, Nikolas Zimmermann
 wrote:
>
> Am 28.10.2011 um 00:40 schrieb Eric Seidel:
>
>> Yes, thank you Ryosuke:
>> https://bugs.webkit.org/show_bug.cgi?id=68931
>>
>> If you have any other issues, I would love to know about them.
>
> The "--ignore" flag of orwt, accepting a comma seperated list of tests/dirs 
> to skip is very useful.
> As WebGL tests cause a machine lockup on my old 2006 MBP, I always used 
> "run-webkit-tests -i fast/canvas/webgl".
>
> I'd appreciate if that could be added.
>
> Thanks,
> Niko
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-11-06 Thread Eric Seidel
Agreed.  https://bugs.webkit.org/show_bug.cgi?id=62199 is tracking that work.

On Thu, Oct 27, 2011 at 3:51 PM, Abhishek Arya  wrote:
> There was a awesome parameter in old-run-webkit-tests called
> --repeat-each. This was sometimes useful for security crashes. Can we
> bring it back in NRWT.
>
> Cheers,
> Abhishek
>
> On Thu, Oct 27, 2011 at 3:40 PM, Eric Seidel  wrote:
>> Yes, thank you Ryosuke:
>> https://bugs.webkit.org/show_bug.cgi?id=68931
>>
>> If you have any other issues, I would love to know about them.
>>
>> -eric
>>
>> On Thu, Oct 27, 2011 at 3:18 PM, David Hyatt  wrote:
>>> Has the issue with run-webkit-tests putting pixel tests in cross-platform 
>>> directories instead of platform-specific directories been fixed? That was 
>>> the showstopper for me.
>>>
>>> dave
>>> (hy...@apple.com)
>>>
>>> On Oct 27, 2011, at 5:00 PM, Eric Seidel wrote:
>>>
 As of this afternoon, the Apple-Win bot is the only remaining buildbot
 (to my knowledge) using old-run-webkit-tests
 (https://bugs.webkit.org/show_bug.cgi?id=38756).

 Unfortunately, that's not likely to change soon.  But all other
 platforms (and all other developers) besides Apple-Win should be using
 new-run-webkit-tests (it's automatically called for you when you run
 run-webkit-tests).

 If you're still using old-run-webkit-tests for your work, I would
 *love* to know and fix any issues you may have with NRWT.


 In the next week I'll be moving run-webkit-tests from using a
 white-list of NRWT-supported ports, to a black-list.  Meaning any
 private (or future) ports which may not be using NRWT yet will need to
 switch, or we'll need to add a special exception in run-webkit-tests
 for that port.

 Thank you for your patience in this process.  I've started to burn
 down the list of polish bugs
 (https://bugs.webkit.org/show_bug.cgi?id=64491) and plan to close the
 "switch all bots" bug (https://bugs.webkit.org/show_bug.cgi?id=34984)
 once we move run-webkit-tests from whitelisting NRWT supported ports
 to blacklisting ports which still require ORWT.

 -eric
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-31 Thread Gavin Barraclough
On Oct 27, 2011, at 3:00 PM, Eric Seidel wrote:

> If you're still using old-run-webkit-tests for your work, I would
> *love* to know and fix any issues you may have with NRWT.

Hi Eric,

Unless there is a trick to this that I am unaware of, I think NRWT doesn't 
support running 32-bit tests on a 64-bit platform?
ORWT has a --32-bit switch to do so (albeit requiring some kludging these days 
to get it to work correctly).

cheers,
G.

p.s. NRWT is awesome, yay to parallel test running.


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-28 Thread Antti Koivisto
On Fri, Oct 28, 2011 at 1:00 AM, Eric Seidel  wrote:
>
> If you're still using old-run-webkit-tests for your work, I would
> *love* to know and fix any issues you may have with NRWT.
>
>
The lack of locale independence is a showstopper for me,
https://bugs.webkit.org/show_bug.cgi?id=68691.


   antti
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-28 Thread Eric Seidel
Please file these as bugs so they get tracked, fixed and not forgotten. :)

On Fri, Oct 28, 2011 at 2:57 AM, Nikolas Zimmermann
 wrote:
>
> Am 28.10.2011 um 00:40 schrieb Eric Seidel:
>
>> Yes, thank you Ryosuke:
>> https://bugs.webkit.org/show_bug.cgi?id=68931
>>
>> If you have any other issues, I would love to know about them.
>
> The "--ignore" flag of orwt, accepting a comma seperated list of tests/dirs 
> to skip is very useful.
> As WebGL tests cause a machine lockup on my old 2006 MBP, I always used 
> "run-webkit-tests -i fast/canvas/webgl".
>
> I'd appreciate if that could be added.
>
> Thanks,
> Niko
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-28 Thread Nikolas Zimmermann

Am 28.10.2011 um 00:40 schrieb Eric Seidel:

> Yes, thank you Ryosuke:
> https://bugs.webkit.org/show_bug.cgi?id=68931
> 
> If you have any other issues, I would love to know about them.

The "--ignore" flag of orwt, accepting a comma seperated list of tests/dirs to 
skip is very useful.
As WebGL tests cause a machine lockup on my old 2006 MBP, I always used 
"run-webkit-tests -i fast/canvas/webgl".

I'd appreciate if that could be added.

Thanks,
Niko

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-27 Thread Ryosuke Niwa
Yup. It's fixed in http://trac.webkit.org/changeset/98062 :)

- Ryosuke

On Thu, Oct 27, 2011 at 3:40 PM, Eric Seidel  wrote:

> Yes, thank you Ryosuke:
> https://bugs.webkit.org/show_bug.cgi?id=68931
>
> If you have any other issues, I would love to know about them.
>
> -eric
>
> On Thu, Oct 27, 2011 at 3:18 PM, David Hyatt  wrote:
> > Has the issue with run-webkit-tests putting pixel tests in cross-platform
> directories instead of platform-specific directories been fixed? That was
> the showstopper for me.
> >
> > dave
> > (hy...@apple.com)
> >
> > On Oct 27, 2011, at 5:00 PM, Eric Seidel wrote:
> >
> >> As of this afternoon, the Apple-Win bot is the only remaining buildbot
> >> (to my knowledge) using old-run-webkit-tests
> >> (https://bugs.webkit.org/show_bug.cgi?id=38756).
> >>
> >> Unfortunately, that's not likely to change soon.  But all other
> >> platforms (and all other developers) besides Apple-Win should be using
> >> new-run-webkit-tests (it's automatically called for you when you run
> >> run-webkit-tests).
> >>
> >> If you're still using old-run-webkit-tests for your work, I would
> >> *love* to know and fix any issues you may have with NRWT.
> >>
> >>
> >> In the next week I'll be moving run-webkit-tests from using a
> >> white-list of NRWT-supported ports, to a black-list.  Meaning any
> >> private (or future) ports which may not be using NRWT yet will need to
> >> switch, or we'll need to add a special exception in run-webkit-tests
> >> for that port.
> >>
> >> Thank you for your patience in this process.  I've started to burn
> >> down the list of polish bugs
> >> (https://bugs.webkit.org/show_bug.cgi?id=64491) and plan to close the
> >> "switch all bots" bug (https://bugs.webkit.org/show_bug.cgi?id=34984)
> >> once we move run-webkit-tests from whitelisting NRWT supported ports
> >> to blacklisting ports which still require ORWT.
> >>
> >> -eric
> >> ___
> >> webkit-dev mailing list
> >> webkit-dev@lists.webkit.org
> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >
> >
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-27 Thread Eric Seidel
Agreed!  Should be easy to add:
https://bugs.webkit.org/show_bug.cgi?id=62199


On Thu, Oct 27, 2011 at 3:51 PM, Abhishek Arya  wrote:
> There was a awesome parameter in old-run-webkit-tests called
> --repeat-each. This was sometimes useful for security crashes. Can we
> bring it back in NRWT.
>
> Cheers,
> Abhishek
>
> On Thu, Oct 27, 2011 at 3:40 PM, Eric Seidel  wrote:
>> Yes, thank you Ryosuke:
>> https://bugs.webkit.org/show_bug.cgi?id=68931
>>
>> If you have any other issues, I would love to know about them.
>>
>> -eric
>>
>> On Thu, Oct 27, 2011 at 3:18 PM, David Hyatt  wrote:
>>> Has the issue with run-webkit-tests putting pixel tests in cross-platform 
>>> directories instead of platform-specific directories been fixed? That was 
>>> the showstopper for me.
>>>
>>> dave
>>> (hy...@apple.com)
>>>
>>> On Oct 27, 2011, at 5:00 PM, Eric Seidel wrote:
>>>
 As of this afternoon, the Apple-Win bot is the only remaining buildbot
 (to my knowledge) using old-run-webkit-tests
 (https://bugs.webkit.org/show_bug.cgi?id=38756).

 Unfortunately, that's not likely to change soon.  But all other
 platforms (and all other developers) besides Apple-Win should be using
 new-run-webkit-tests (it's automatically called for you when you run
 run-webkit-tests).

 If you're still using old-run-webkit-tests for your work, I would
 *love* to know and fix any issues you may have with NRWT.


 In the next week I'll be moving run-webkit-tests from using a
 white-list of NRWT-supported ports, to a black-list.  Meaning any
 private (or future) ports which may not be using NRWT yet will need to
 switch, or we'll need to add a special exception in run-webkit-tests
 for that port.

 Thank you for your patience in this process.  I've started to burn
 down the list of polish bugs
 (https://bugs.webkit.org/show_bug.cgi?id=64491) and plan to close the
 "switch all bots" bug (https://bugs.webkit.org/show_bug.cgi?id=34984)
 once we move run-webkit-tests from whitelisting NRWT supported ports
 to blacklisting ports which still require ORWT.

 -eric
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-27 Thread Eric Seidel
Yes, thank you Ryosuke:
https://bugs.webkit.org/show_bug.cgi?id=68931

If you have any other issues, I would love to know about them.

-eric

On Thu, Oct 27, 2011 at 3:18 PM, David Hyatt  wrote:
> Has the issue with run-webkit-tests putting pixel tests in cross-platform 
> directories instead of platform-specific directories been fixed? That was the 
> showstopper for me.
>
> dave
> (hy...@apple.com)
>
> On Oct 27, 2011, at 5:00 PM, Eric Seidel wrote:
>
>> As of this afternoon, the Apple-Win bot is the only remaining buildbot
>> (to my knowledge) using old-run-webkit-tests
>> (https://bugs.webkit.org/show_bug.cgi?id=38756).
>>
>> Unfortunately, that's not likely to change soon.  But all other
>> platforms (and all other developers) besides Apple-Win should be using
>> new-run-webkit-tests (it's automatically called for you when you run
>> run-webkit-tests).
>>
>> If you're still using old-run-webkit-tests for your work, I would
>> *love* to know and fix any issues you may have with NRWT.
>>
>>
>> In the next week I'll be moving run-webkit-tests from using a
>> white-list of NRWT-supported ports, to a black-list.  Meaning any
>> private (or future) ports which may not be using NRWT yet will need to
>> switch, or we'll need to add a special exception in run-webkit-tests
>> for that port.
>>
>> Thank you for your patience in this process.  I've started to burn
>> down the list of polish bugs
>> (https://bugs.webkit.org/show_bug.cgi?id=64491) and plan to close the
>> "switch all bots" bug (https://bugs.webkit.org/show_bug.cgi?id=34984)
>> once we move run-webkit-tests from whitelisting NRWT supported ports
>> to blacklisting ports which still require ORWT.
>>
>> -eric
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-27 Thread Adam Barth
I think Ryosuke fixed that recently.

Adam


On Thu, Oct 27, 2011 at 3:18 PM, David Hyatt  wrote:
> Has the issue with run-webkit-tests putting pixel tests in cross-platform 
> directories instead of platform-specific directories been fixed? That was the 
> showstopper for me.
>
> dave
> (hy...@apple.com)
>
> On Oct 27, 2011, at 5:00 PM, Eric Seidel wrote:
>
>> As of this afternoon, the Apple-Win bot is the only remaining buildbot
>> (to my knowledge) using old-run-webkit-tests
>> (https://bugs.webkit.org/show_bug.cgi?id=38756).
>>
>> Unfortunately, that's not likely to change soon.  But all other
>> platforms (and all other developers) besides Apple-Win should be using
>> new-run-webkit-tests (it's automatically called for you when you run
>> run-webkit-tests).
>>
>> If you're still using old-run-webkit-tests for your work, I would
>> *love* to know and fix any issues you may have with NRWT.
>>
>>
>> In the next week I'll be moving run-webkit-tests from using a
>> white-list of NRWT-supported ports, to a black-list.  Meaning any
>> private (or future) ports which may not be using NRWT yet will need to
>> switch, or we'll need to add a special exception in run-webkit-tests
>> for that port.
>>
>> Thank you for your patience in this process.  I've started to burn
>> down the list of polish bugs
>> (https://bugs.webkit.org/show_bug.cgi?id=64491) and plan to close the
>> "switch all bots" bug (https://bugs.webkit.org/show_bug.cgi?id=34984)
>> once we move run-webkit-tests from whitelisting NRWT supported ports
>> to blacklisting ports which still require ORWT.
>>
>> -eric
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-27 Thread David Hyatt
Has the issue with run-webkit-tests putting pixel tests in cross-platform 
directories instead of platform-specific directories been fixed? That was the 
showstopper for me.

dave
(hy...@apple.com)

On Oct 27, 2011, at 5:00 PM, Eric Seidel wrote:

> As of this afternoon, the Apple-Win bot is the only remaining buildbot
> (to my knowledge) using old-run-webkit-tests
> (https://bugs.webkit.org/show_bug.cgi?id=38756).
> 
> Unfortunately, that's not likely to change soon.  But all other
> platforms (and all other developers) besides Apple-Win should be using
> new-run-webkit-tests (it's automatically called for you when you run
> run-webkit-tests).
> 
> If you're still using old-run-webkit-tests for your work, I would
> *love* to know and fix any issues you may have with NRWT.
> 
> 
> In the next week I'll be moving run-webkit-tests from using a
> white-list of NRWT-supported ports, to a black-list.  Meaning any
> private (or future) ports which may not be using NRWT yet will need to
> switch, or we'll need to add a special exception in run-webkit-tests
> for that port.
> 
> Thank you for your patience in this process.  I've started to burn
> down the list of polish bugs
> (https://bugs.webkit.org/show_bug.cgi?id=64491) and plan to close the
> "switch all bots" bug (https://bugs.webkit.org/show_bug.cgi?id=34984)
> once we move run-webkit-tests from whitelisting NRWT supported ports
> to blacklisting ports which still require ORWT.
> 
> -eric
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-27 Thread Eric Seidel
As of this afternoon, the Apple-Win bot is the only remaining buildbot
(to my knowledge) using old-run-webkit-tests
(https://bugs.webkit.org/show_bug.cgi?id=38756).

Unfortunately, that's not likely to change soon.  But all other
platforms (and all other developers) besides Apple-Win should be using
new-run-webkit-tests (it's automatically called for you when you run
run-webkit-tests).

If you're still using old-run-webkit-tests for your work, I would
*love* to know and fix any issues you may have with NRWT.


In the next week I'll be moving run-webkit-tests from using a
white-list of NRWT-supported ports, to a black-list.  Meaning any
private (or future) ports which may not be using NRWT yet will need to
switch, or we'll need to add a special exception in run-webkit-tests
for that port.

Thank you for your patience in this process.  I've started to burn
down the list of polish bugs
(https://bugs.webkit.org/show_bug.cgi?id=64491) and plan to close the
"switch all bots" bug (https://bugs.webkit.org/show_bug.cgi?id=34984)
once we move run-webkit-tests from whitelisting NRWT supported ports
to blacklisting ports which still require ORWT.

-eric
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev