[webkit-dev] please add EditBugs permission

2012-05-15 Thread Elliot Poger
Can someone please add EditBugs permission for my bugs.webkit.org account (
epo...@chromium.org)?

Another WebKit committer and I both tried it, using the steps Eric pasted
in April, but it failed... I think maybe the add-users-to-groups tool is
broken?

$ Tools/Scripts/webkit-patch add-users-to-groups epo...@chromium.org
Add users matching epo...@chromium.org which groups?
 1. canconfirm
 2. editbugs
Enter one or more numbers (comma-separated), or all: all
bugs.webkit.org login: epo...@google.com
bugs.webkit.org password for epo...@google.com:
Logging in as epo...@google.com...
Traceback (most recent call last):
  File Tools/Scripts/webkit-patch, line 69, in module
main()
  File Tools/Scripts/webkit-patch, line 64, in main
WebKitPatch(os.path.abspath(__file__)).main()
  File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py,
line 311, in main
result = command.check_arguments_and_execute(options, args, self)
  File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py,
line 120, in check_arguments_and_execute
return self.execute(options, args, tool) or 0
  File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/commands/adduserstogroups.py,
line 50, in execute
login_userid_pairs =
tool.bugs.queries.fetch_login_userid_pairs_matching_substring(search_string)
  File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py,
line 257, in fetch_login_userid_pairs_matching_substring
return
EditUsersParser().login_userid_pairs_from_edit_user_results(results_page)
  File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py,
line 72, in login_userid_pairs_from_edit_user_results
login_userid_pairs = [self._login_and_uid_from_row(row) for row in
results_table('tr')]
TypeError: 'NoneType' object is not callable


On Thu, Apr 12, 2012 at 6:47 PM, Eric Seidel e...@webkit.org wrote:

 Done.

 % webkit-patch add-users-to-groups shezbaig...@gmail.com
 Add users matching shezbaig...@gmail.com which groups?
  1. canconfirm
  2. editbugs
 Enter one or more numbers (comma-separated), or all:
 Reading Keychain for bugs.webkit.org account and password.  Click
 Allow to continue...
 Logging in as e...@webkit.org...
 Found 1 users matching shezbaig...@gmail.com:
 shezbaig...@gmail.com (17597)
 Are you sure you want add 1 users to groups ['canconfirm',
 'editbugs']?  (This action cannot be undone using webkit-patch.)
 [Y/n]:
 Adding shezbaig...@gmail.com to ['canconfirm', 'editbugs']

 On Thu, Apr 12, 2012 at 3:17 PM, Shezan Baig shezbaig...@gmail.com
 wrote:
  Hello,
 
  When I submit a patch to bugzilla, I get an error that EditBugs is not
 set
  on my account.  Can someone add this permission to my bugzilla account
  please?  I sent a message to webkit-committ...@lists.webkit.org as
  instructed, but that doesn't get through.
 
  My login is: shezbaig...@gmail.com
  My patch submitted to: https://bugs.webkit.org/show_bug.cgi?id=80382
 
  Thanks,
  Shezan
 
 
  ___
  webkit-dev mailing list
  webkit-dev@lists.webkit.org
  http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] please add EditBugs permission

2012-05-15 Thread Eric Seidel
You have to have EditUser permission to run that script.  It should
bail out with a nicer message when you dont. :(

% Tools/Scripts/webkit-patch add-users-to-groups epo...@chromium.org
Add users matching epo...@chromium.org which groups?
 1. canconfirm
 2. editbugs
Enter one or more numbers (comma-separated), or all:
Reading Keychain for bugs.webkit.org account and password.  Click
Allow to continue...
Logging in as e...@webkit.org...
Found 1 users matching epo...@chromium.org:
epo...@chromium.org (18143)
Are you sure you want add 1 users to groups ['canconfirm',
'editbugs']?  (This action cannot be undone using webkit-patch.)
[Y/n]:
Adding epo...@chromium.org to ['canconfirm', 'editbugs']

Done.

On Tue, May 15, 2012 at 1:33 PM, Elliot Poger epo...@chromium.org wrote:
 Can someone please add EditBugs permission for my bugs.webkit.org account
 (epo...@chromium.org)?

 Another WebKit committer and I both tried it, using the steps Eric pasted in
 April, but it failed... I think maybe the add-users-to-groups tool is
 broken?

 $ Tools/Scripts/webkit-patch add-users-to-groups epo...@chromium.org
 Add users matching epo...@chromium.org which groups?
  1. canconfirm
  2. editbugs
 Enter one or more numbers (comma-separated), or all: all
 bugs.webkit.org login: epo...@google.com
 bugs.webkit.org password for epo...@google.com:
 Logging in as epo...@google.com...
 Traceback (most recent call last):
   File Tools/Scripts/webkit-patch, line 69, in module
     main()
   File Tools/Scripts/webkit-patch, line 64, in main
     WebKitPatch(os.path.abspath(__file__)).main()
   File
 /usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py,
 line 311, in main
     result = command.check_arguments_and_execute(options, args, self)
   File
 /usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py,
 line 120, in check_arguments_and_execute
     return self.execute(options, args, tool) or 0
   File
 /usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/commands/adduserstogroups.py,
 line 50, in execute
     login_userid_pairs =
 tool.bugs.queries.fetch_login_userid_pairs_matching_substring(search_string)
   File
 /usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py,
 line 257, in fetch_login_userid_pairs_matching_substring
     return
 EditUsersParser().login_userid_pairs_from_edit_user_results(results_page)
   File
 /usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py,
 line 72, in login_userid_pairs_from_edit_user_results
     login_userid_pairs = [self._login_and_uid_from_row(row) for row in
 results_table('tr')]
 TypeError: 'NoneType' object is not callable


 On Thu, Apr 12, 2012 at 6:47 PM, Eric Seidel e...@webkit.org wrote:

 Done.

 % webkit-patch add-users-to-groups shezbaig...@gmail.com
 Add users matching shezbaig...@gmail.com which groups?
  1. canconfirm
  2. editbugs
 Enter one or more numbers (comma-separated), or all:
 Reading Keychain for bugs.webkit.org account and password.  Click
 Allow to continue...
 Logging in as e...@webkit.org...
 Found 1 users matching shezbaig...@gmail.com:
 shezbaig...@gmail.com (17597)
 Are you sure you want add 1 users to groups ['canconfirm',
 'editbugs']?  (This action cannot be undone using webkit-patch.)
 [Y/n]:
 Adding shezbaig...@gmail.com to ['canconfirm', 'editbugs']

 On Thu, Apr 12, 2012 at 3:17 PM, Shezan Baig shezbaig...@gmail.com
 wrote:
  Hello,
 
  When I submit a patch to bugzilla, I get an error that EditBugs is not
  set
  on my account.  Can someone add this permission to my bugzilla account
  please?  I sent a message to webkit-committ...@lists.webkit.org as
  instructed, but that doesn't get through.
 
  My login is: shezbaig...@gmail.com
  My patch submitted to: https://bugs.webkit.org/show_bug.cgi?id=80382
 
  Thanks,
  Shezan
 
 
  ___
  webkit-dev mailing list
  webkit-dev@lists.webkit.org
  http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev