Re: [webkit-dev] review times
Hello, On Wed, Dec 3, 2014 at 5:32 PM, Daniel Lazarenko wrote: > I've made a patch for a bug # 137299, and it's been waiting for review for > more than 30 days now. Happy new year! Anybody from Apple wants to do a review round on https://bugs.webkit.org/show_bug.cgi?id=137299 ? I’m available to questions on IRC #webkit. -- With best regards, Daniel Lazarenko Developer Opera Software ASA ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] review times
On Wed, Dec 3, 2014 at 5:32 PM, Daniel Lazarenko wrote: > I've made a patch for a bug # 137299, and it's been waiting for review for > more than 30 days now. Did you contact the relevant reviewers on IRC and by emails? In my experience, posting a patch or commenting on WebKit is rarely a sufficient way to get a reviewer's attention if you want a better turn round time. I was always thinking that open source projects are open to changes and > collaboration. I would point out, however, that we are not obligated to take anyone's patch just for the sake of open-ness and collaboration. We only take patches that match our project goals ( http://www.webkit.org/projects/goals.html) for example (I'm not saying your patch doesn't fit our goals), and reviewers judge whether a patch will merit the project or not on case-by-case basis. There should be some rules for such cases when only one person can review, > but he/she is so busy that practically it's not going to happen. > I'm highly opposed to creating such a rule. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] review times
> On Dec 3, 2014, at 9:56 AM, Alexey Proskuryakov wrote: > > > 03 дек. 2014 г., в 2:32, Daniel Lazarenko написал(а): > >> Whatsoever it would be nice find a new reviewer for my patch. Does anybody >> want to take it? > > Just to be clear about this part, the reviewer should not be just "anybody". > This patch is part of an effort to implement a new feature in WebKit2 that at > least some of us consider wrong, so the reviewer needs to have appropriate > authority over WebKit2 feature set. > > The reviewership system is working as designed here, this is not an easy > patch to approve. I left some review feedback. I think the patch as written is not complete enough to support the feature it is intended to, and lacks sufficient testing. I left advice on how to fix these things. I hope Sam or Anders can comment on whether custom protocol handllers for http/https are something we want to support in the API. But it does seem, given comments on the patch, that there is a use for having the body in delegate callbacks even in the absence of protocol handlers. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] review times
03 дек. 2014 г., в 2:32, Daniel Lazarenko написал(а): > Whatsoever it would be nice find a new reviewer for my patch. Does anybody > want to take it? Just to be clear about this part, the reviewer should not be just "anybody". This patch is part of an effort to implement a new feature in WebKit2 that at least some of us consider wrong, so the reviewer needs to have appropriate authority over WebKit2 feature set. The reviewership system is working as designed here, this is not an easy patch to approve. - Alexey ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] review times
Hi, 30 days waiting isn't so long. :) I think our Guinness Recorder is bug110978, the first patch was uploaded 21 months before. And then were updated to the top of trunk many times, because WK2 owners doesn't have time to review the refactoring they explicitly requested. I always wonder if a reviewer can review a 200-300K sized patch of his/her co-worker in 5 minutes, but don't have time for a 20-30K sized patch in a month/year/decade/century. http://webkit.org/pending-review - 444 patches in the queue Shouldn't we decrease this huge number? PS: bug138971 wasn't unreviewed, check the history: https://bugs.webkit.org/show_activity.cgi?id=138971 br, Ossy Daniel Lazarenko írta: Hello, I've made a patch for a bug # 137299, and it's been waiting for review for more than 30 days now. The responsible reviewer from Apple is too busy to review. On the other hand there are patches sent by Apple employees and committed after 2 hours without any review ( for example # 138971 ). This looks very unfair to me. I was always thinking that open source projects are open to changes and collaboration. There should be some rules for such cases when only one person can review, but he/she is so busy that practically it's not going to happen. Whatsoever it would be nice find a new reviewer for my patch. Does anybody want to take it? -- With best regards, Daniel Lazarenko Developer Opera Software ASA ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] review times
Hello, I’ve made a patch for a bug # 137299, and it’s been waiting for review for more than 30 days now. The responsible reviewer from Apple is too busy to review. On the other hand there are patches sent by Apple employees and committed after 2 hours without any review ( for example # 138971 ). This looks very unfair to me. I was always thinking that open source projects are open to changes and collaboration. There should be some rules for such cases when only one person can review, but he/she is so busy that practically it’s not going to happen. Whatsoever it would be nice find a new reviewer for my patch. Does anybody want to take it? -- With best regards, Daniel Lazarenko Developer Opera Software ASA ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
