Re: [webkit-dev] some WebCore::String plans

2007-12-20 Thread Marvin Decker
On 12/19/07, Darin Adler [EMAIL PROTECTED] wrote: On Dec 19, 2007, at 12:53 PM, Marvin Decker wrote: This sounds good. Are there any plan to replace DeprecatedString with String when this is complete? It would make a big difference. Yes, uses of DeprecatedString should all be removed.

Re: [webkit-dev] some WebCore::String plans

2007-12-20 Thread Darin Adler
On Dec 20, 2007, at 10:23 AM, Marvin Decker wrote: I think this would have to be done incrementally to keep the patches sane. Sure, makes sense. But the total amount of change here isn't so great. Is it okay if code has a bunch of extra DepString-String conversions while this process is

Re: [webkit-dev] some WebCore::String plans

2007-12-19 Thread Darin Adler
On Dec 19, 2007, at 12:53 PM, Marvin Decker wrote: This sounds good. Are there any plan to replace DeprecatedString with String when this is complete? It would make a big difference. Yes, uses of DeprecatedString should all be removed. But that doesn't need to wait for this plan. Migration

Re: [webkit-dev] some WebCore::String plans

2007-12-18 Thread Darin Adler
On Dec 18, 2007, at 10:56 AM, Geoffrey Garen wrote: Would you suggest the same kinds of changes to KJS::UString? Probably not. I think the issues with KJS::UString are different. Long term it would be nice to consider exactly what the differences are between two classes and how to

Re: [webkit-dev] some WebCore::String plans

2007-12-18 Thread Maciej Stachowiak
Mostly sounds good. On Dec 18, 2007, at 10:51 AM, Darin Adler wrote: The WebCore::String class needs some work. I have some plans to improve it. Here's an outline of what I have in mind. immutability - eliminate all non-const functions from StringImpl; fixes tricky sharing semantics -

Re: [webkit-dev] some WebCore::String plans

2007-12-18 Thread Darin Adler
On Dec 18, 2007, at 6:19 PM, Maciej Stachowiak wrote: clarity - eliminate functions that return a StringImpl* from StringImpl, because it's to easy to misunderstand and think these modify the string in place - eliminate functions that return a String from String -- also easy to use wrong