Re: [webkit-dev] unsigned versus size_t in WTFString.h

2011-09-07 Thread Adam Barth
Thanks Gavin. This guidance is very helpful. Adam On Wed, Sep 7, 2011 at 2:38 AM, Gavin Barraclough wrote: > Hi Adam, > > Yes, I believe our current thinking is that the external interface to String > lengths / indices should all be in size_t (though unless we believe we need > to support st

Re: [webkit-dev] unsigned versus size_t in WTFString.h

2011-09-07 Thread Gavin Barraclough
Hi Adam, Yes, I believe our current thinking is that the external interface to String lengths / indices should all be in size_t (though unless we believe we need to support strings > 4GB we should keep the length stored as a 32 bit value internally). There are a couple of bugzilla bugs relevan

[webkit-dev] unsigned versus size_t in WTFString.h

2011-09-06 Thread Adam Barth
I wanted to confirm my understanding before going too far off into the woods: Most of the uses of "unsigned" in WTFString.h should really be "size_t", right? http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/text/WTFString.h For example, unsigned length() const should be size_t le