Re: [webkit-dev] webkit-patch and SVN

2010-04-15 Thread Darin Fisher
On Wed, Apr 14, 2010 at 5:06 PM, Adam Barth aba...@webkit.org wrote: On Wed, Apr 14, 2010 at 4:52 PM, Geoffrey Garen gga...@apple.com wrote: I'd rather keep the current behavior and have it operate on the entire repository. I think it will be too easy to make mistakes and leave out large

Re: [webkit-dev] webkit-patch and SVN

2010-04-15 Thread Adam Barth
On Wed, Apr 14, 2010 at 11:47 PM, Darin Fisher da...@chromium.org wrote: On Wed, Apr 14, 2010 at 5:06 PM, Adam Barth aba...@webkit.org wrote: On Wed, Apr 14, 2010 at 4:52 PM, Geoffrey Garen gga...@apple.com wrote: I'd rather keep the current behavior and have it operate on the entire

Re: [webkit-dev] webkit-patch and SVN

2010-04-15 Thread Darin Fisher
On Thu, Apr 15, 2010 at 12:09 AM, Adam Barth aba...@webkit.org wrote: On Wed, Apr 14, 2010 at 11:47 PM, Darin Fisher da...@chromium.org wrote: On Wed, Apr 14, 2010 at 5:06 PM, Adam Barth aba...@webkit.org wrote: On Wed, Apr 14, 2010 at 4:52 PM, Geoffrey Garen gga...@apple.com wrote: I'd

Re: [webkit-dev] webkit-patch and SVN

2010-04-15 Thread Alexey Proskuryakov
15.04.2010, в 00:37, Darin Fisher написал(а): If I need to work from the topmost directory, then I typically specify the directories I'm interested in on the svn command line (e.g., svn commit WebCore LayoutTests). That way the commands run faster. That's what I usually do, but I rarely

[webkit-dev] webkit-patch and SVN

2010-04-14 Thread Eric Seidel
Anders brought to my attention this afternoon that webkit-patch currently does all SVN operations from the root directory instead of being current-directory aware. That behavior matches how Git operates, but does not need to be how webkit-patch operates. Question: Do SVN users wish to have

Re: [webkit-dev] webkit-patch and SVN

2010-04-14 Thread Kenneth Russell
On Wed, Apr 14, 2010 at 2:13 PM, Eric Seidel e...@webkit.org wrote: Anders brought to my attention this afternoon that webkit-patch currently does all SVN operations from the root directory instead of being current-directory aware.  That behavior matches how Git operates, but does not need to

Re: [webkit-dev] webkit-patch and SVN

2010-04-14 Thread Geoffrey Garen
I'd rather keep the current behavior and have it operate on the entire repository. I think it will be too easy to make mistakes and leave out large portions of a patch if it only operates upon the current working directory. That's a fixable mistake, though, if/when it happens. Taking huge

Re: [webkit-dev] webkit-patch and SVN

2010-04-14 Thread Adam Barth
On Wed, Apr 14, 2010 at 4:52 PM, Geoffrey Garen gga...@apple.com wrote: I'd rather keep the current behavior and have it operate on the entire repository. I think it will be too easy to make mistakes and leave out large portions of a patch if it only operates upon the current working

Re: [webkit-dev] webkit-patch and SVN

2010-04-14 Thread Dirk Pranke
On Wed, Apr 14, 2010 at 2:13 PM, Eric Seidel e...@webkit.org wrote: Question: Do SVN users wish to have webkit-patch be current-working-directory aware? [snip] The propose change will make webkit-patch inconsistent between VCS tools, but consistent with the users choice of SVN vs. Git.  Is

Re: [webkit-dev] webkit-patch and SVN

2010-04-14 Thread Maciej Stachowiak
On Apr 14, 2010, at 2:13 PM, Eric Seidel wrote: Anders brought to my attention this afternoon that webkit-patch currently does all SVN operations from the root directory instead of being current-directory aware. That behavior matches how Git operates, but does not need to be how webkit-patch

Re: [webkit-dev] webkit-patch and SVN

2010-04-14 Thread Kalle Vahlman
2010/4/15 Dirk Pranke dpra...@chromium.org: On Wed, Apr 14, 2010 at 2:13 PM, Eric Seidel e...@webkit.org wrote: Question: Do SVN users wish to have webkit-patch be current-working-directory aware? [snip] The propose change will make webkit-patch inconsistent between VCS tools, but consistent

Re: [webkit-dev] webkit-patch and SVN

2010-04-14 Thread Dirk Pranke
On Wed, Apr 14, 2010 at 9:49 PM, Kalle Vahlman kalle.vahl...@gmail.com wrote: 2010/4/15 Dirk Pranke dpra...@chromium.org: On Wed, Apr 14, 2010 at 2:13 PM, Eric Seidel e...@webkit.org wrote: Question: Do SVN users wish to have webkit-patch be current-working-directory aware? [snip] The