Re: [webkit-dev] webkit2 with v8

2012-06-01 Thread Balazs Kelemen
On 05/31/2012 07:06 PM, Alexey Proskuryakov wrote: What I'm seeing is that parts of v8 support are already leaking into cross-platform WebKit2 code. WebKitTestRunner cannot just use WebCoreTestSupport, it needs an ifdef for Qt: #if PLATFORM(QT)

Re: [webkit-dev] webkit2 with v8

2012-06-01 Thread Alexey Proskuryakov
01.06.2012, в 7:18, Balazs Kelemen написал(а): This is of course something non-Qt developers have to worry about, see e.g. https://bugs.webkit.org/show_bug.cgi?id=87783#c14. This one could be avoided with the shim (in https://bugs.webkit.org/show_bug.cgi?id=87872). We could introduce a

Re: [webkit-dev] webkit2 with v8

2012-06-01 Thread Jake
I believe it's a disservice to the community as a whole to not provide proper javascript engine abstractions in webkit. On Fri, Jun 1, 2012 at 10:51 AM, Alexey Proskuryakov a...@webkit.org wrote: 01.06.2012, в 7:18, Balazs Kelemen написал(а): This is of course something non-Qt developers

Re: [webkit-dev] webkit2 with v8

2012-06-01 Thread Darin Adler
On Jun 1, 2012, at 9:55 AM, Jake j...@jakeonthenet.com wrote: I believe it's a disservice to the community as a whole to not provide proper javascript engine abstractions in webkit. I don’t agree. We should have abstractions for things that need to be abstract. Too many abstractions make

Re: [webkit-dev] webkit2 with v8

2012-06-01 Thread Jake
What constitutes a need? Qt obviously has a need for it. Is there a threshold of ports needing a feature before it becomes blessed? On Fri, Jun 1, 2012 at 11:09 AM, Darin Adler da...@apple.com wrote: On Jun 1, 2012, at 9:55 AM, Jake j...@jakeonthenet.com wrote: I believe it's a disservice

Re: [webkit-dev] webkit2 with v8

2012-06-01 Thread Darin Adler
Are you a WebKit developer? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] webkit2 with v8

2012-06-01 Thread Oliver Hunt
They may have a desire for it, but certainly not a need -- Webkit includes a well maintained, guaranteed ABI stable JS engine that works on _all_ architectures, with a high performance JIT support available on numerous architectures and OS's. Being able to support two engines just in webcore

Re: [webkit-dev] webkit2 with v8

2012-06-01 Thread Jake
Oliver - Ok, well that makes sense. I was under the mistaken impression webkit had an engine abstraction, and that it wasn't being move forward to webkit2. Darin - If by webkit developer you mean I contribute to webkit, then no. I do however use webkit in several projects. On Fri, Jun 1, 2012

Re: [webkit-dev] webkit2 with v8

2012-05-31 Thread Balazs Kelemen
I continued to work on this, more complete patches have been sent in https://bugs.webkit.org/show_bug.cgi?id=87872 and https://bugs.webkit.org/show_bug.cgi?id=84457. It's not because I don't understand your points, but it's better to debate on an actual patch that just theoretically :) I think

Re: [webkit-dev] webkit2 with v8

2012-05-31 Thread Alexey Proskuryakov
What I'm seeing is that parts of v8 support are already leaking into cross-platform WebKit2 code. WebKitTestRunner cannot just use WebCoreTestSupport, it needs an ifdef for Qt: #if PLATFORM(QT) DumpRenderTreeSupportQt::injectInternalsObject(context); #else

[webkit-dev] webkit2 with v8

2012-04-23 Thread Balazs Kelemen
Hi everyone, I would like to inform you about the topic I am working on, since it is something that can affect WebKit2 architecturally. I would like to make WebKit2 work with v8. The motivation behind this is that the long term goal of the Qt port is to switch to v8. Qt already use v8 in it's

Re: [webkit-dev] webkit2 with v8

2012-04-23 Thread Sam Weinig
Hi Balazs, This is something we don't want at this time. Dealing with V8 in WebCore is pretty big maintenance burden and one I would rather not have in WebKit2 unless there is considerable demand for it. In your patch (attached to https://bugs.webkit.org/show_bug.cgi?id=84457), there are

Re: [webkit-dev] webkit2 with v8

2012-04-23 Thread Balazs Kelemen
On 04/23/2012 11:53 PM, Sam Weinig wrote: Hi Balazs, This is something we don't want at this time. Dealing with V8 in WebCore is pretty big maintenance burden and one I would rather not have in WebKit2 unless there is considerable demand for it. Well, it's important for Qt. In your

Re: [webkit-dev] webkit2 with v8

2012-04-23 Thread Sam Weinig
Without considerable more demand, I don't think we want this. -Sam On Apr 23, 2012, at 3:20 PM, Balazs Kelemen kbal...@webkit.org wrote: On 04/23/2012 11:53 PM, Sam Weinig wrote: Hi Balazs, This is something we don't want at this time. Dealing with V8 in WebCore is pretty big