Re: [webkit-dev] what's important in layouttests?

2009-06-29 Thread David Jones
hi,Dan, Oliver.
 If I want to take it into my project, what should I do?

I do not understand this question.
I want to write a simple browser with webkit. By posting this questin, I am 
wondering if I should also take the layouttest together with my browser project.___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] what's important in layouttests?

2009-06-29 Thread tonikitoo (Antonio Gomes)
David, as far as I could understand your situation, you are not
implementing a new Port of WebKit, so no support to  a new toolkit or
something. If that is the case, the existing platform you are using
probably has layout tests already implemented. They are useful for
regression tests mainly, among other stuff...

2009/6/29 David Jones ds...@163.com:
 hi,Dan, Oliver.
 If I want to take it into my project, what should I do?

I do not understand this question.
 I want to write a simple browser with webkit. By posting this questin, I am
 wondering if I should also take the layouttest together with my browser
 project.

 
 200万种商品,最低价格,疯狂诱惑你
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev





-- 
--Antonio Gomes
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] what's important in layouttests?

2009-06-28 Thread tonikitoo (Antonio Gomes)
As addition resources, look at
http://webkit.org/quality/testwriting.html and
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree
to get into this deeper

Br

On Thu, Jun 25, 2009 at 11:04 PM, Oliver Huntoli...@apple.com wrote:
 Hi Dave,
 On Jun 25, 2009, at 7:54 PM, David Jones wrote:

 I am confused about webkit's layouttests.
 1.What's the layouttess used for? Are they provided only for developers
 who want to create a browser with webkit to test if their browser behaves
 right?

 The (increasing inaccurately named) LayoutTests directory contains most of
 the regression tests used to try to ensure that no knew patch breaks any
 existing functionality.  Every bug fix adds a new test so that the bug being
 fixed doesn't get reintroduced later.

 2.The layouttests use Safari to run all the tests, right?

 No.  The layout tests are run under the (also increasingly miss named)
 DumpRenderTree harness.  Basically this is a per-platform application that
 embeds a webview with a set of additional APIs added to the DOM to improve
 our ability to test behaviour.

 3.I noticed some tests need an app server, how do they start one?

 The http test directory requires a web server (i *think* apache), the
 run-webkit-tests script details at
 http://webkit.org/quality/testing.html will launch a new apache instance
 with all the correct parameters and settings required to get the correct
 behaviour.

 4.Is layouttest only for Leopard? If I want to take it into my project,
 what should I do?

 The test suite is for webkit across all platforms.  Some test do produce
 different output across platforms (particularly the pixel tests) but in
 general we try to ensure that the same test results are valid across all
 platforms and webkit ports.

 Hope this helps

 --Oliver

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev




-- 
--Antonio Gomes
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] what's important in layouttests?

2009-06-25 Thread David Jones
I am confused about webkit's layouttests.
1.What's the layouttess used for? Are they provided only for developers who 
want to create a browser with webkit to test if their browser behaves right?
2.The layouttests use Safari to run all the tests, right?
3.I noticed some tests need an app server, how do they start one?
4.Is layouttest only for Leopard? If I want to take it into my project, what 
should I do?


 ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] what's important in layouttests?

2009-06-25 Thread Dan Bernstein


On Jun 25, 2009, at 7:54 PM, David Jones wrote:


I am confused about webkit's layouttests.
1.What's the layouttess used for?


The layout tests are used to detect unintended changes in engine  
behavior, which are typically regressions.


Are they provided only for developers who want to create a browser  
with webkit to test if their browser behaves right?


No. They do not test browsers, they only test the WebKit engine. They  
are used by everyone who makes code changes to WebKit to ensure that  
the changes do not introduce regressions. Adding new tests when fixing  
bugs makes it almost impossible for the bug to come back undetected.



2.The layouttests use Safari to run all the tests, right?


No. The DumpRenderTree tool, which is part of the WebKit source tree,  
is used to run all of them. A script called run-webkit-tests drives  
DumpRenderTree.



3.I noticed some tests need an app server, how do they start one?


Some tests use a local HTTP server. run-webkit-tests sets it up, but  
you can also use run-webkit-httpd to start the server independently.



4.Is layouttest only for Leopard?


No. They are cross-platform. In some cases, the results differ  
depending on the platform. The LayoutTests directory includes expected  
test results for all tests. If a test has platform-specific results,  
they can appear in subdirectories of LayoutTests/platform. Cross- 
platform results live alongside the test.



If I want to take it into my project, what should I do?


I do not understand this question.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] what's important in layouttests?

2009-06-25 Thread Oliver Hunt

Hi Dave,
On Jun 25, 2009, at 7:54 PM, David Jones wrote:


I am confused about webkit's layouttests.
1.What's the layouttess used for? Are they provided only for  
developers who want to create a browser with webkit to test if their  
browser behaves right?
The (increasing inaccurately named) LayoutTests directory contains  
most of the regression tests used to try to ensure that no knew patch  
breaks any existing functionality.  Every bug fix adds a new test so  
that the bug being fixed doesn't get reintroduced later.



2.The layouttests use Safari to run all the tests, right?
No.  The layout tests are run under the (also increasingly miss named)  
DumpRenderTree harness.  Basically this is a per-platform application  
that embeds a webview with a set of additional APIs added to the DOM  
to improve our ability to test behaviour.



3.I noticed some tests need an app server, how do they start one?
The http test directory requires a web server (i *think* apache), the  
run-webkit-tests script details at http://webkit.org/quality/testing.html 
 will launch a new apache instance with all the correct parameters  
and settings required to get the correct behaviour.


4.Is layouttest only for Leopard? If I want to take it into my  
project, what should I do?
The test suite is for webkit across all platforms.  Some test do  
produce different output across platforms (particularly the pixel  
tests) but in general we try to ensure that the same test results are  
valid across all platforms and webkit ports.


Hope this helps

--Oliver

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev