Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

2019-02-14 Thread Mark Lam
Hi Xan, FYI, if you’re writing JSC stress tests, you can add test specific options by putting the following at the top of the test file: //@ requireOptions(“--myOption=true”, “--myOtherOption=1234”) For LayoutTests, you can add the following to the top line of the test html file: This way,

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

2019-02-14 Thread Xan Lopez
Hi Maciej, the first patches had the flag indeed, so it should be easy to add it back to the patch. Not sure what's the usual procedure, but I guess it makes sense to enable it by default in the bug so that the bots keep testing the code? Then we'll disable it before landing if that's our

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

2019-02-14 Thread Saam Barati
Hi Caitlin and Xan, > On Feb 13, 2019, at 1:51 PM, ca...@igalia.com wrote: > > Hi WebKitters, > > My colleagues at Igalia have been working on a number of JS language > features! We want WebKit to have implementations in order to provide feedback > for TC39, and to help meet the requirements

Re: [webkit-dev] Experimental features review

2019-02-14 Thread Michael Catanzaro
On Wed, Feb 13, 2019 at 9:16 PM, Simon Fraser wrote: For these two, we now have them on by default because we think they are ready to ship. They still exist as experimental features so that people can turn them off for regression testing, but is the policy now to move them back to Debug

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

2019-02-14 Thread Maciej Stachowiak
> On Feb 14, 2019, at 1:37 AM, Xan Lopez wrote: > > Hi Maciej, > > the first patches had the flag indeed, so it should be easy to add it back to > the patch. Not sure what's the usual procedure, but I guess it makes sense to > enable it by default in the bug so that the bots keep testing

Re: [webkit-dev] Experimental features review

2019-02-14 Thread Michael Catanzaro
No strong opinion from me here. I'm not familiar with how Safari's UI exposes some features but not others. In the GTK/WPE API, the features are not enumerable and only a few selected features are exposed at all, so that's not an issue for us. I do think we have a semantic issue, though,

Re: [webkit-dev] Experimental features review

2019-02-14 Thread Maciej Stachowiak
> On Feb 14, 2019, at 9:01 AM, Michael Catanzaro wrote: > > On Wed, Feb 13, 2019 at 9:16 PM, Simon Fraser wrote: >> For these two, we now have them on by default because we think they are >> ready to ship. They still exist as experimental features so that people can >> turn them off for