Re: [webkit-dev] Memory leaks in KJS

2008-09-04 Thread Geoffrey Garen
After rendering about 200 pages on my platform port of WebKit, I seem to be seeing some memory leaks involving the code in KJS, totalling 30-70MB. I have included a subgraph of the call graph for the leaking functions. I'm not familiar with the KJS code. Is it possible that circular

[webkit-dev] Compilation errors with ARM RVCT Compiler

2008-09-04 Thread Shadakshari Hiremath
Hi Webkit Forum, I am getting compilation errors while compiling webcore and javascriptcore with ARM RVCT compiler version 2.2 build 559. This is my maiden attempt to build webkit with RVCT compiler. Three errors are appearing while compiling many source files. I have provided Attr.cpp as an

Re: [webkit-dev] Fix for Vector::m_inlineBuffer alignment?

2008-09-04 Thread Alexey Proskuryakov
On Sep 4, 2008, at 2:05 AM, Paul Pedriana wrote: I see that JavaScriptCore/wtf/Vector.h has this: // FIXME: Nothing guarantees this buffer is appropriately aligned to hold objects of type T. char m_inlineBuffer[m_inlineBufferSize]; We have a bug for this:

Re: [webkit-dev] Fix for Vector::m_inlineBuffer alignment?

2008-09-04 Thread Paul Pedriana
Well the proposed solution in https://bugs.webkit.org/show_bug.cgi?id=16925 doesn't work, as VC++ doesn't accept that syntax. And the solutions in https://bugs.webkit.org/show_bug.cgi?id=19775 whereby a uint32_t or uint64_t buffer are made don't work for larger types and use more memory than

[webkit-dev] WTF_USE_LOW_BANDWIDTH_DISPLAY

2008-09-04 Thread Mikael Tennhammar
Hi ! It is not possible to disable or enable the WTF_USE_LOW_BANDWIDTH_DISPLAY option via the ./configure options, is this the way it should be, to not have an enormous amount of options? And if so where would be the preferred place to activate it ? /Mikael

Re: [webkit-dev] Fix for Vector::m_inlineBuffer alignment?

2008-09-04 Thread Paul Pedriana
This is a hardware issue and can vary between different versions. Some hardware of course generates an unhandled exception on unaligned access; some hardware generates an internally handled exception and restarts the access with a different and more expensive pathway or with microcode; some

Re: [webkit-dev] Fix for Vector::m_inlineBuffer alignment?

2008-09-04 Thread Alexey Proskuryakov
That's a great list of subtle issues (I can add that atomicity guarantees are different for non-aligned access sometimes) - it would be fantastic if we could amend it with actual data, say SunSpider results and/or DOM performance tests on Intel Mac and/or Windows. If we got an improvement

Re: [webkit-dev] WTF_USE_LOW_BANDWIDTH_DISPLAY

2008-09-04 Thread David Kilzer
WTF_USE_LOW_BANDWIDTH_DISPLAY should be defined in JavaScriptCore/wtf/Platform.h for your platform. I don't think any of the main ports in the WebKit repository use this feature, which is why it probably doesn't work when enabled. Please file a bug on https://bugs.webkit.org/ (and a patch to

Re: [webkit-dev] Where can I get basic WebKit software?

2008-09-04 Thread David Kilzer
You must check out the source code from Subversion: http://webkit.org/building/checkout.html Or git: http://trac.webkit.org/wiki/UsingGitWithWebKit Note that the code base contains code for all the ports, but each platform's code is under a platform/platformname directory, so you know which

Re: [webkit-dev] WebKit-r36013 does not build on Mac OS X 10.5.4 PPC G5

2008-09-04 Thread David Kilzer
Here is the problem: setenv BUILT_PRODUCTS_DIR /Users/fzerangue/ws/WebKit/JavaScriptGlue/build/Release The build process for WebKit requires that the BUILT_PRODUCTS_DIR be the same for all of the projects. It looks like your Xcode is set up to always store build products within the

Re: [webkit-dev] WebKit-r36013 does not build on Mac OS X 10.5.4 PPC G5

2008-09-04 Thread Frank Zerangue
That did the trick -- Thanks, Frank On Sep 4, 2008, at 1:49 PM, David Kilzer wrote: Here is the problem: setenv BUILT_PRODUCTS_DIR /Users/fzerangue/ws/WebKit/ JavaScriptGlue/build/Release The build process for WebKit requires that the BUILT_PRODUCTS_DIR be the same for all of the

Re: [webkit-dev] Platform network did.* semantics for status 404 with HTML body

2008-09-04 Thread David Kilzer
A similar bug related to stylesheets was filed as Bug 7381 and again as Bug 15242. https://bugs.webkit.org/show_bug.cgi?id=7381 https://bugs.webkit.org/show_bug.cgi?id=15242 It was fixed as part of Bug 16760 in r30438. https://bugs.webkit.org/show_bug.cgi?id=16760

Re: [webkit-dev] Compilation errors with ARM RVCT Compiler

2008-09-04 Thread Paul Pedriana
It looks to me like the problem is due to a template implementation not being visible to the code being compiled. GCC and VC++ don't enforce the C++ standard strictly here, and the CodeWarrior and EDG-based compilers correctly flag this as invalid code. VC++ compiles templates by essentially