Re: [webkit-dev] Stability problems involving Javascript GC

2010-12-17 Thread Zoltan Herczeg
On 6 December 2010 22:31, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: Crash in WTF::fastMalloc? Such things only happen if something overwrites memory areas belongs to the memory manager (i.e overwrites some bytes before or after a block returned by malloc). Try some valgrind

Re: [webkit-dev] Stability problems involving Javascript GC

2010-12-17 Thread Samuel Rivas
I haven't received your reply before. To capture this bug, you have to disable fastmalloc, and use the internal (trackable) memory allocator replacement of valgrind. Run build-webkit --system-malloc This will redirect all allocations to the system malloc. Thanks. That's a good point. I

Re: [webkit-dev] Stability problems involving Javascript GC

2010-12-17 Thread Samuel Rivas
It is possible to add macros to the code to help valgrind know which areas are being used by a custom allocator.  (See VALGRIND_MALLOCLIKE_BLOCK and VALGRIND_FREELIKE_BLOCK, for example.)  I'm not sure if they're useful in this situation, but they're worth taking a look at. I see. That

Re: [webkit-dev] Stability problems involving Javascript GC

2010-12-17 Thread Zoltan Herczeg
It is possible to add macros to the code to help valgrind know which areas are being used by a custom allocator.  (See VALGRIND_MALLOCLIKE_BLOCK and VALGRIND_FREELIKE_BLOCK, for example.)  I'm not sure if they're useful in this situation, but they're worth taking a look at. I see. That

Re: [webkit-dev] Question about StringImpl::create

2010-12-17 Thread Darin Adler
On Dec 16, 2010, at 10:36 PM, Gavin Barraclough wrote: The short answer is that String::format should be considered deprecated - its behavior is platform-specific, and we'd like to move away from it. We should probably put a comment in WTFString.h that says something along these lines.

Re: [webkit-dev] Build Slave Shutdown

2010-12-17 Thread Leandro Pereira
On Thu, Dec 16, 2010 at 3:05 PM, William Siegrist wsiegr...@apple.com wrote: Our buildbot allows for anonymous people to trigger things on the slaves, and it is like this on purpose for ease of use. However, that means it is possible for a malicious person to do things like shutdown all of the

Re: [webkit-dev] Build Slave Shutdown

2010-12-17 Thread William Siegrist
On Dec 17, 2010, at 11:53 AM, Leandro Pereira wrote: On Thu, Dec 16, 2010 at 3:05 PM, William Siegrist wsiegr...@apple.com wrote: Our buildbot allows for anonymous people to trigger things on the slaves, and it is like this on purpose for ease of use. However, that means it is possible for a

[webkit-dev] WebKitTools has changed to Tools

2010-12-17 Thread Dan Bernstein
Done in r74301. On Nov 20, 2010, at 11:29 PM, Dan Bernstein wrote: WebKit developers, I am going to commit the patch from https://bugs.webkit.org/show_bug.cgi?id=49861, renaming the WebKitTools directory to Tools and updating all internal references. If you update your tree after that,