Re: [webkit-dev] Blog post(s) about layout tests

2011-01-27 Thread Ryan Leavengood
On Tue, Jan 25, 2011 at 9:24 PM, Mihai Parparita mih...@chromium.org wrote: The post is link-heavy (generally into Trac, and Bugzilla), I'm hoping that would also encourage exploration of the code/site by people interested in contributing. As a WebKit porter who is actually not very familiar

Re: [webkit-dev] Blog post(s) about layout tests

2011-01-27 Thread Jeremy Orlow
On Thu, Jan 27, 2011 at 9:32 AM, Ryan Leavengood leaveng...@gmail.comwrote: On Tue, Jan 25, 2011 at 9:24 PM, Mihai Parparita mih...@chromium.org wrote: The post is link-heavy (generally into Trac, and Bugzilla), I'm hoping that would also encourage exploration of the code/site by people

Re: [webkit-dev] Blog post(s) about layout tests

2011-01-27 Thread Eric Seidel
I actually really enjoyed the inline links. And in general very much enjoyed the article. I look forward to many more. Thanks again Mihai! -eric On Thu, Jan 27, 2011 at 1:15 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Jan 27, 2011 at 9:32 AM, Ryan Leavengood leaveng...@gmail.com

[webkit-dev] Need help on running prepare-ChangeLog from git branch.

2011-01-27 Thread Jia Pu
Hello, I'd like to run prepare-ChangeLog based on a particular commit on a branch. When I do a git diff on this branch and master, it shows modified files in both WebCore and LayoutTests directories. However, when I run prepare-ChangeLog with --git-commit option, the script only updates the

Re: [webkit-dev] Need help on running prepare-ChangeLog from git branch.

2011-01-27 Thread Jia Pu
Thanks, Dirk. I think the problem is me misunderstanding the meaning of -g option. What it does is to generate diff between specified-commit and specified-commit^. I thought it would do a diff between specified-commit and the current remote branch that master is based on. It seems what I

Re: [webkit-dev] Need help on running prepare-ChangeLog from git branch.

2011-01-27 Thread Dirk Pranke
You can also use the git X..Y notation to avoid the squash (but you won't get any changes in the checkout or index, just the committed version). I do that quite frequently. -- Dirk On Thu, Jan 27, 2011 at 2:16 PM, Jia Pu j...@apple.com wrote: Thanks, Dirk. I think the problem is me

[webkit-dev] coding style and comments

2011-01-27 Thread Dirk Pranke
Hi all, Have there been any threads or blog posts in the past over an appropriate level of comments in the code? A brief search of the Google and the list archives didn't really turn up anything. From what I've seen, code in WebKit is much less commented than most if not all large projects I've

Re: [webkit-dev] coding style and comments

2011-01-27 Thread Eric Seidel
My personal preference (and I'd love to hear from other contributors) is that code should ideally be self-documenting. If I ever find myself writing a what does this do comment, I try to re-write the code to be easier to read. Normally that means breaking it into smaller pieces, and using static

Re: [webkit-dev] coding style and comments

2011-01-27 Thread Darin Adler
On the WebKit project we like “why” comments, but not “what” comments. Comments that say what the next block of code does usually are not a good idea. Instead by using appropriate names and granularity we want the code itself to say what the comment would have. We also frown on “textbook”

Re: [webkit-dev] coding style and comments

2011-01-27 Thread Ryosuke Niwa
On Thu, Jan 27, 2011 at 3:46 PM, Eric Seidel e...@webkit.org wrote: My personal preference (and I'd love to hear from other contributors) is that code should ideally be self-documenting. I strongly agree with this point. One pit-fall of adding comments is that it gives an illusion of the

Re: [webkit-dev] Blog post(s) about layout tests

2011-01-27 Thread Ojan Vafai
Looks great to me. I think web developers are interested in browser testing and this can be a resource we point them to in order to help them understand how to write good reduced test cases. In fact, a post about writing good reduced test cases for bugs would be a great followup. On Wednesday,

Re: [webkit-dev] coding style and comments

2011-01-27 Thread Simon Fraser
On Jan 27, 2011, at 3:55 PM, Ryosuke Niwa wrote: On Thu, Jan 27, 2011 at 3:46 PM, Eric Seidel e...@webkit.org wrote: My personal preference (and I'd love to hear from other contributors) is that code should ideally be self-documenting. I strongly agree with this point. One pit-fall of

Re: [webkit-dev] coding style and comments

2011-01-27 Thread Dirk Pranke
I agree with all of the sentiments below, except for possibly one or two cases. Namely, sometimes you write code where the what is not obvious. In that situation, it may not be possible to change the code to make it more obvious, because you are bound by contract. For example, suppose you are

Re: [webkit-dev] coding style and comments

2011-01-27 Thread Dirk Pranke
Two other ways to potentially answer these questions: 1) What are files that you all think *are* well commented? (pointing at files that aren't probably isn't that useful, and is certainly meaner ;). 2) One file over in that same directory, is a filesystem.py file that I wrote (most of). I think

[webkit-dev] style checking and build failed without any useful info.

2011-01-27 Thread Jia Pu
What can I do when style checking and build bot all failed without any useful info? https://webkit-commit-queue.appspot.com/patch/80372 The patch did build and pass style checking locally. Thanks. Jia___ webkit-dev mailing list

Re: [webkit-dev] style checking and build failed without any useful info.

2011-01-27 Thread Adam Barth
Strange. We've had problems before where the writes don't quite make it all the way to AppEngine (which hosts queues.webkit.org), but it's strange that all the bots would run into the same problem. It might be worth uploading the patch again to see if the problem recurs. Eric or I can also dig

[webkit-dev] about QtWebKit documentation

2011-01-27 Thread Kanazawa Yoshiko
Hi,everyone. I am new here. I have a question about Qtwebkit documentation. I found very similar question http://lists.trolltech.com/qt-interest/2008-09/msg00805.html (more than 2 years ago) but it seems he didn't get clear answer. So I post here again,sorry. His question is almost the same

Re: [webkit-dev] coding style and comments

2011-01-27 Thread Ryan Leavengood
On Thu, Jan 27, 2011 at 7:27 PM, Simon Fraser simon.fra...@apple.com wrote: I think we have a distinct lack of comments that help novices to understand the code. I feel that we almost have a privileged few mentality in some code; if you can't figure it out by reading the code, then you

Re: [webkit-dev] style checking and build failed without any useful info.

2011-01-27 Thread Jia Pu
I just tried again, and got the same failure. There two things I can think of that are different from the patches I have submitted before: 1. This is the first time I use git-diff instead of svn-create-patch to generate the patch. 2. This patch is significantly larger, $190KB. Adam, please

Re: [webkit-dev] style checking and build failed without any useful info.

2011-01-27 Thread Jia Pu
On Jan 27, 2011, at 9:07 PM, Jia Pu wrote: I just tried again, and got the same failure. There two things I can think of that are different from the patches I have submitted before: 1. This is the first time I use git-diff instead of svn-create-patch to generate the patch. Now think

Re: [webkit-dev] style checking and build failed without any useful info.

2011-01-27 Thread Ryosuke Niwa
I'm surprised that you don't use Tools/Scripts/webkit-patch upload bug number. - Ryosuke On Thu, Jan 27, 2011 at 9:43 PM, Jia Pu j...@apple.com wrote: On Jan 27, 2011, at 9:07 PM, Jia Pu wrote: I just tried again, and got the same failure. There two things I can think of that are

Re: [webkit-dev] style checking and build failed without any useful info.

2011-01-27 Thread Adam Barth
On Thu, Jan 27, 2011 at 9:48 PM, Ryosuke Niwa rn...@webkit.org wrote: I'm surprised that you don't use Tools/Scripts/webkit-patch upload bug number. That uses git diff under the covers. I'm pretty sure it uses --binary. In any case, the system is optimized for patches produced with