Re: [webkit-dev] Expect Commit Queue delays

2011-02-04 Thread Eric Seidel
The bots are all back in working order. We've added an additional two machines to the cluster. Meaning we have now 5 commit-queue bots. The new machines are slower than some of our previous machines, taking up to an hour for a clean build. As long as the tree at build.webkit.org is green, we

Re: [webkit-dev] Implementing the device element

2011-02-04 Thread Leandro Graciá Gil
El 3 de febrero de 2011 18:59, Adam Bergkvist adam.bergkv...@ericsson.com escribió: Hi, Leandro Graciá Gil wrote: The approach proposed in https://bugs.webkit.org/show_bug.cgi?id=47264 brings the device probing and selection to the WebCore level. It does so by first creating a list of

Re: [webkit-dev] Proposal to Reorganize Position Classes

2011-02-04 Thread Darin Adler
On Feb 1, 2011, at 6:51 PM, Ryosuke Niwa wrote: • DOMPosition or SimplePosition - This class solely works on DOM, and is agnostic of renderers and other parts of WebCore. It's meant to be used in utility functions and classes or passed along between renderers and WebCore/dom. It

Re: [webkit-dev] Proposal to Reorganize Position Classes

2011-02-04 Thread Ryosuke Niwa
On Fri, Feb 4, 2011 at 10:30 AM, Darin Adler da...@apple.com wrote: On Feb 1, 2011, at 6:51 PM, Ryosuke Niwa wrote: • DOMPosition or SimplePosition - This class solely works on DOM, and is agnostic of renderers and other parts of WebCore. It's meant to be used in utility functions

[webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Adam Roben
Hi all- The results.html pages on build.webkit.org now make it much easier to triage crashing tests on Mac and Windows XP (Windows Vista/7 are blocked by http://webkit.org/b/44135). When a test crashes, you'll see something like this on Mac: fast/events/tabindex-focus-blur-all.html

Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread David Levin
Kudos! On Fri, Feb 4, 2011 at 11:25 AM, Adam Roben aro...@apple.com wrote: Hi all- The results.html pages on build.webkit.org now make it much easier to triage crashing tests on Mac and Windows XP (Windows Vista/7 are blocked by http://webkit.org/b/44135). When a test crashes, you'll see

Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Adam Roben
On Feb 4, 2011, at 2:25 PM, Adam Roben wrote: The new crash log link will take you to a textual crash log for that test. And on Windows, the crashing line of code is even included in the log, like this: FAULTING_SOURCE_CODE: 105: 106: void

[webkit-dev] jsc compilation error

2011-02-04 Thread Deric Panet-Raymond
Hello, I'm experiencing a link failure when attempting to compile the jsc for an embedded platform. The error is as follows; Linking CXX executable jsc_sb CMakeFiles/jsc_sb.dir/__/jsc.cpp.o:(.gnu.linkonce.d._ZTI12GlobalObject+0x8): undefined reference to `typeinfo for JSC::JSGlobalObject'

Re: [webkit-dev] jsc compilation error

2011-02-04 Thread Patrick Gansterer
I'm experiencing a link failure when attempting to compile the jsc for an embedded platform. If you write a mail to this list: Please provide more information! What is embedded platform? Which architecture? Which port? BTW: This is more a question for webkit-help and not form webkit-dev. See

Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Jerome Duval
Seems like a nice feature. Why the different bases for the offsets between Mac and Windows? On 11-02-04 02:25 PM, Adam Roben wrote: Hi all- The results.html pages on build.webkit.org http://build.webkit.org now make it much easier to triage crashing tests on Mac and Windows XP (Windows

Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Adam Roben
On Feb 4, 2011, at 3:29 PM, Jerome Duval wrote: Seems like a nice feature. Why the different bases for the offsets between Mac and Windows? That's just how the offsets are represented by default in each platform's crash logs. It shouldn't be hard to convert to a common base, though. Feel

Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Jerome Duval
Rethinking about it, I don't really care that the bases are different. I care that the Windows base is different from what I would expect. I filed bug 53803 https://bugs.webkit.org/show_bug.cgi?id=53803 about it. Jerome On 11-02-04 03:29 PM, Adam Roben wrote: On Feb 4, 2011, at 3:29 PM,

Re: [webkit-dev] Implementing the device element

2011-02-04 Thread Leandro Graciá Gil
El 4 de febrero de 2011 18:21, Leandro Graciá Gil leandrogra...@chromium.org escribió: I have also created a small diagram to explain how our implementation works: https://docs.google.com/a/google.com/drawings/edit?id=1jSW-6MJd8mp2qPvwnvZnBVzll6UtBz3r1viZgTE4XVAhl=enauthkey=CPLpy5oJ It

[webkit-dev] Thanks for a green tree

2011-02-04 Thread Adam Barth
I'd like to thank everyone who's been working to make the tree green again. The tree has been pretty red these past few days, which makes it harder to prevent regressions. I was pleasantly surprised to pull up the tree just now and see lots of green boxes. Thanks! Adam P.S., It looks like we

[webkit-dev] Nightly (r77618) hangs when submitting a review

2011-02-04 Thread Ryosuke Niwa
Hi, My nightly build r77618 hangs whenever I submit a review. Is this happening to anyone else? Best, Ryosuke Niwa Software Engineer Google Inc. ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Nightly (r77618) hangs when submitting a review

2011-02-04 Thread Simon Fraser
What's the bugzilla bug number? Simon On Feb 4, 2011, at 5:23 PM, Ryosuke Niwa wrote: Hi, My nightly build r77618 hangs whenever I submit a review. Is this happening to anyone else? Best, Ryosuke Niwa Software Engineer Google Inc. ___

Re: [webkit-dev] Nightly (r77618) hangs when submitting a review

2011-02-04 Thread Adam Barth
Sorry, that's probably my fault. Mitz kindly fixed the issue for me (although he didn't add a test): http://trac.webkit.org/changeset/77697 Apologies for the inconvenience. We've switched over to a new XSS filter in last night's nightly, so let me know if you have any XSS filter-related