Re: [webkit-dev] …Inlines.h vs …InlineMethods.h

2012-11-03 Thread Filip Pizlo
On Nov 2, 2012, at 5:48 PM, Mark Lam mark@apple.com wrote: FYI, some time in the near future (maybe this weekend), I plan to do some work to break inline methods in JavaScriptCore out of header files into their own inline header files. Naming-wise, the existing JSC code has a few

Re: [webkit-dev] …Inlines.h vs …InlineMethods.h

2012-11-03 Thread Filip Pizlo
On Nov 3, 2012, at 10:09 AM, Mark Lam mark@apple.com wrote: On Nov 3, 2012, at 2:11 AM, Maciej Stachowiak m...@apple.com wrote: On Nov 3, 2012, at 1:48 AM, Mark Lam mark@apple.com wrote: 1. If the inline method is a 1 liner, then leave it in the original header file. 2. If it

Re: [webkit-dev] …Inlines.h vs …InlineMethods.h

2012-11-03 Thread Darin Adler
On Nov 3, 2012, at 10:09 AM, Mark Lam mark@apple.com wrote: 1. to keep class definitions more compact - so you can see more of the entire class (not that this is always possible anyway). - being able to see the entire class (when possible) can yield useful information about the