Hello, lovely WebKit folks.
If you never generate console messages for developers (seriously?), you can
stop reading.
Two changes have landed in the last week or so that I'd like to make you
aware of:
1. Call stacks or url/line numbers will now be autogenerated in the common
case
Hi,
2012/12/4 Tor Arne Vestbø tor.arne.ves...@digia.com:
Bill, what do you think about pushing the official SVN import to GitHub as
well?
tor arne
Any updates about this?
Cheers,
jesus
So we might be able to rename the existing one and ask github to pull
our git.webkit.org
Hi,
Please don't roll out patches speculatively unless that's the only way to
diagnose the problem. Even then you should really go talk to authors and
make sure they're okay with it. And please re-land patches that didn't
cause test failures or regressions promptly once you've fixed
or diagnosed
I'll have to disagree with you here.
If the build is broken and the gardener/build cop has a strong reason
to suspect that it was caused by a specific patch and the author is
unavailable then rolling that patch out is the right thing to do. It
might inconvenience the author but it is the
On Tue, Dec 11, 2012 at 12:17 PM, Emil A Eklund e...@chromium.org wrote:
I'll have to disagree with you here.
If the build is broken and the gardener/build cop has a strong reason
to suspect that it was caused by a specific patch and the author is
unavailable then rolling that patch out is
On Tue, Dec 11, 2012 at 12:19 PM, Ojan Vafai o...@chromium.org wrote:
On Tue, Dec 11, 2012 at 12:17 PM, Emil A Eklund e...@chromium.org wrote:
I'll have to disagree with you here.
If the build is broken and the gardener/build cop has a strong reason
to suspect that it was caused by a
On Tue, Dec 11, 2012 at 1:11 PM, Emil A Eklund e...@chromium.org wrote:
On Tue, Dec 11, 2012 at 12:19 PM, Ojan Vafai o...@chromium.org wrote:
On Tue, Dec 11, 2012 at 12:17 PM, Emil A Eklund e...@chromium.org
wrote:
I'll have to disagree with you here.
If the build is broken and the
On Tue, Dec 11, 2012 at 1:11 PM, Emil A Eklund e...@chromium.org wrote:
That said, if your strong reason turned out to be incorrect, you should
recommit the patch, no?
That seems like a bad idea, someone that understands the patch should
recommit it. Ideally the original author.
I don't
On Tue, Dec 11, 2012 at 1:14 PM, Peter Kasting pkast...@chromium.org wrote:
On Tue, Dec 11, 2012 at 1:11 PM, Emil A Eklund e...@chromium.org wrote:
That said, if your strong reason turned out to be incorrect, you should
recommit the patch, no?
That seems like a bad idea, someone that
On Tue, Dec 11, 2012 at 1:19 PM, Emil A Eklund e...@chromium.org wrote:
I don't understand your logic. A patch landed, the sheriff thinks maybe
it
was bad and rolls it out, then it turns out it was a red herring. Why
is it
not now the sheriff's responsibility to re-land? After all, the
On Tue, Dec 11, 2012 at 12:17 PM, Emil A Eklund e...@chromium.org wrote:
If the build is broken and the gardener/build cop has a strong reason
to suspect that it was caused by a specific patch and the author is
unavailable then rolling that patch out is the right thing to do.
Sure. If the
Hi,
I've encountered a couple of incidences where people roll out patches
saying that test X is failing on some downstream project Y without giving
any details as to how those tests are failing and why that's a real WebKit
regression we should care about.
First off, I don't think we should be
I don't understand why anyone is _speculatively_ rolling out patches.
You should only be rolling it out if you _know_ the patch is bad.
That said if you do rollout a random unrelated patch it is obviously your job
to roll it back in. You can't say i thought this broke something, but i was
On Tue, Dec 11, 2012 at 2:14 PM, Oliver Hunt oli...@apple.com wrote:
I don't understand why anyone is _speculatively_ rolling out patches.
You should only be rolling it out if you _know_ the patch is bad.
Sometimes something bad happens to the tree, the sheriff doesn't know which
patch is
On Dec 11, 2012, at 2:17 PM, Peter Kasting pkast...@chromium.org wrote:
On Tue, Dec 11, 2012 at 2:14 PM, Oliver Hunt oli...@apple.com wrote:
I don't understand why anyone is _speculatively_ rolling out patches.
You should only be rolling it out if you _know_ the patch is bad.
Sometimes
On Tue, Dec 11, 2012 at 2:20 PM, Oliver Hunt oli...@apple.com wrote:
Or the sheriff could actually see if rolling out a patch locally fixes the
problem. I'm not sure why they're considering not testing to be a valid
behaviour for someone who is ostensibly meant to be keeping things going in
The build cop / gardener / sheriff / whatever may not have local or
easy access to a bot that reproduces the problem ... rolling it out
might be the only feasible way to test in that case.
On Tue, Dec 11, 2012 at 2:20 PM, Oliver Hunt oli...@apple.com wrote:
On Dec 11, 2012, at 2:17 PM, Peter
On Tue, Dec 11, 2012 at 2:17 PM, Peter Kasting pkast...@chromium.orgwrote:
On Tue, Dec 11, 2012 at 2:14 PM, Oliver Hunt oli...@apple.com wrote:
I don't understand why anyone is _speculatively_ rolling out patches.
You should only be rolling it out if you _know_ the patch is bad.
Sometimes
This is now complete:
http://trac.webkit.org/changeset/137371
I'm watching the bots. Please contact me if you have any trouble.
Thank you all for your feedback.
On Mon, Dec 10, 2012 at 10:11 AM, Dirk Pranke dpra...@chromium.org wrote:
On Mon, Dec 10, 2012 at 1:30 AM, Jochen Eisinger
Nevermind. After further discussion with Nico, this can't work yet.
Ninja is currently configured to use a non-webkitty out build
directory, which is undoubtably going to confus some scripts/bots.
We'll try this again at a later time. Apologies for the noise.
Do you have an example of when this has occurred? It's good to have
examples if we want to prevent this in the future.
On Tue, Dec 11, 2012 at 1:44 PM, Ryosuke Niwa rn...@webkit.org wrote:
Hi,
I've encountered a couple of incidences where people roll out patches
saying that test X is
On Tue, Dec 11, 2012 at 7:20 PM, Elliott Sprehn espr...@chromium.orgwrote:
Do you have an example of when this has occurred? It's good to have
examples if we want to prevent this in the future.
Yes. I'd rather not publicly humiliate someone on webkit-dev so I'll send
you a bug URL in private.
On 2012-12-11, at 19:34, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Dec 11, 2012 at 7:20 PM, Elliott Sprehn espr...@chromium.org wrote:
Do you have an example of when this has occurred? It's good to have examples
if we want to prevent this in the future.
Yes. I'd rather not publicly
On Dec 11, 2012, at 7:34 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Dec 11, 2012 at 7:20 PM, Elliott Sprehn espr...@chromium.org wrote:
Do you have an example of when this has occurred? It's good to have examples
if we want to prevent this in the future.
Yes. I'd rather not publicly
On Tue, Dec 11, 2012 at 1:44 PM, Ryosuke Niwa rn...@webkit.org wrote:
First off, I don't think we should be rolling out patches based solely on
a downstream test unless there is a clear evidence that the failure is a
real regression in WebKit that affects more than just the said downstream
Was this an isolated incident then?
On Tue, Dec 11, 2012 at 8:39 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Dec 11, 2012 at 1:44 PM, Ryosuke Niwa rn...@webkit.org wrote:
First off, I don't think we should be rolling out patches based solely on
a downstream test unless there is a clear
On Tue, Dec 11, 2012 at 8:44 PM, David Levin le...@google.com wrote:
Was this an isolated incident then?
Well, it was done by a Chromium contributor but I’ve seen it happening
every now and then in the past though I’ve lost those references. I’ve
given Darin (fishd) more details if you’re
Hi all,
There's a bug reported against Chromium (crbug.com/144757) for the CapsLock
key generating only a keydown when first pressed and released, and a keyup
when next pressed and released, i.e. the keydown keyup events correspond
with the caps lock-state being toggled, rather than with the key
On 2012-12-11, at 21:24, Wez w...@chromium.org wrote:
Hi all,
There's a bug reported against Chromium (crbug.com/144757) for the CapsLock
key generating only a keydown when first pressed and released, and a keyup
when next pressed and released, i.e. the keydown keyup events correspond
Does this reproduce on every platform? If it's a OS X issue then it should
work on Windows or Linux I'd hope.
- E
On Tue, Dec 11, 2012 at 9:32 PM, Mark Rowe mr...@apple.com wrote:
On 2012-12-11, at 21:24, Wez w...@chromium.org wrote:
Hi all,
There's a bug reported against Chromium
This seems to be Mac-specific in Chromium browsers.
Wez
On Tuesday, 11 December 2012, Elliott Sprehn wrote:
Does this reproduce on every platform? If it's a OS X issue then it should
work on Windows or Linux I'd hope.
- E
On Tue, Dec 11, 2012 at 9:32 PM, Mark Rowe
31 matches
Mail list logo
