Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?

2013-08-21 Thread Carlos Garcia Campos
El mar, 20-08-2013 a las 10:41 -0700, Martin Robinson escribió: On Mon, Aug 19, 2013 at 10:16 PM, Ryosuke Niwa rn...@webkit.org wrote: Are Qt and GTK+ (and other) ports intentionally returning false in shouldShowPlaceholderWhenFocused? Or is this just an oversight due to the fact the

Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?

2013-08-21 Thread Kangil Han
+1 -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Carlos Garcia Campos Sent: Wednesday, August 21, 2013 3:08 PM To: Martin Robinson Cc: WebKit Development Subject: Re: [webkit-dev] Are Qt and GTK+ intentionally

[webkit-dev] Fwd: Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?

2013-08-21 Thread Ryosuke Niwa
Does that mean we want the new Mac behavior (i.e. shouldShowPlaceholderWhenFocused returning true) everywhere? - R. Niwa On Tue, Aug 20, 2013 at 11:35 PM, Kangil Han kangil@samsung.com wrote: +1 -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:

Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?

2013-08-21 Thread Carlos Garcia Campos
El mar, 20-08-2013 a las 23:41 -0700, Ryosuke Niwa escribió: Does that mean we want the new Mac behavior (i.e. shouldShowPlaceholderWhenFocused returning true) everywhere? I think so unless any GTK+ port maintainer disagree, but consistency with the platform is important too, so I'll first

[webkit-dev] ChangeLog format

2013-08-21 Thread Ryosuke Niwa
Hi, I have noticed that the change log format has recently been changed. Unfortunately, this didn't work well with all webkitpy tools we have, and has been rolled out in http://trac.webkit.org/changeset/154406. *I kindly ask you to manually edit your patch to use the old format before landing

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Ryosuke Niwa
On Wed, Aug 21, 2013 at 2:04 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, I have noticed that the change log format has recently been changed. Unfortunately, this didn't work well with all webkitpy tools we have, and has been rolled out in http://trac.webkit.org/changeset/154406. *I

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Brady Eidson
On Aug 21, 2013, at 2:04 PM, Ryosuke Niwa rn...@webkit.org wrote: Separately, I'd like to know whether people liked the new format and it's worth my time making webkitpy adopt the new format. I personally didn't like the old format because it made the first line of each change log too

[webkit-dev] Does Qt ARM support NRWT?

2013-08-21 Thread Ryosuke Niwa
Hi, It seems like the only port that uses ORWT by default is Qt ARM (and iOS) at this point. Is it true that Qt ARM still doesn't support NRWT as this comment indicates? sub useNewRunWebKitTests() { # NRWT does not support qt-arm: https://bugs.webkit.org/show_bug.cgi?id=64086 return 0

Re: [webkit-dev] Does Qt ARM support NRWT?

2013-08-21 Thread Osztrogonác Csaba
Hi, Thanks for the heads-up. I'm not working on Qt port nowadays, but some of my colleagues (azbest_hu, kadam and abrhm). I cc-ed them to this thread. I can confirm that Qt ARM didn't support NRWT long long time ago, but the Qt ARM bot on http://build.webkit.sed.hu was switched to use NRWT

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Gavin Barraclough
I’m a bit of a luddite and edit my change log entries by hand. The old format is more amenable to this, the new format is a regression. cheers, G. On Aug 21, 2013, at 2:25 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Aug 21, 2013 at 2:04 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, I

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Carlos Garcia Campos
El mié, 21-08-2013 a las 14:04 -0700, Ryosuke Niwa escribió: Hi, [...] Separately, I'd like to know whether people liked the new format and it's worth my time making webkitpy adopt the new format. I prefer the old format. I personally didn't like the old format because it made the first

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Ryosuke Niwa
On Wed, Aug 21, 2013 at 10:50 PM, Carlos Garcia Campos carlo...@webkit.orgwrote: El mié, 21-08-2013 a las 14:04 -0700, Ryosuke Niwa escribió: Hi, [...] Separately, I'd like to know whether people liked the new format and it's worth my time making webkitpy adopt the new format. I