Re: [webkit-dev] Remove the WinCE bot?

2014-01-06 Thread Osztrogonác Csaba
Hi, +1 for removing the WinCE bot, it seems it isn't maintained at all. The latest build on it was on 8th Aug, it is offline since then: http://build.webkit.org/builders/WinCE%20Release%20%28Build%29/builds/36154 Additionally the latest build in the build.webkit.org history was on 6 th Jun and

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-06 Thread Alexey Proskuryakov
04 янв. 2014 г., в 9:51, Darin Adler da...@apple.com написал(а): There are so many other things which you can’t see when reading a line of C++ code, which I think is a good thing — part of what makes C++ a high level language. To create a straw man, imagine what it would be like if we had

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-06 Thread Darin Adler
On Jan 6, 2014, at 10:03 AM, Alexey Proskuryakov a...@webkit.org wrote: As auto facilitates search-replace-don't-read refactoring I was talking about refactoring without changing function names. I don’t understand your example. — Darin ___

Re: [webkit-dev] Importing W3C tests for HTML template elements

2014-01-06 Thread Ryosuke Niwa
I don't think we should do this given that the python server has been added to W3C testing harness, and they're gonna convert all existing tests to use that instead: http://lists.w3.org/Archives/Public/public-test-infra/2014JanMar/.html We should simply wait for that effort to take place and

[webkit-dev] Guideline for nullptr

2014-01-06 Thread Darin Adler
I suggest we use nullptr, rather than of 0 or NULL, for all pointer nulls in WebKit C++ sources. I don’t see any advantage to using 0 or NULL over nullptr, and nullptr has multiple advantages. Three obvious ones: Compile time error if accidentally passed to something expecting an integer, can

Re: [webkit-dev] Guideline for nullptr

2014-01-06 Thread Dan Bernstein
Sent from my iPad On Jan 6, 2014, at 11:55 AM, Darin Adler da...@apple.com wrote: I suggest we use nullptr, rather than of 0 or NULL, for all pointer nulls in WebKit C++ sources. I don’t see any advantage to using 0 or NULL over nullptr, and nullptr has multiple advantages. Three

Re: [webkit-dev] Guideline for nullptr

2014-01-06 Thread Anders Carlsson
On Jan 6, 2014, at 12:01 PM, Dan Bernstein m...@apple.com wrote: Sent from my iPad On Jan 6, 2014, at 11:55 AM, Darin Adler da...@apple.com wrote: I suggest we use nullptr, rather than of 0 or NULL, for all pointer nulls in WebKit C++ sources. I don’t see any advantage to using 0 or

Re: [webkit-dev] Importing W3C tests for HTML template elements

2014-01-06 Thread Robin Berjon
On 06/01/2014 20:23 , Ryosuke Niwa wrote: I don't think we should do this given that the python server has been added to W3C testing harness, and they're gonna convert all existing tests to use that instead: http://lists.w3.org/Archives/Public/public-test-infra/2014JanMar/.html We should

[webkit-dev] Apple Mac EWS 10.9 upgrade?

2014-01-06 Thread Lucas Forschler
Happy near year! The Apple Mac EWS bots are currently running 10.8.5. I would like to see if there is any opposition (or support) for upgrading them to 10.9 / Mavericks. Please let me know your thoughts :) Lucas ___ webkit-dev mailing list

Re: [webkit-dev] Apple Mac EWS 10.9 upgrade?

2014-01-06 Thread Myles C. Maxfield
Support here! On Jan 6, 2014, at 12:51 PM, Lucas Forschler lforsch...@apple.com wrote: Happy near year! The Apple Mac EWS bots are currently running 10.8.5. I would like to see if there is any opposition (or support) for upgrading them to 10.9 / Mavericks. Please let me know your

Re: [webkit-dev] Guideline for nullptr

2014-01-06 Thread Ryosuke Niwa
Sounds like a great idea to me. - R. Niwa On Mon, Jan 6, 2014 at 12:04 PM, Anders Carlsson ander...@apple.com wrote: On Jan 6, 2014, at 12:01 PM, Dan Bernstein m...@apple.com wrote: Sent from my iPad On Jan 6, 2014, at 11:55 AM, Darin Adler da...@apple.com wrote: I suggest we

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-06 Thread Geoffrey Garen
Let me try to clarify with two more motivating examples: (1) Nodes.cpp: FunctionParameters::FunctionParameters(ParameterNode* firstParameter, unsigned size) : m_size(size) { unsigned i = 0; for (ParameterNode* parameter = firstParameter; parameter; parameter =

Re: [webkit-dev] Importing W3C tests for HTML template elements

2014-01-06 Thread Dirk Pranke
Ryosuke and I discussed this a bit over IRC. Ryosuke's main concern was that supporting multiple document roots adds a fair amount of complexity to NRWT. Conceptually, it's probably easier to add support to run the W3C's new server (known as wptserve) and then maybe use it for *all* imported tests

Re: [webkit-dev] Apple Mac EWS 10.9 upgrade?

2014-01-06 Thread Alexey Proskuryakov
06 янв. 2014 г., в 12:51, Lucas Forschler lforsch...@apple.com написал(а): The Apple Mac EWS bots are currently running 10.8.5. I would like to see if there is any opposition (or support) for upgrading them to 10.9 / Mavericks. Mavericks bots are substantially less reliable at this point,

Re: [webkit-dev] Guideline for nullptr

2014-01-06 Thread Martin Robinson
On Mon, Jan 6, 2014 at 1:16 PM, Ryosuke Niwa rn...@webkit.org wrote: Sounds like a great idea to me. Seconding this. nullptr also has much better compatibility with varargs than 0. --Martin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-06 Thread Bem Jones-Bey
On Jan 6, 2014, at 13:49 , Geoffrey Garen gga...@apple.commailto:gga...@apple.com wrote: Let me try to clarify with two more motivating examples: (1) Nodes.cpp: FunctionParameters::FunctionParameters(ParameterNode* firstParameter, unsigned size) : m_size(size) { unsigned i = 0;

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-06 Thread Darin Adler
On Jan 6, 2014, at 1:49 PM, Geoffrey Garen gga...@apple.com wrote: auto children = elementChildren(*dummySpanAncestor); for (auto child = children.begin(), end = children.end(); child != end; ++child) { if (isSpanWithoutAttributesOrUnstyledStyleSpan(*child))

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-06 Thread Darin Adler
On Jan 6, 2014, at 1:49 PM, Geoffrey Garen gga...@apple.com wrote: FunctionParameters::FunctionParameters(ParameterNode* firstParameter, unsigned size) : m_size(size) { unsigned i = 0; for (ParameterNode* parameter = firstParameter; parameter; parameter =

Re: [webkit-dev] Apple Mac EWS 10.9 upgrade?

2014-01-06 Thread Ryosuke Niwa
Yeah, I think there is a lot of value in keeping some Mountain Lion coverage now that a lot of people have moved onto Mavericks on their own machines. Ideally, we would like to have EWS for both Mavericks and Mountain Lion though. So perhaps we could move either release or debug bots to

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-06 Thread Maciej Stachowiak
On Jan 6, 2014, at 3:34 PM, Darin Adler da...@apple.com wrote: On Jan 6, 2014, at 1:49 PM, Geoffrey Garen gga...@apple.com wrote: FunctionParameters::FunctionParameters(ParameterNode* firstParameter, unsigned size) : m_size(size) { unsigned i = 0; for (ParameterNode*