Re: [webkit-dev] Enabling visual viewports by default

2017-01-10 Thread David Bokan
Hi Simon, Blink had a problem with mixing viewports between APIs. I've summarized the situation in this doc: https://docs.google.com/document/d/1E6tBwLF1UlqSCMyIIemaRheJrtLncsNetV7y6we-muE/edit?usp=sharing Basically, some APIs (window.scroll_) currently refer to visual while others

Re: [webkit-dev] WebCore/platform standalone library

2017-01-10 Thread Myles C. Maxfield
After 18 months of no progress, Don Olmstead and I are getting the band back together! We’ve uploaded a patch to https://bugs.webkit.org/show_bug.cgi?id=143358 which incorporates feedback from many different stakeholders (and as such, the

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Simon Fraser
> On Jan 10, 2017, at 9:03 PM, Darin Adler wrote: > > This kind of discussion should be on webkit-dev, not webkit-reviewers. While > the reviewers may have more standing to decide about such things, we normally > want to discuss them in the open. Agreed. Moving there. > If

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Darin Adler
> On Jan 10, 2017, at 9:46 PM, Simon Fraser wrote: > > auto countOfThing = getNumberOfThings(); > ASSERT(countOfThing >= 0); // Can’t tell by reading whether the ASSERT is > assured at compile time if countOfThing is unsigned I understand wanting to know, but I am not

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread JF Bastien
> > auto thingLength = getLengthOfThing(); > IntSize size(thingLength, 2); // Can’t tell by reading if thingLength is > LayoutUnit or float and thus truncated here. > The same is true for: int thingLength = getLengthOfThing(); ___ webkit-dev mailing

Re: [webkit-dev] WebCore/platform standalone library

2017-01-10 Thread Darin Adler
> On Jan 10, 2017, at 9:24 PM, Myles C. Maxfield wrote: > > We opted for WebCore to include files using “#include ” instead of > just including Foo.h. Will this work without ForwardingHeaders on macOS and iOS? Given that WTF chose , what is the reasoning for PAL choosing

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Darin Adler
> On Jan 10, 2017, at 9:49 PM, Darin Adler wrote: > >> On Jan 10, 2017, at 9:46 PM, Simon Fraser wrote: >> >> auto countOfThing = getNumberOfThings(); >> ASSERT(countOfThing >= 0); // Can’t tell by reading whether the ASSERT is >> assured at compile

Re: [webkit-dev] WebCore/platform standalone library

2017-01-10 Thread Carlos Garcia Campos
El mar, 10-01-2017 a las 21:24 -0800, Myles C. Maxfield escribió: > After 18 months of no progress, Don Olmstead and I are getting the > band back together! Great news. > We’ve uploaded a patch > to https://bugs.webkit.org/show_bug.cgi?id=143358 which incorporates > feedback from many different

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Alex Christensen
>> I’d love to see examples where using auto substantially hurts readability so >> we could debate them. I once saw a RefPtr changed to auto in some generated code where it was unclear what the return type was. For at least one generated instance the return type was Something* that needed a

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Darin Adler
> On Jan 10, 2017, at 10:17 PM, Filip Pizlo wrote: > > while (Arg src = worklist.pop()) { > HashMap::iterator iter = > mapping.find(src); > if (iter == mapping.end()) { > // With a shift it's possible

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Chris Dumez
I usually like using auto / auto* as much as possible. The one exception where I have found using auto confusing was for functions returning an std::optional. E.g. auto value = maximum(); if (!value) return; I find that the check is confusing because it returns early if value is 0 in the

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Filip Pizlo
Brady asked: > Have you identified any situation where explicitly calling out the type in a > range-based for loop has been better than using the proper form of auto? > Have you identified a situation where explicitly calling out a nasty > templated type, like in my example, added to

[webkit-dev] some problems and wishes

2017-01-10 Thread Oleg Milovidov
Dear Sirs! I built WebKit2Gtk release 14.2 under Linux Mint 18 gcc compiler on 13/11/2016. It works stable! I use the product for embed web C++ application (Gtk-3). I noticed some problems and I have some wishes with the product. 1. Size of downloading resource. It is important for user to