Re: [webkit-dev] WebCore/platform standalone library

> On Jan 11, 2017, at 5:43 PM, Maciej Stachowiak wrote: > > > To be clear, I think PAL is a great move. Details like the namespace, > placement of the code, and how includes look are all things that can be > changed after the fact. > > That said, I think we need to

Re: [webkit-dev] [webkit-reviewers] usage of auto

> On Jan 11, 2017, at 11:15 AM, JF Bastien wrote: > > Would it be helpful to focus on small well-defined cases where auto makes > sense, and progressively grow that list as we see fit? > > > e.g. I think this is great: > auto ptr = std::make_unique(bar); > Proposed rule:

Re: [webkit-dev] [webkit-reviewers] usage of auto

On Jan 10, 2017, at 23:49, Darin Adler wrote: >> On Jan 10, 2017, at 10:17 PM, Filip Pizlo wrote: >> >>while (Arg src = worklist.pop()) { >>HashMap::iterator iter = >> mapping.find(src); >>if (iter

Re: [webkit-dev] [webkit-reviewers] usage of auto

Perhaps we need to be especially careful about replacing Refs and RefPtrs with auto. It was mentioned that using typedefs to hide pointer types is often the source of serious bugs. A similar rule could apply to using auto with smart pointers. On Wed, 2017-01-11 at 09:43 -0800, Darin Adler wrote:

Re: [webkit-dev] WebCore/platform standalone library

These both sound right to me. More generally, I would expect that over time, PAL would likely become a peer project to WebCore instead of being inside it, much the same way WTF started inside JavaScriptCore and eventually moved outside it in the source tree. In the WTF case, it always had a

Re: [webkit-dev] WebCore/platform standalone library

On Tue, 2017-01-10 at 21:28 -0800, Darin Adler wrote: > Given that WTF chose , what is the reasoning for PAL > choosing the all capital ? I kinda prefer myself, in order to parallel WTF. On the one hand, it almost doesn't matter, but on the other it's one more rule to have to memorize which

Re: [webkit-dev] WebCore/platform standalone library

Really happy to see progress on this! On Tue, 2017-01-10 at 21:24 -0800, Myles C. Maxfield wrote: > First of all, this isn’t a new project; instead, it’s a new target > inside the WebCore project. The target creates a static library which > gets linked into WebCore, which means that the

Re: [webkit-dev] [webkit-reviewers] usage of auto

> On Jan 11, 2017, at 9:41 AM, Alexey Proskuryakov wrote: > > In a way, these are read-time assertions. Exactly. A type name is a read-time assertion of the specific type that a variable has and “auto” is a read-time assertion that the type of the variable is the same as the

Re: [webkit-dev] [webkit-reviewers] usage of auto

There are two considerations which make me skeptical that auto is a good thing. 1. There are many smart pointer types in C++, and ignoring pointer types is very error prone. Others have mentioned std::optional, and mistakes being made with RefPtrs. I even saw a case where a review comment that

Re: [webkit-dev] [webkit-reviewers] usage of auto

I'm only arguing for why using auto would be bad in the code snippet that we were talking about. My views regarding auto in other code are not strong. I only object to using auto when it is dropping useful information. -Filip > On Jan 11, 2017, at 9:15 AM, Darin Adler

Re: [webkit-dev] WebCore/platform standalone library

> On Jan 10, 2017, at 11:08 PM, Carlos Garcia Campos > wrote: > >> El mar, 10-01-2017 a las 21:24 -0800, Myles C. Maxfield escribió: >> After 18 months of no progress, Don Olmstead and I are getting the >> band back together! > > Great news. > >> We’ve uploaded a patch

Re: [webkit-dev] WebCore/platform standalone library

On Jan 10, 2017, at 9:28 PM, Darin Adler wrote: >> On Jan 10, 2017, at 9:24 PM, Myles C. Maxfield wrote: >> >> We opted for WebCore to include files using “#include ” instead >> of just including Foo.h. > > Will this work without ForwardingHeaders on

Re: [webkit-dev] [webkit-reviewers] usage of auto

I’m open to auto, but skeptical. (1) Research-ability. I read a lot of code that is new to me, that I have never written. I find type statements to be useful as documentation for where to look for more information about how data structures and algorithms relate to each other. Traversing a tree

Re: [webkit-dev] [webkit-reviewers] usage of auto

11.01.2017, 21:55, "Geoffrey Garen" : > I’m open to auto, but skeptical. > > (1) Research-ability. I read a lot of code that is new to me, that I have > never written. I find type statements to be useful as documentation for where > to look for more information about how data

Re: [webkit-dev] [webkit-reviewers] usage of auto

Would it be helpful to focus on small well-defined cases where auto makes sense, and progressively grow that list as we see fit? e.g. I think this is great: auto ptr = std::make_unique(bar); Proposed rule: if the type is obvious because it's on the line, then auto is good. Similarly: auto i =

Re: [webkit-dev] WebCore/platform standalone library

Why is the PAL namespace inside the WebCore namespace? Couldn't it just be a top-level namespace (even if it currently happens to live in the WebCore project)? #include would be more consistent with existing headers than . antti On Wed, Jan 11, 2017 at 7:24 AM, Myles C. Maxfield

Re: [webkit-dev] WebCore/platform standalone library

I was the one who did the WebCore::PAL namespace so I wanted to chime in on why I went that route. We at Sony are newcomers to pushing to trunk so my explanation might be entirely too idealistic but here goes. I had thought of PAL as a library that is internal to WebCore that provides a clear

Re: [webkit-dev] [webkit-reviewers] usage of auto

OK, you didn’t convince me but I can see that your opinions here are strongly held! — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] WebCore/platform standalone library

To be clear, I think PAL is a great move. Details like the namespace, placement of the code, and how includes look are all things that can be changed after the fact. That said, I think we need to ultimately consider our porting layer to be the combination of PAL and WTF, so it is good for the

Re: [webkit-dev] WebCore/platform standalone library

On Wed, 2017-01-11 at 23:30 +, Olmstead, Don wrote: > I had thought of PAL as a library that is internal to WebCore that > provides a clear porting layer. I would not expect anyone outside of > WebCore to be linking to it. So honestly, I don't think this is very realistic. Lots of stuff