Re: [webkit-dev] WebCore/platform standalone library

2017-01-12 Thread Alex Christensen
If PAL were a shared library in a CMake build, then it wouldn’t build successfully if there were layering violations. I think we should do something like that to enforce good design, even if the Mac Xcode projects treat it as a static library or even just a part of WebCore.

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-12 Thread Xabier Rodríguez Calvar
Hi, O Mér, 11-01-2017 ás 11:15 -0800, JF Bastien escribiu: > e.g. I think this is great: > auto ptr = std::make_unique(bar); > Proposed rule: if the type is obvious because it's on the line, then > auto is good. > Similarly: > auto i = static_cast(j); > auto foo = make_foo(); > auto bar =

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-12 Thread Brady Eidson
My take-away from this discussion so far is that there is actually very little consensus on usage of auto, which means there’s probably very little room for actual style guideline rules. I think there are two very limited rules that are probably not objectionable to anybody. 1 - If you are

Re: [webkit-dev] usage of auto

2017-01-12 Thread Darin Adler
We probably need to step away from mandating style for a while until we have more consensus. I’m sad that we are so far away from that right now. I’ve found greatly increased use of auto during coding and refactoring that I am doing feels like it’s improving clarity quite at bit. From the

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-12 Thread Geoffrey Garen
>> e.g. I think this is great: >> auto ptr = std::make_unique(bar); >> Proposed rule: if the type is obvious because it's on the line, then auto is >> good. >> Similarly: >> auto i = static_cast(j); >> auto foo = make_foo(); >> auto bar = something.get_bar(); // Sometimes, "bar" is obvious. > I'm

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-12 Thread Filip Pizlo
> On Jan 12, 2017, at 08:54, Brady Eidson wrote: > > My take-away from this discussion so far is that there is actually very > little consensus on usage of auto, which means there’s probably very little > room for actual style guideline rules. > > I think there are two

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-12 Thread Konstantin Tokarev
12.01.2017, 19:54, "Brady Eidson" : > My take-away from this discussion so far is that there is actually very > little consensus on usage of auto, which means there’s probably very little > room for actual style guideline rules. > > I think there are two very limited rules

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-12 Thread Konstantin Tokarev
12.01.2017, 19:54, "Brady Eidson" : > My take-away from this discussion so far is that there is actually very > little consensus on usage of auto, which means there’s probably very little > room for actual style guideline rules. > > I think there are two very limited rules

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-12 Thread Geoffrey Garen
>> My take-away from this discussion so far is that there is actually very >> little consensus on usage of auto, which means there’s probably very little >> room for actual style guideline rules. >> >> I think there are two very limited rules that are probably not objectionable >> to anybody.