Re: [webkit-dev] Another WPT bite

2017-05-16 Thread Ben Kelly
On Sat, May 13, 2017 at 8:55 PM, Michael[tm] Smith wrote: > Anne van Kesteren , 2017-05-13 06:20 +0200: > > > > On Fri, May 12, 2017 at 11:49 PM, Maciej Stachowiak > wrote: > > > It seems like there's two unusual things about WPT: > > > - At least

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-16 Thread Michael Catanzaro
On Mon, May 15, 2017 at 11:01 PM, Ryosuke Niwa wrote: Hi all, Youenn is working on a patch to automatically create a GitHub PR to export tests from a WebKit patch which includes changes to web-platform-tests [1]. That raises a question as to where we should put new tests or

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-16 Thread youenn fablet
That is a fair point! For importing tests, effort was done to ease the use of the import-w3c-tests script. Documentation should be in "Tools/Scripts/import-w3c-tests --help" I will be happy to beef it up based on suggestions. y Le mar. 16 mai 2017 à 07:55, Michael Catanzaro

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-16 Thread Konstantin Tokarev
16.05.2017, 17:54, "Michael Catanzaro" : > On Mon, May 15, 2017 at 11:01 PM, Ryosuke Niwa wrote: >>  Hi all, >> >>  Youenn is working on a patch to automatically create a GitHub PR to >>  export tests from a WebKit patch which includes changes to >>  

Re: [webkit-dev] Another WPT bite

2017-05-16 Thread Maciej Stachowiak
> On May 16, 2017, at 1:16 AM, Ryosuke Niwa wrote: > > On Mon, May 15, 2017 at 11:57 PM, Anne van Kesteren wrote: >> On Tue, May 16, 2017 at 7:29 AM, Ryosuke Niwa wrote: >>> Given we're talking about how these tests are ran inside WebKit,

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-16 Thread Maciej Stachowiak
> On May 15, 2017, at 9:08 PM, youenn fablet wrote: > > I see two main cases: > - Writer of the patch is making sure to upstream WPT test changes at WebKit > landing time. It is ok to make the changes directly in > LayoutTests/imported/w3c/web-platform-tests/ > - Writer

Re: [webkit-dev] Another WPT bite

2017-05-16 Thread Anne van Kesteren
On Tue, May 16, 2017 at 7:29 AM, Ryosuke Niwa wrote: > Given we're talking about how these tests are ran inside WebKit, > whether there is an agreement about this or not is sort of irrelevant. > If a test doesn't run as expected, we can run it inside a HTTP server. I was just

Re: [webkit-dev] Another WPT bite

2017-05-16 Thread Ryosuke Niwa
On Mon, May 15, 2017 at 11:57 PM, Anne van Kesteren wrote: > On Tue, May 16, 2017 at 7:29 AM, Ryosuke Niwa wrote: >> Given we're talking about how these tests are ran inside WebKit, >> whether there is an agreement about this or not is sort of irrelevant. >>

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-16 Thread youenn fablet
Le lun. 15 mai 2017 à 23:15, Maciej Stachowiak a écrit : > > On May 15, 2017, at 9:08 PM, youenn fablet wrote: > > I see two main cases: > - Writer of the patch is making sure to upstream WPT test changes at > WebKit landing time. It is ok to make the changes

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-16 Thread Ryosuke Niwa
On Tue, May 16, 2017 at 8:42 AM, Konstantin Tokarev wrote: > > > 16.05.2017, 17:54, "Michael Catanzaro" : >> On Mon, May 15, 2017 at 11:01 PM, Ryosuke Niwa wrote: >>> Hi all, >>> >>> Youenn is working on a patch to automatically

Re: [webkit-dev] Another WPT bite

2017-05-16 Thread Rick Byers
On Tue, May 16, 2017 at 4:54 AM, Maciej Stachowiak wrote: > > > > On May 16, 2017, at 1:16 AM, Ryosuke Niwa wrote: > > > > On Mon, May 15, 2017 at 11:57 PM, Anne van Kesteren > wrote: > >> On Tue, May 16, 2017 at 7:29 AM, Ryosuke Niwa