[webkit-dev] Unified sources have broken our #include hygiene

2018-09-01 Thread Simon Fraser
Unified sources allow you to get away without #including all the files you need in a .cpp file, because some earlier file in the group has probably already included them for you. This means that when you add a new file to the build, and the unified sources get shuffled around, you end up with a

Re: [webkit-dev] Unified sources have broken our #include hygiene

2018-09-01 Thread Tim Horton
> On Sep 1, 2018, at 17:14, Simon Fraser wrote: > > Unified sources allow you to get away without #including all the files you > need in a .cpp file, because some earlier file in the group has probably > already included them for you. > > This means that when you add a new file to the build

Re: [webkit-dev] Unified sources have broken our #include hygiene

2018-09-01 Thread Darin Adler
> On Sep 1, 2018, at 5:14 PM, Simon Fraser wrote: > > Unified sources allow you to get away without #including all the files you > need in a .cpp file, because some earlier file in the group has probably > already included them for you. > > This means that when you add a new file to the build,