Hi all,
This question came up in a code review where I annotated subclass's
destructor with 'override':
class SuperClass {
public:
virtual ~SuperClass() {}
};
class Subclass : public SuperClass {
public:
~Subclass() *override*;
};
The style guide recommends
While I don’t have any opinion about adding override on methods, I would like
to see more `final` annotation in derived classes’ header when the classes are
final and inherits something.
In JSC, we leverage this `final` information in `jsCast<>` and `jsDynamicCast`
to optimize the generated
On Tue, Oct 8, 2019 at 4:24 PM Yury Semikhatsky wrote:
>
> This question came up in a code review where I annotated subclass's
> destructor with 'override':
>
> class SuperClass {
> public:
> virtual ~SuperClass() {}
> };
>
> class Subclass : public SuperClass {
> public:
> ~Subclass()
3 matches
Mail list logo