Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-02 Thread Antti Koivisto
On Fri, Nov 1, 2019 at 10:50 PM Yusuke Suzuki wrote: > > > On Nov 1, 2019, at 11:53, Michael Catanzaro > wrote: > > > > On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote: > >> Namely, some people write a lambda as: > >> auto x = [] () { } > >> with a space between [] and () while others

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Chris Dumez
> On Nov 2, 2019, at 7:38 PM, Ryosuke Niwa wrote: > >  > >> On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto wrote: >> >>> On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa wrote: On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro wrote: >>> On Fri, Nov 1, 2019 at 11:19 am,

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Ryosuke Niwa
On Sat, Nov 2, 2019 at 8:25 PM Ryosuke Niwa wrote: > > On Sat, Nov 2, 2019 at 7:54 PM Chris Dumez wrote: > >> >> >> On Nov 2, 2019, at 7:38 PM, Ryosuke Niwa wrote: >> >>  >> >> On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto wrote: >> >>> >>> On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa wrote:

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-02 Thread Alexey Proskuryakov
My preference is still e-mailing the patch author directly (possibly, also having an option to opt in for anyone). Bugzilla comments will always be irrelevant for most people CC'ed on the bug, and they are almost always undesirable to keep within the discussion flow. - Alexey > 1 нояб. 2019

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-02 Thread Caitlin Potter
Not that anybody asked me, but I also prefer to not include a space between captures and parameter, for similar reasons. If I’m not mistaken, v8/chromium tends to omit the space as well. If that’s still true and WebKit adopted that style, context switching between both codebases would be

[webkit-dev] Wincairo build broken

2019-11-02 Thread Aakash Jain
Hello, Wincairo build seems to be broken. I filed: https://bugs.webkit.org/show_bug.cgi?id=203791 [wincairo] 'deref': is not a member of

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Ryosuke Niwa
On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto wrote: > > On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa wrote: > >> On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro >> wrote: >> >>> On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote: >>> > Namely, some people write a lambda as: >>> > auto x =