Re: [webkit-dev] Step 1 of Plugin removal: Deleting NPAPI (and thus Flash support)

2020-01-13 Thread Carlos Garcia Campos
El lun, 13-01-2020 a las 05:30 +1100, Dean Jackson escribió: > Dear Non-Apple ports, > > Running Flash has been more difficult over the past few years as part > of a (semi-) coordinated effort by browsers and Adobe. The plan is to > remove support for Flash + NPAPI by the end of this year. See

Re: [webkit-dev] Step 1 of Plugin removal: Deleting NPAPI (and thus Flash support)

2020-01-13 Thread Dean Jackson
> On 13 Jan 2020, at 20:14, Carlos Garcia Campos wrote: > > El lun, 13-01-2020 a las 05:30 +1100, Dean Jackson escribió: >> Dear Non-Apple ports, >> >> Running Flash has been more difficult over the past few years as part >> of a (semi-) coordinated effort by browsers and Adobe. The plan is

[webkit-dev] Use of [[maybe_unused]]

2020-01-13 Thread Suzuki, Basuke
Hi WebKit-dev, I'm asking about whether we can use C++ 17's new attribute [[maybe_unused]]. These are situations I cannot solve well with UNUSED_PARAM(). Case 1: The function parameter is only used in RELEASE_LOG macro which is empty in some platform

Re: [webkit-dev] Accidental binary bloating via C/C++ class/struct + Objective-C

2020-01-13 Thread Darin Adler
> On Jan 13, 2020, at 5:52 PM, Yusuke Suzuki wrote: > > We can purge type-encoding-string if we use Objective-C NS_DIRECT feature > (which makes Objective-C function as C function calling convention, removing > metadata). > However, this does not work universally: with NS_DIRECT, Objective-C

Re: [webkit-dev] Accidental binary bloating via C/C++ class/struct + Objective-C

2020-01-13 Thread Yusuke Suzuki
> On Jan 13, 2020, at 19:28, Darin Adler wrote: > >> On Jan 13, 2020, at 5:52 PM, Yusuke Suzuki > > wrote: >> >> We can purge type-encoding-string if we use Objective-C NS_DIRECT feature >> (which makes Objective-C function as C function calling convention, removing

[webkit-dev] Accidental binary bloating via C/C++ class/struct + Objective-C

2020-01-13 Thread Yusuke Suzuki
Hello WebKittens, I recently striped 830KB binary size in WebKit just by using a work-around. This email describes what happened so far, to prevent from happening again. ## Problem When C/C++ struct/class is included in field types and method types in Objective-C, Objective-C compiler puts

Re: [webkit-dev] Accidental binary bloating via C/C++ class/struct + Objective-C

2020-01-13 Thread Joseph Pecoraro
This is a great idea! - Joe > On Jan 13, 2020, at 5:52 PM, Yusuke Suzuki wrote: > > Hello WebKittens, > > I recently striped 830KB binary size in WebKit just by using a work-around. > This email describes what happened so far, to prevent from happening again. > > ## Problem > > When C/C++

Re: [webkit-dev] Accidental binary bloating via C/C++ class/struct + Objective-C

2020-01-13 Thread Filip Pizlo
Wow, that sounds like an awesome find! -Filip > On Jan 13, 2020, at 5:53 PM, Yusuke Suzuki wrote: > > Hello WebKittens, > > I recently striped 830KB binary size in WebKit just by using a work-around. > This email describes what happened so far, to prevent from happening again. > > ##

Re: [webkit-dev] Use of [[maybe_unused]]

2020-01-13 Thread Alex Christensen
> On Jan 13, 2020, at 4:08 PM, Suzuki, Basuke wrote: > > `sessionID` is used in RELEASE_LOG_IF_ALLOWED() and we have empty > implementation of RELEASE_LOG() so that it's ended up with unused parameter > warning of sessionID. We can add UNUSED_PARAM(sessionID) in this case, but >