Re: [webkit-dev] Platform.h vs. makefiles

2020-05-11 Thread Maciej Stachowiak
> On May 10, 2020, at 11:11 PM, Darin Adler wrote: > >> On May 10, 2020, at 10:07 PM, Maciej Stachowiak wrote: >> >> I think the best way to configure WebKit is to use a separate data file, >> neither a header nor a makefile or similar, that defines the options in a >> single place with

Re: [webkit-dev] Platform.h vs. makefiles

2020-05-11 Thread Maciej Stachowiak
I guess it depends on value of this (and feasibility of IDE highlighting based on a generated source file) vs value of having a common approach for compile-time and runtime flags. Runtime flags and their default values likely can’t be effectively expressed in headers. Separate file also lets

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-05-11 Thread Maciej Stachowiak
I noticed from comments in one of the Radars that the patch may result in an additional “fake paint”, so it should probably be performance tested. Have you done any testing? We’ll likely want to A/B some of Apple’s page load speed benchmarks. I’d like to hear from others on maturity of the

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-05-11 Thread Noam Rosenthal
On Tue, May 12, 2020 at 1:36 AM Maciej Stachowiak wrote: > > I noticed from comments in one of the Radars that the patch may result in > an additional “fake paint”, so it should probably be performance tested. > Have you done any testing? > I've tested it locally, I haven't noticed any

Re: [webkit-dev] Platform.h vs. makefiles

2020-05-11 Thread Darin Adler
> On May 10, 2020, at 10:07 PM, Maciej Stachowiak wrote: > > I think the best way to configure WebKit is to use a separate data file, > neither a header nor a makefile or similar, that defines the options in a > single place with clear syntax. Then everything else is generated from that. >

Re: [webkit-dev] PSA: EWS bots aperez-{gtk, wpe}-ews offline for some days

2020-05-11 Thread Adrian Perez de Castro
Hi again, On Sat, 2 May 2020 00:04:37 +0300, Adrian Perez de Castro wrote: > Unfortunately, builders “aperez-gtk-ews” and “aperez-wpe-ews” will be offline > for a few days: it is sitting at the office, where nobody is going these days, > and I cannot get hold of it remotely. Next time I

Re: [webkit-dev] Platform.h vs. makefiles

2020-05-11 Thread Michael Saboff
> On May 10, 2020, at 11:11 PM, Darin Adler wrote: > >> On May 10, 2020, at 10:07 PM, Maciej Stachowiak wrote: >> >> I think the best way to configure WebKit is to use a separate data file, >> neither a header nor a makefile or similar, that defines the options in a >> single place with

Re: [webkit-dev] Platform.h vs. makefiles

2020-05-11 Thread Alexey Proskuryakov
I see substantial appeal in having a separate data file, however I'm not sure if it can inform IDE parsing and syntax highlighting for code enabled/disabled at compile time. Header files seem like they would get that right more often. - Alexey > 10 мая 2020 г., в 10:07 PM, Maciej Stachowiak

[webkit-dev] Suggesting to enable paint timing by default

2020-05-11 Thread Noam Rosenthal
Following the discussion with Simon in https://bugs.webkit.org/show_bug.cgi?id=78011 Since we have a pretty stable spec (https://w3c.github.io/paint-timing/), lots of passing web platform tests, other browser vendor support and a working implementation of first contentful paint, I am planning to