Re: [webkit-dev] New EWS queues for tvOS and watchOS

2020-07-14 Thread Aakash Jain
I just modified watchOS EWS queue to build both arm64_32 and armv7k architectures (in https://bugs.webkit.org/show_bug.cgi?id=214279). Thanks Yusuke for pointing it out. Also, in the process, I figured out that the build for armv7k was in fact broken. Thanks Jonathan for fixing that (in

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-14 Thread Darin Adler
We need to be cautious about adding header includes to other headers. Adding includes to .cpp files is likely fine and not a deeply consequential decision, but adding to headers is something that can have a massive effect on build times over time. > On Jul 13, 2020, at 10:44 PM,

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-14 Thread Said Abou-Hallawa
> On Jul 14, 2020, at 10:40 AM, Darin Adler wrote: > > We need to be cautious about adding header includes to other headers. Adding > includes to .cpp files is likely fine and not a deeply consequential > decision, but adding to headers is something that can have a massive effect > on build

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-14 Thread Simon Fraser
Could someone educate me about ? When should I use this instead of individual wtf headers? Simon > On Jul 14, 2020, at 2:32 PM, Sam Weinig wrote: > > While I don’t want to take away from what Darin is saying here about correct > usage of forward declaration and , I’d like to understand why

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-14 Thread Darin Adler
> On Jul 14, 2020, at 2:38 PM, Simon Fraser wrote: > > Could someone educate me about ? When should I use this > instead of individual wtf headers? Forward.h is analogous to forward-declaring a class ('class IntPoint;' instead of ‘#include “IntPoint.h”'), but it works for many often-used

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-14 Thread Sam Weinig
While I don’t want to take away from what Darin is saying here about correct usage of forward declaration and , I’d like to understand why we have two different compilation models supported in WebKit. Is there a reason both need to be supported? Can we remove one? - Sam > On Jul 14, 2020, at

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-14 Thread Fujii Hironori
On Wed, Jul 15, 2020 at 6:32 AM Sam Weinig wrote: > While I don’t want to take away from what Darin is saying here about > correct usage of forward declaration and , I’d like to > understand why we have two different compilation models supported in > WebKit. Is there a reason both need to be