Re: [webkit-dev] Commit Authorship on GitHub

2020-12-01 Thread Yusuke Suzuki via webkit-dev
Hi Jonathan! > On Dec 1, 2020, at 8:22 AM, Jonathan Bedard via webkit-dev > wrote: > > Hello contributors, > > I am in the process of modifying one of our Git mirrors of the repository for > permanent use. As part of that modification, I am repairing authorship of > historical commits based

Re: [webkit-dev] Commit Authorship on GitHub

2020-12-01 Thread Yusuke Suzuki via webkit-dev
> On Dec 1, 2020, at 11:57 AM, Jonathan Bedard wrote: > > > >> On Dec 1, 2020, at 1:55 PM, Yusuke Suzuki > > wrote: >> >> Hi Jonathan! >> >>> On Dec 1, 2020, at 8:22 AM, Jonathan Bedard via webkit-dev >>> mailto:webkit-dev@lists.webkit.org>> wrote: >>> >>> Hello

Re: [webkit-dev] Commit Authorship on GitHub

2020-12-01 Thread Jonathan Bedard via webkit-dev
> On Dec 1, 2020, at 1:55 PM, Yusuke Suzuki wrote: > > Hi Jonathan! > >> On Dec 1, 2020, at 8:22 AM, Jonathan Bedard via webkit-dev >> mailto:webkit-dev@lists.webkit.org>> wrote: >> >> Hello contributors, >> >> I am in the process of modifying one of our Git mirrors of the repository >>

[webkit-dev] Making WTF::StringImpl and WTF::AtomString thread-safe

2020-12-01 Thread Chris Lord via webkit-dev
Hi all, As part of the work for making FontCache thread-safe, it's necessary for there to be a thread-safe AtomString. After discussion, it seems that a thread-safe StringImpl is generally desirable and GPUProcess also has a need of it. I've filed a bug to track this work:

Re: [webkit-dev] Making WTF::StringImpl and WTF::AtomString thread-safe

2020-12-01 Thread Geoff Garen via webkit-dev
A few thoughts here: 1. It’s not just ref counting. To make String thread-safe, you also need to address all other data members. That means all state in m_hashAndFlags, including the 8bit/16bit state. It appears that your testing strategy did not reveal this point so far; so, you probably

[webkit-dev] Commit Authorship on GitHub

2020-12-01 Thread Jonathan Bedard via webkit-dev
Hello contributors, I am in the process of modifying one of our Git mirrors of the repository for permanent use. As part of that modification, I am repairing authorship of historical commits based on contributors.json. This effort includes our branches and resolving commits attributed to