> On Apr 18, 2022, at 12:51 PM, Michael Catanzaro via webkit-dev
> wrote:
>
> On Mon, Apr 18 2022 at 08:30:04 AM -0700, Jonathan Bedard via webkit-dev
> wrote:
>> 2) We need a way to comment on commit messages in review
>> Current tooling sets the pull request description as the commit
> On Apr 18, 2022, at 5:38 PM, Michael Catanzaro wrote:
>
>
> On Mon, Apr 18 2022 at 02:55:08 PM -0700, Yusuke Suzuki
> wrote:
>> I think this is important. We are using commit message / ChangeLog as a
>> document tied to the change, and we are writing very detailed description to
>> make
On Mon, Apr 18 2022 at 02:55:08 PM -0700, Yusuke Suzuki
wrote:
I think this is important. We are using commit message / ChangeLog as
a document tied to the change, and we are writing very detailed
description to make the intention / design of the change clear and
making it as a good
On Tue, Apr 19, 2022 at 6:55 AM Yusuke Suzuki via webkit-dev <
webkit-dev@lists.webkit.org> wrote:
> I think this is important. We are using commit message / ChangeLog as a
> document tied to the change, and we are writing very detailed description
> to make the intention / design of the change
I think we need both of these things, and I don't think they should be mutually
exclusive. Having motivation/design/details/gotchas go into a "changelog"
accompanying a commit is very useful when blaming code.
- Saam
> On Apr 18, 2022, at 6:49 PM, Fujii Hironori via webkit-dev
> wrote:
>
>
On Mon, Apr 18, 2022 at 18:50 Fujii Hironori via webkit-dev <
webkit-dev@lists.webkit.org> wrote:
>
> On Tue, Apr 19, 2022 at 6:55 AM Yusuke Suzuki via webkit-dev <
> webkit-dev@lists.webkit.org> wrote:
>
>> I think this is important. We are using commit message / ChangeLog as a
>> document tied
On Mon, Apr 18, 2022 at 13:34 Ryosuke Niwa wrote:
>
> On Mon, Apr 18, 2022 at 08:30 Jonathan Bedard via webkit-dev <
> webkit-dev@lists.webkit.org> wrote:
>
>> As we migrate WebKit from Subversion to git, I would like to migrate the
>> project away from ChangeLogs. The reason for this is that
On Mon, Apr 18, 2022 at 8:30 AM Jonathan Bedard via webkit-dev <
webkit-dev@lists.webkit.org> wrote:
> As we migrate WebKit from Subversion to git, I would like to migrate the
> project away from ChangeLogs. The reason for this is that ChangeLogs make
> some of the features of git hard to use,
As we migrate WebKit from Subversion to git, I would like to migrate the
project away from ChangeLogs. The reason for this is that ChangeLogs make some
of the features of git hard to use, namely, cherry-picking commits between
branches requires conflict resolution every time. Rotating
On Mon, Apr 18 2022 at 08:30:04 AM -0700, Jonathan Bedard via
webkit-dev wrote:
2) We need a way to comment on commit messages in review
Current tooling sets the pull request description as the commit
message, “Quote Reply” kind of provides a way to inline comment,
although it’s not the
10 matches
Mail list logo
