Re: [webkit-dev] The mysterious IconDatabase

2007-09-18 Thread Brady Eidson
Hi Patrick, Could you give a little more context? Are you using ToT WebKit? On Sep 18, 2007, at 9:27 AM, Patrick Hanna wrote: Load www.google.com, FrameLoaderClient::dispatchDidReceiveIcon is called. IconDatabase::iconForPageURL returns an icon, this is perfect. Right Load

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-08 Thread Brady Eidson
I think a 100% firm prerequisite is concise, precise, and novice-level instructions on exactly how to use git in the context of WebKit development. As someone who has been living on git for a few weeks, I find many of the conveniences to be great, and it is obviously very powerful. But steep

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Brady Eidson
On Oct 8, 2007, at 11:30 PM, Oliver Hunt wrote: The average user uses update-webkit + some manual work, svn-create- patch, svn-apply-patch Behind the scenes these do, svn up, svn diff + some magic, patch + magic Yup Under git they would be git fetch git rebase origin/master +

Re: [webkit-dev] for review: RefPtr document

2007-10-09 Thread Brady Eidson
I seem to recall reviewing it at the time, but I just went over it once more. I see no technical inaccuracies, I think it's written at a great level for introducing people unfamiliar with the concept to our RefPtr infrastructure, and I don't want to get into arguing tiny ways I would

Re: [webkit-dev] How does WebCore Loader work?

2008-02-20 Thread Brady Eidson
Going into details on how the loader works is quite a tall topic that is more about wiki/tutorial webpages than a post to this mailing list. But to answer your specific question, after FrameLoader calls checkNavigationPolicy() on the FrameLoadClient, the FrameLoadClient is expected to call

Re: [webkit-dev] IconDatabase and dispatchDidReceiveIcon()

2008-04-15 Thread Brady Eidson
The notification is truly about the icon itself being ready, not the URL. And yes, it is dependent on the IconDatabase. Currently, if the IconDatabase is not enabled, we never download site icons. If all you care about is the URL, you can grab it and start downloading the icon anytime

Re: [webkit-dev] Complicated Loaders

2008-07-29 Thread Brady Eidson
The sequence of FrameLoader and DocumentLoader functions is indeed complicated and overloaded. This is slowly being improved over time, little by little. And no, there is no documentation at this time. I'm not sure of the exact motivation for your question, but you did end on a very

Re: [webkit-dev] 9 regression tests failing on the buildbot!

2008-08-12 Thread Brady Eidson
On Aug 12, 2008, at 2:58 PM, Stephanie Lewis wrote: webarchive/archive-empty-frame-source.html Missing archive for about:blank subframe. Started failing after http://trac.webkit.org/changeset/35673 This one didn't fail on my machine before I checked in yesterday, and also was a

Re: [webkit-dev] setTimeout as browser speed throttle

2008-09-30 Thread Brady Eidson
Agreeing with Alexey's points here and adding one more... On Sep 30, 2008, at 9:32 AM, Alexey Proskuryakov wrote: Sep 30, 2008, в 8:13 PM, Mike Belshe написал(а): Thanks - I did see that bug. Intentionally spinning the CPU vis setTimeout(,0) is not a problem if it is what the application

Re: [webkit-dev] Database Storage

2008-10-03 Thread Brady Eidson
To expand on this point, The data you store on your user's system should be your user's data. It should belong to them, and therefore security concerns about what they do with it should be moot. You can, of course, encrypt the data or otherwise obfuscate it before storing it in the

Re: [webkit-dev] Cancel a URL request from a webview

2008-10-11 Thread Brady Eidson
It should work in either case. You say it causes a crash in your original test case... could you file a bug at bugs.webkit.org with more information, including the back trace of the crash? ~Brady On Oct 10, 2008, at 8:59 PM, Bill Patterson wrote: Maybe it would work if it was a

Re: [webkit-dev] retreiving favicon on gtk port

2008-11-25 Thread Brady Eidson
Hi Zaheer, I went ahead and filed https://bugs.webkit.org/show_bug.cgi?id=22489 which represents the radar you referenced. What we saw happening is that you'd get didFinishLoading followed by didFail it's because the SubresourceLoader is getting the main resource of a server-provided 404

Re: [webkit-dev] Setting Unlimited Capacity to BackForwardList

2009-01-19 Thread Brady Eidson
Hi, There is no way to change the *default* capacity for all back forward lists. BackForwardList in WebCore has a method void setCapacity(int); which accomplishes this, but of course your platform's WebKit API layer should also provide a call through to that. On Mac, for example,

Re: [webkit-dev] network resources in webkit

2009-02-18 Thread Brady Eidson
One could go into more detail or be slightly more precise for each of these 4, but yes - pretty much. ~Brady On Feb 17, 2009, at 10:18 PM, abhas saroha wrote: hi all, am i right when i say ResourceHandle class does the communication, ResourceRequest represents requested resource from

Re: [webkit-dev] Issue with Safari and IFrame

2009-03-24 Thread Brady Eidson
Seems like a great reproducible example of a bug, please file it at http://bugs.webkit.org ~Brady On Mar 24, 2009, at 1:48 PM, samyem wrote: I have a test case here: http://www.yomari.net/~samyem/tests/test.html When you click on the button on the iframe, it should be calling the parent

Re: [webkit-dev] HistoryItem, frames, and goBack()

2009-04-03 Thread Brady Eidson
Assuming you're performing the go back by calling Page::goBack(), I'm not sure what else might be tripping up that process. Frame creation is largely tied up within the FrameLoaderClient methods that each platform's WebKit - perhaps WebKitQt is missing some detail of creating these

Re: [webkit-dev] DOM Storage and private browsing

2009-05-20 Thread Brady Eidson
On May 20, 2009, at 1:03 PM, Jeremy Orlow wrote: I'm pretty confused by the policy decisions in DOM Storage with respect to private browsing. Just to be clear, I understand that Safari's private browsing has a different philosophy from Chromium's incognito mode. Right. To re-clarify for

Re: [webkit-dev] content policies

2009-07-06 Thread Brady Eidson
The WebKit API already leaves policy decisions up to it's client. Check out WebPolicyDelegate which allows the client to make decisions for individual resource requests based on the contents of the request, and WebResourceLoadDelegates for the client to make decisions based on the MIME

Re: [webkit-dev] A module that changes webserver configuration?

2009-07-13 Thread Brady Eidson
It seems like you have confused this mailing list with another one. ~Brady On Jul 13, 2009, at 11:10 AM, Elison Smith wrote: Hello, I am looking for pointers to module(s) that change the webserver configuration (in-memory and maybe also in the config files on disk) for any reason. Are

Re: [webkit-dev] willCacheResponse

2009-08-04 Thread Brady Eidson
willCacheResponse was lumped in with dumpResourceLoadCallbacks() solely for convenience based on the situation at the time. As you point out, it is only interesting for embedders of mainline WebKit on Mac. My two proposals are to either split off a new dumpWillCacheResponse() callback or

Re: [webkit-dev] [webkit-changes] [47465] trunk/WebKitTools

2009-08-19 Thread Brady Eidson
On Aug 19, 2009, at 6:34 AM, Adam Roben wrote: On Aug 18, 2009, at 8:00 PM, mr...@apple.com wrote: Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests. Doesn't this create a race condition between the two timers? If a test times out at 15

Re: [webkit-dev] I *HATE* CHANGELOGS!!!

2009-08-26 Thread Brady Eidson
On Aug 26, 2009, at 4:20 PM, Mark Rowe wrote: On 2009-08-26, at 15:43, Maciej Stachowiak wrote: On top of that sometimes the ChangeLog merges cleanly but puts your entry underneath others, and then you have to open the file and move your entry back to the top. Sometimes I have not

Re: [webkit-dev] I *HATE* CHANGELOGS!!!

2009-08-26 Thread Brady Eidson
On Aug 26, 2009, at 6:14 PM, Dmitry Titov wrote: Arguably a text file is the simplest and most reliable way to keep a log over time and across tools and platforms. Things happen to databases (bugzilla!) more often then to plain text files. It seems there are ways to reduce the merging

Re: [webkit-dev] I *HATE* CHANGELOGS!!!

2009-08-28 Thread Brady Eidson
On Aug 28, 2009, at 1:15 PM, David Kilzer wrote: On Friday, August 28, 2009 at 1:05:57 PM, Jeremy Orlow wrote: On Fri, Aug 28, 2009 at 12:26 PM, Brady Eidson wrote: Mark Rowe already pointed out - doing an automated step for each checkin that causes another checkin would be ridiculous

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-09-01 Thread Brady Eidson
On Sep 1, 2009, at 12:59 PM, Adam Roben wrote: 2009-09-01 Adam Roben aro...@apple.com Reviewed by NOBODY (OOPS!) Need a short description of this patch (OOPS!) Need a bug title and URL (OOPS!) What do others think? With the detriment of adding Y.A.O. (yet another

Re: [webkit-dev] Attaching Additional Semantics to Markup

2009-09-16 Thread Brady Eidson
Implementing MathML in the engine has been getting some traction lately: https://bugs.webkit.org/show_bug.cgi?id=28982 https://bugs.webkit.org/show_bug.cgi?id=29158 Would native MathML support along with accessibility roles fulfill your needs? If so, I'd suggest you direct your energies

Re: [webkit-dev] Back/forward cache for pages with unload handlers

2009-09-16 Thread Brady Eidson
? This behavior has not changed. beforeunload events have always been able to stop a navigation before the page cache comes into play. ~Brady -Darin On Wed, Sep 9, 2009 at 4:07 PM, Brady Eidson beid...@apple.com wrote: Since the beginning, WebKit has excluded pages with unload handlers

Re: [webkit-dev] Attaching Additional Semantics to Markup

2009-09-16 Thread Brady Eidson
be worked on that would expose it to *all* screen readers, instead of one designed specifically to be some sort of WebKit add on? ~Brady On Sep 15, 2009, at 11:13 PM, Brady Eidson wrote: Implementing MathML in the engine has been getting some traction lately: https://bugs.webkit.org

Re: [webkit-dev] Back/forward cache for pages with unload handlers

2009-09-16 Thread Brady Eidson
Oliver is correct. The Page Cache will never be able to make *leaving a page* any faster. But it can make *returning* to a page instantaneous. This is a Good Thing™ ~Brady On Sep 16, 2009, at 12:36 PM, Oliver Hunt wrote: This change isn't about making navigating away from a page faster,

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Brady Eidson
On Sep 17, 2009, at 2:28 AM, Maciej Stachowiak wrote: Here's what would need to happen to let loads from unload run to completion: 1) Implement a way to track all entities that start loads during unload (all owners of ResourceHandles, say). 2) Add a way (perhaps via an abstract base

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Brady Eidson
On Sep 17, 2009, at 12:54 PM, Maciej Stachowiak wrote: On Sep 17, 2009, at 12:23 PM, Brady Eidson wrote: On Sep 17, 2009, at 2:28 AM, Maciej Stachowiak wrote: Here's what would need to happen to let loads from unload run to completion: 1) Implement a way to track all entities

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Brady Eidson
On Sep 17, 2009, at 2:17 PM, Ojan Vafai wrote: On Thu, Sep 17, 2009 at 2:11 PM, John Abd-El-Malek j...@google.com wrote: On Thu, Sep 17, 2009 at 2:09 PM, Darin Fisher da...@chromium.org wrote: On Thu, Sep 17, 2009 at 12:52 PM, Maciej Stachowiak m...@apple.com wrote: Based on your comments

[webkit-dev] Coding Style addition - `using namespace` positioning

2009-09-18 Thread Brady Eidson
This morning a fellow engineer asked us what our standard is on where `using namespace` statements should go. I had a strong feeling there was a right answer, but was dismayed to see it wasn't in the coding style guidelines, and also to see how inconsistent we are throughout WebKit. This

Re: [webkit-dev] Coding Style addition - `using namespace` positioning

2009-09-18 Thread Brady Eidson
On Sep 18, 2009, at 12:11 PM, Brady Eidson wrote: ... please let me know if there's any objects or suggested changes to my proposal. s/objects/objections/ ~Brady Thanks, ~Brady ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

Re: [webkit-dev] Point 3 of the WebKit Style Guidelines (indenting code inside namespaces in headers)

2009-09-22 Thread Brady Eidson
I've always hated the indentation in header files. I have no objections. ~Brady On Sep 22, 2009, at 1:06 PM, David Hyatt wrote: I had thought that we resolved ages ago that we would no longer be indenting code inside namespaces in header files, since that just results in the entire class

Re: [webkit-dev] Adding a load type that specifically does not touch session and global history

2009-10-14 Thread Brady Eidson
lockHistory does this. Can you give a specific example of why you think this needs to be a whole new load type? Something that can't be done today? ~Brady On Oct 13, 2009, at 8:48 AM, tonikitoo (Antonio Gomes) wrote: Hi Adam, although the lockHistory naming suggests it to be related to

Re: [webkit-dev] Test coverage for FrameLoader

2009-10-20 Thread Brady Eidson
Absolutely. ~Brady On Oct 20, 2009, at 12:50 PM, Adam Barth wrote: The usual WebKit policy is not to accept functional changes without regression tests. I'd like to ask that this policy be enforced strictly for FrameLoader. For example, I don't think we should be taking changes like this

Re: [webkit-dev] Leopard Release Builder offline

2010-03-09 Thread Brady Eidson
We're having hardware troubles with this machine. It might not *be* back for a bit. I apologize for the negative effect this has on commit-queue users, but it's out of our control at this point. ~Brady On Mar 9, 2010, at 7:27 PM, Eric Seidel wrote:

Re: [webkit-dev] Failing tests blocking commit queue

2010-03-11 Thread Brady Eidson
On Mar 11, 2010, at 2:42 PM, Kenneth Russell wrote: Sorry to complain without going in and just fixing the issue, but it looks like the commit queue has been blocked for roughly 24 hours due to tests failing or timing out. A quick look points to these tests; if you've made changes in these

Re: [webkit-dev] upgrading sqlite library

2010-03-26 Thread Brady Eidson
On Mar 25, 2010, at 5:34 PM, Dumitru Daniliuc wrote: (a HTML5 DB test fails 100% of the time in safari and DRT, but passes 100% of the time in chromium and as a standalone program linked directly to sqlite 3.4.2) What is the bugzilla for this? A test that should pass but fails 100% of

Re: [webkit-dev] [webkit-changes] [56750] trunk

2010-03-29 Thread Brady Eidson
Since two platforms now share this same code in their WebKit layers, it seems okay that this was moved into some shared location. But I have a few gripes: HTTPParsers is about parsing HTTP, not implementing policy. A better place is probably ResourceResponse itself. But as written the method

Re: [webkit-dev] Coming Soon: new-run-webkit-tests

2010-04-09 Thread Brady Eidson
On Apr 9, 2010, at 3:35 PM, Eric Seidel wrote: Thanks to the tireless efforts of Dirk Pranke, Ojan Vafai, and numerous other engineers, WebKit now has a new test harness for running the Layout Tests. ... Cons: - Exposes more flaky tests due to running tests in a non-deterministic order.

Re: [webkit-dev] Coming Soon: new-run-webkit-tests

2010-04-09 Thread Brady Eidson
On Apr 9, 2010, at 4:41 PM, Alexey Proskuryakov wrote: On 09.04.2010, at 16:32, Brady Eidson wrote: - Exposes more flaky tests due to running tests in a non-deterministic order. This sounds like a pro to me. Existing run-webkit-tests can also do that, via a non-default option

Re: [webkit-dev] Support FTS3 in WebSQLDatabases

2010-04-22 Thread Brady Eidson
I'd like to ask some of our SQLite gurus at Apple about this. I recall that they have had (admitedly Apple Internal) concerns about it in the past. Is there a bugzilla for this that I can follow and update? ~Brady On Apr 22, 2010, at 12:15 PM, Dumitru Daniliuc wrote: Hi webkit-dev, I'd

[webkit-dev] Coding style change - Indentation of forward declarations in headers

2010-11-01 Thread Brady Eidson
Currently, the style guidelines specify The contents of an outermost namespace block (and any nested namespaces with the same scope) should not be indented. I like this rule - *most* of the time. A common pattern throughout the project is forward declaring types from different namespaces in

Re: [webkit-dev] Coding style change - Indentation of forward declarations in headers

2010-11-01 Thread Brady Eidson
continued used simply because so much code already uses it. ~Brady dave (hy...@apple.com) On Nov 1, 2010, at 11:49 AM, Peter Kasting wrote: On Mon, Nov 1, 2010 at 9:40 AM, Brady Eidson beid...@apple.com wrote: I think this pattern increases readability of forward declarations

Re: [webkit-dev] Atomic read/write operations and thread safety

2010-12-15 Thread Brady Eidson
On Dec 15, 2010, at 4:28 AM, Steve Block wrote: I have a question about whether WebCore code makes assumptions about the atomicity of certain read/write operations. The particular instance I'm interested in is IconDatabase, where m_threadTerminationRequested is written to from the main

Re: [webkit-dev] Atomic read/write operations and thread safety

2010-12-15 Thread Brady Eidson
On Dec 15, 2010, at 8:47 AM, Brady Eidson wrote: On Dec 15, 2010, at 4:28 AM, Steve Block wrote: I have a question about whether WebCore code makes assumptions about the atomicity of certain read/write operations. The particular instance I'm interested in is IconDatabase, where

Re: [webkit-dev] Atomic read/write operations and thread safety

2010-12-15 Thread Brady Eidson
On Dec 15, 2010, at 11:11 AM, Steve Block wrote: Thanks for the reply Brady. The boolean in question isn't both checked and set at the same time - it's not an acquired resource. One thread sets it, the other checks it. I don't follow. If it's set from one thread and checked from another

Re: [webkit-dev] Platform specific fields on WebCore::HistoryItem

2010-12-21 Thread Brady Eidson
On Dec 21, 2010, at 11:39 AM, Darin Fisher wrote: I'm working on fixing some session history bugs related to a HistoryItem's URL property changing. See for example the call to HistoryItem::setURL in HistoryController::updateForReload [1]. I'm curious about the platform specific fields

Re: [webkit-dev] Platform specific fields on WebCore::HistoryItem

2010-12-21 Thread Brady Eidson
On Dec 21, 2010, at 4:26 PM, Darin Fisher wrote: On Tue, Dec 21, 2010 at 3:59 PM, Darin Fisher da...@chromium.org wrote: On Tue, Dec 21, 2010 at 2:56 PM, Brady Eidson beid...@apple.com wrote: On Dec 21, 2010, at 1:57 PM, Darin Fisher wrote: On Tue, Dec 21, 2010 at 11:49 AM, Darin

Re: [webkit-dev] Page Cache and Plugins

2011-05-05 Thread Brady Eidson
On May 5, 2011, at 00:25 , Basavaraj S.S wrote: Hi, The Scenario : For trial , Introduced Page cache functionality which was disabled on our custom browser on Symbian port. Pages were cached as expected and the Browser stability was decent. To take the a step further, Unlike in

Re: [webkit-dev] Early deletion of DocumentLoader instances

2011-05-25 Thread Brady Eidson
On May 24, 2011, at 09:31 , Darin Adler wrote: On May 24, 2011, at 6:56 AM, Raphael Kubo da Costa wrote: we should fix it by making some better relationship between the Document and DocumentLoader that guarantees we won’t have a dangling pointer. Either reference counting to keep the

Re: [webkit-dev] Early deletion of DocumentLoader instances

2011-05-26 Thread Brady Eidson
On May 25, 2011, at 21:30 , Adam Barth wrote: On Wed, May 25, 2011 at 6:26 PM, Brady Eidson beid...@apple.com wrote: On May 24, 2011, at 09:31 , Darin Adler wrote: On May 24, 2011, at 6:56 AM, Raphael Kubo da Costa wrote: we should fix it by making some better relationship between

[webkit-dev] Source/ThirdParty/ChangeLog? Really???

2011-11-11 Thread Brady Eidson
Bad form! X0,000 announcements have historically always been in WebCore/ChangeLog. A sad and unfortunate break in tradition just to avoid resolving the conflict to land. :( But seriously WebKit, congrats! ~Brady ___ webkit-dev mailing list

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

2012-03-05 Thread Brady Eidson
On Mar 2, 2012, at 3:10 PM, Adam Barth aba...@webkit.org wrote: 2012/3/2 Alexey Proskuryakov a...@webkit.org: It seems that we have some agreement on what to modularize, but not necessarily agreement on what the modularization should encompass. For example, I think that

Re: [webkit-dev] New Feature Flag Proposal: TIME_INPUT_FIELDS

2012-06-27 Thread Brady Eidson
Are there bugs tracking this work yet? Thanks, ~Brady On Jun 26, 2012, at 8:47 PM, Yoshifumi Inoue yo...@google.com wrote: Hi WebKit! I would like to notify adding new feature flag ENABLE_TIME_INPUT_FIELDS. This flag will enable multiple fields input UI for input type time. Looking is

Re: [webkit-dev] Time out issue (30s) of WebKit layout test [Mac OS]

2012-06-29 Thread Brady Eidson
On Jun 28, 2012, at 11:57 PM, Horky Chen ho...@sina.com wrote: Hi, On Mac OS, if one time-out larger than 30s would be used, --time-out-ms cannot work well. According to the run-webkit-tests script, custom Time-Out can be assigned for each test case. But, unfortunately, below line in

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-09 Thread Brady Eidson
On Jul 9, 2012, at 2:43 PM, Alexis Menard alexis.men...@openbossa.org wrote: Hi, For those who secretly use printf debugging :). I know the recommended way is to use a debugger and it's not the point of this discussion. A lot of us do this, and sometimes it's necessary. I agree with the

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-10 Thread Brady Eidson
On Jul 10, 2012, at 5:25 AM, Alexis Menard alexis.men...@openbossa.org wrote: On Mon, Jul 9, 2012 at 6:53 PM, Brady Eidson beid...@apple.com wrote: On Jul 9, 2012, at 2:43 PM, Alexis Menard alexis.men...@openbossa.org wrote: Hi, For those who secretly use printf debugging :). I know

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Brady Eidson
On Jul 19, 2012, at 10:53 AM, Andreas Kling kl...@webkit.org wrote: On Tue, Jul 10, 2012 at 4:52 PM, Brady Eidson beid...@apple.com wrote: On Jul 10, 2012, at 5:25 AM, Alexis Menard alexis.men...@openbossa.org wrote: On Mon, Jul 9, 2012 at 6:53 PM, Brady Eidson beid...@apple.com wrote

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Brady Eidson
On Jul 19, 2012, at 11:01 AM, Oliver Buchtala oliver.bucht...@googlemail.com wrote: On 19.07.2012 19:53, Andreas Kling wrote: On Tue, Jul 10, 2012 at 4:52 PM, Brady Eidson beid...@apple.com wrote: On Jul 10, 2012, at 5:25 AM, Alexis Menard alexis.men...@openbossa.org wrote: On Mon

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Brady Eidson
On Jul 19, 2012, at 2:46 PM, Antti Koivisto akoivi...@gmail.com wrote: Maciej Stachowiak m...@apple.com kirjoitti 20.7.2012 kello 0.27: In principle, we could also have this support multiple arguments, so you could write: debug(frame: , someFrame, node: , someNode, string,

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Brady Eidson
On Jul 19, 2012, at 3:09 PM, Filip Pizlo fpi...@apple.com wrote: On Jul 19, 2012, at 2:58 PM, Balazs Kelemen kbal...@webkit.org wrote: But neither these compile to a single function call. Or we could define simple inline debug() overrides but we could also do that with the stream

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-20 Thread Brady Eidson
On Jul 20, 2012, at 7:53 AM, Shezan Baig shezbaig...@gmail.com wrote: On Fri, Jul 20, 2012 at 7:46 AM, Konstantin Tokarev annu...@yandex.ru wrote: 19.07.2012, 22:20, Filip Pizlo fpi...@apple.com: Now consider the stream form: thingy foo a bar someWeirdNonsenseToEnableHex b baz

Re: [webkit-dev] Do we need a webkitBackground property for XMLHttpRequest?

2012-07-24 Thread Brady Eidson
On Jul 24, 2012, at 2:58 AM, Adam Barth aba...@webkit.org wrote: I don't think we should add this property. Instead we should not ever present HTTP auth dialogs for any requests other than the main resource for the top-level frame. Presenting HTTP auth dialogs in other contexts is a

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-25 Thread Brady Eidson
On Jul 25, 2012, at 8:25 AM, Yong Li yong.li.web...@gmail.com wrote: 2012/7/19 Brady Eidson beid...@apple.com: On Jul 19, 2012, at 10:53 AM, Andreas Kling kl...@webkit.org wrote: On Tue, Jul 10, 2012 at 4:52 PM, Brady Eidson beid...@apple.com wrote: On Jul 10, 2012, at 5:25 AM

Re: [webkit-dev] [123877] trunk/Tools

2012-07-27 Thread Brady Eidson
Why did this get sent to webkit-dev instead of webkit-changes? (Maybe a result of this morning's migration?) ~Brady On Jul 27, 2012, at 9:22 AM, kbal...@webkit.org wrote: Revision 123877 Author kbal...@webkit.org Date 2012-07-27 09:22:06 -0700 (Fri, 27 Jul 2012) Log Message [NRWT]

[webkit-dev] `git svn dcommit` successful, but trac comes up blank?

2012-08-21 Thread Brady Eidson
I just `git svn dcommit`ed to the repository. Git tells me it successfully created 126160. Yet http://trac.webkit.org/ and http://trac.webkit.org/changeset/126160 disagree. Does 126160 actually exist? What piece of the machine is failing us? Thanks, ~Brady

Re: [webkit-dev] `git svn dcommit` successful, but trac comes up blank?

2012-08-21 Thread Brady Eidson
Nevermind, just saw Bill's email from 20 minutes ago. Answered my question. Thanks, ~Brady On Aug 21, 2012, at 9:23 AM, Brady Eidson beid...@apple.com wrote: I just `git svn dcommit`ed to the repository. Git tells me it successfully created 126160. Yet http://trac.webkit.org/ and http

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Sep 26, 2012 at 1:44 PM, Simon Fraser simon.fra...@apple.com wrote: First, direct calls on testRunner that just set preferences should be migrated to internals.settings or testRunner.overridePreference calls, I

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote: [re-sent from the proper address] On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth@nowhere wrote: On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa rn

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
: On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Sep 26, 2012 at 1:44 PM, Simon Fraser simon.fra...@apple.com wrote: First, direct calls on testRunner that just set preferences should

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
On Sep 26, 2012, at 2:46 PM, Tony Chang t...@chromium.org wrote: On Wed, Sep 26, 2012 at 2:35 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote: [re-sent from the proper address] On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 4:15 PM, Simon Fraser simon.fra...@apple.com wrote: On Sep 26, 2012, at 4:13 PM, Brady Eidson beid...@apple.com wrote: This works for any preference; Even a new one that has never been twiddled in a regression test before

[webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
A bit of background: A few of us have been working on enhancing WebKit2's support for multiple WebProcesses. As part of this effort I'm working on https://bugs.webkit.org/show_bug.cgi?id=98537 - Add a NetworkProcess to WebKit2 One benefit of the NetworkProcess will be to have a single shared

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
from various top-tier news sites in different tabs and note just how many resources are shared between them. Thanks, ~Brady Adam On Mon, Oct 8, 2012 at 10:39 AM, Brady Eidson beid...@apple.com wrote: A bit of background: A few of us have been working on enhancing WebKit2's support

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
-jochen On Mon, Oct 8, 2012 at 7:39 PM, Brady Eidson beid...@apple.com wrote: A bit of background: A few of us have been working on enhancing WebKit2's support for multiple WebProcesses. As part of this effort I'm working on https://bugs.webkit.org/show_bug.cgi?id=98537 - Add

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
On Oct 8, 2012, at 11:24 AM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 11:14 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 10:58 AM, Adam Barth aba...@webkit.org wrote: When we looked at whether we should add a shared memory cache to Chromium, we came

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
On Oct 8, 2012, at 12:17 PM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 11:49 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 11:24 AM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 11:14 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012

Re: [webkit-dev] PAN(flick) to left operation collapse screen in Webkit(Safari) on window7 tablet

2012-11-15 Thread Brady Eidson
It sounds like you meant to go to https://bugs.webkit.org/ and file a bug. Thanks, ~Brady On Nov 15, 2012, at 1:13 AM, HIDEKI YOSHIDA yoshida-...@necst.nec.co.jp wrote: Hi, PAN(flick) to left operation collapse screen in Webkit(Safari) on window7 tablet. Version:Safari 5.1.7(7534.57.2)

Re: [webkit-dev] Feature Request: Dynamic Application Cache

2012-11-17 Thread Brady Eidson
On Nov 17, 2012, at 7:47 AM, sridharn sridhar.ndr...@gmail.com wrote: Any updates / plans for this feature ?? What feature? I do agree with Stefan on this .. I've been banging my head on how to cache video files using html 5 storage features and there just doesn't seem to be a

Re: [webkit-dev] Feature Request: Dynamic Application Cache

2012-11-18 Thread Brady Eidson
On Nov 18, 2012, at 10:18 AM, sridharn sridhar.ndr...@gmail.com wrote: Oops! didn't realize that .. I was planning to make the changes myself to webkit (I'm totally new btw) so that at least I can use it in my environment but wanted to understand the current state and/or how to go about in

Re: [webkit-dev] Multiprocess networking in WebKit

2012-12-05 Thread Brady Eidson
On Dec 4, 2012, at 12:36 PM, Allan Sandfeld Jensen k...@carewolf.com wrote: On Tuesday 04 December 2012, Adam Barth wrote: There's been a somewhat fragmented discussion across webkit-dev and various bugs about how we ought to approach multiprocess networking in WebKit. In an attempt to

Re: [webkit-dev] NetworkProcess / NetworkThread in the UIProcess

2013-02-12 Thread Brady Eidson
On Feb 12, 2013, at 12:00 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 12, 2013, at 8:28 AM, Zeno Albisser z...@webkit.org wrote: On Tue, Feb 12, 2013 at 5:01 PM, Balazs Kelemen kbal...@webkit.org wrote: You also need IPC because the NetworkProcess serves the needs of the web

Re: [webkit-dev] Should we create an 8-bit path from the network stack to the parser?

2013-03-07 Thread Brady Eidson
On Thu, Mar 7, 2013 at 2:14 PM, Michael Saboff msab...@apple.com wrote: The various tokenizers / lexers work various ways to handle LChar versus UChar input streams. Most of the other tokenizers are templatized on input character type. In the case of HTML, the tokenizer handles a UChar

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Brady Eidson
On Apr 12, 2013, at 5:05 AM, Jochen Eisinger joc...@chromium.org wrote: Hi, currently, WebKit allows for an arbitrary number of new windows to be created in response to a single user gesture. This is used for example to create pop-unders. In order to restrict the number of new windows

Re: [webkit-dev] FrameLoader::stopAllLoaders and sync XHR

2013-04-22 Thread Brady Eidson
On Apr 22, 2013, at 8:37 AM, Joe Mason jma...@blackberry.com wrote: I'm trying to debug a deadlock on exit in a BlackBerry app that uses webkit (which is pretty hard to reproduce, so I don't have a cut-down test case yet). Right now my suspicions are on this behaviour: a synchronous

Re: [webkit-dev] Safari support for Web Speech API

2013-05-15 Thread Brady Eidson
On May 15, 2013, at 5:09 PM, Randy Brown rbr...@madmobile.com wrote: If a forum dedicated to web-kit development is not the proper place to ask a question about whether anyone has heard of a major vendor's support for a ground-breaking new web-kit spec, exactly where should this be asked?

Re: [webkit-dev] For your consideration: Naming scheme for fooIfExists/ensureFoo

2013-07-01 Thread Brady Eidson
On Jul 1, 2013, at 5:27 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 30, 2013 at 9:39 PM, Filip Pizlo fpi...@apple.com wrote: On Jun 19, 2013, at 9:41 AM, Dan Bernstein m...@apple.com wrote: On Jun 19, 2013, at 7:37 PM, Timothy Hatcher timo...@apple.com wrote: What about?

Re: [webkit-dev] Roadmap for Qt specific implementation for Network Process

2013-07-09 Thread Brady Eidson
On Jul 8, 2013, at 22:13, KwangYul Seo k...@webkit.org wrote: Hi, Currently, only the Mac port uses NetworkProcess, so there is no platform specific code for other backends. I am working on porting NetworkProcess to soup backend for WebKit GTK and EFL ports. The master bug is

Re: [webkit-dev] Notifying PageClient when page transition has begun

2013-07-25 Thread Brady Eidson
On Jul 25, 2013, at 9:08 AM, Thiago Lacerda thiago.lace...@openbossa.org wrote: Hi, We in the Nix port team (which is going upstream), are facing an issue that we need our WebView to know when the page transition has begun. There was callback, in PageClient, that was making a similar

Re: [webkit-dev] Notifying PageClient when page transition has begun

2013-07-25 Thread Brady Eidson
On Jul 25, 2013, at 10:10 AM, Thiago Lacerda thiago.lace...@openbossa.org wrote: Hi Brady On Thu, Jul 25, 2013 at 1:48 PM, Brady Eidson beid...@apple.com wrote: On Jul 25, 2013, at 9:08 AM, Thiago Lacerda thiago.lace...@openbossa.org wrote: Hi, We in the Nix port team (which

Re: [webkit-dev] Proposal: Remove Microdata support

2013-08-05 Thread Brady Eidson
+1. I see no benefit to keeping the code around right now. ~Brady On Aug 5, 2013, at 1:16 PM, Sam Weinig wei...@apple.com wrote: Hello, I’d like to propose removing support for the Microdata JS API (http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html) from

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Brady Eidson
On Aug 21, 2013, at 2:04 PM, Ryosuke Niwa rn...@webkit.org wrote: Separately, I'd like to know whether people liked the new format and it's worth my time making webkitpy adopt the new format. I personally didn't like the old format because it made the first line of each change log too

[webkit-dev] Anybody living in trunk with INDEXED_DATABASE enabled?

2013-09-19 Thread Brady Eidson
Hey all, Is anybody living in trunk with INDEXED_DATABASE enabled? I’m trying to get a gauge for how disruptive I’ll be able to be while hacking on it. Thanks, ~Brady ___ webkit-dev mailing list webkit-dev@lists.webkit.org

[webkit-dev] Heads up for WebKit2 ports using IndexedDB

2013-10-11 Thread Brady Eidson
Hey WK2 folks, https://bugs.webkit.org/show_bug.cgi?id=122675 lays the most basic framework for a WK2, multi-process-aware implementation of Indexed DB. The future of WK2 is multi-process awareness and it makes no sense to continue supporting the default WebCore LevelDB implementation on a

Re: [webkit-dev] The SrcN responsive images proposal

2013-11-07 Thread Brady Eidson
On Nov 7, 2013, at 6:36 PM, Timothy Hatcher timo...@apple.com wrote: On Nov 7, 2013, at 5:43 PM, Tab Atkins Jr. jackalm...@gmail.com wrote: I'm objecting to combining the src-N attributes into a single attribute because that produces a *list of lists*, which is a significant step further

Re: [webkit-dev] Heads up: FALLTHROUGH annotations for switches with fallthroughs

2014-01-26 Thread Brady Eidson
I like this! Out of curiosity, will it be needed for cases like: switch (input) { case 1: // fallthrough? case 2: // Handle both 1 and 2 break; default: // default } Thanks, ~Brady On Jan 26, 2014, at 1:41 AM, Joseph Pecoraro pecor...@apple.com wrote: Hello! I'm slowly

Re: [webkit-dev] Is anyone using the LevelDB backend to IndexedDB?

2014-04-28 Thread Brady Eidson
On Apr 28, 2014, at 5:40 AM, Steven Coul (scoul) sc...@cisco.com wrote: Is there an alternative to levelDB without going to webkit2 ? Not at this time, but apparently EFL is planning to make it work (per Gyuyoung’s email to this thread) Gyuyoung is there a bugzilla for that? Thanks,  Brady

  1   2   >