Re: [webkit-dev] Moving from WTF::Optional to std::optional

2021-06-01 Thread Chris Dumez via webkit-dev
Hi, Another thing Darin didn’t mention but I think people should be careful about: The move constructor for std::optional does not clear the is-set flag (while the one for WTF::Optional did). As a result, you will be having a very bad time if you do a use-after-move of a std::optional. Please

[webkit-dev] Clang Thread Safety Analysis

2021-05-23 Thread Chris Dumez via webkit-dev
Clang Thread Safety Analysis WTF::Lock now supports Clang Thread Safety Analysis . It is a C++ language extension which warns about potential race conditions in code, at compile time. It is the same great Lock, but with some extra help from

Re: [webkit-dev] Clang Thread Safety Analysis

2021-05-30 Thread Chris Dumez via webkit-dev
Hi, Just a quick follow-up to let you know that both CheckedLock/CheckedCondition and UncheckedLock/UncheckedCondition have been removed from the tree. The whole codebase has been ported to Lock/Condition, which have the thread safety analysis annotations. --  Chris Dumez > On May 23,

Re: [webkit-dev] Request for position on self.reportError()

2021-08-27 Thread Chris Dumez via webkit-dev
It doesn’t seem like a controversial feature to me and it is indeed a fairly small amount of work to support. I am working on it via Bug 228316 . --  Chris Dumez > On Aug 27, 2021, at 1:58 PM, Domenic Denicola via webkit-dev > wrote: > >

Re: [webkit-dev] Request for position: Cryptographically secure random UUIDs

2021-08-27 Thread Chris Dumez via webkit-dev
I forgot to follow-up on this email, sorry. Support for this landed via https://bugs.webkit.org/show_bug.cgi?id=229240 . --  Chris Dumez > On Apr 10, 2021, at 7:00 PM, Benjamin Coe via webkit-dev > wrote: > > Hello WebKit folks, > > This

[webkit-dev] Removal of makeRef() / makeRefPtr()

2021-09-22 Thread Chris Dumez via webkit-dev
Hi, With WebKit adopting C++17 a while back, there are no longer any benefits to using makeRef() / makeRefPtr() as far as I can tell. Code that was written like so: auto protectedThis = makeRef(*this); auto protectedPage = makeRefPtr(page); auto result = makeRef(foo->bar()); auto lambda =

Re: [webkit-dev] How to set up Intellisense-ish code completion/suggestions for editing WebKit sources on macOS?

2021-11-11 Thread Chris Dumez via webkit-dev
The code completion is excellent with Qt Creator. You can import the WebKit project like so: New Project > Import existing project > Choose the WebKit folder > click import button Once imported, no need to fiddle with any settings, it just works (after an initial project scan that may take a

Re: [webkit-dev] How to make changes to website?

2022-02-16 Thread Chris Dumez via webkit-dev
Jon Davis is probably the right contact for Webkit.org . --  Chris Dumez > On Feb 16, 2022, at 2:01 PM, Michael Catanzaro via webkit-dev > wrote: > > Hi, > > I want to make a modification to: > > https://webkit.org/contributing-code/ > > Suggested here:

Re: [webkit-dev] ChangeLog Deprecation Plans

2022-04-22 Thread Chris Dumez via webkit-dev
I am strongly in favor of dropping the ChangeLog files and relying on the GIT commit message instead. Not having to update ChangeLog files was actually a big motivator for me to switch to GitHub, as I thought until now we didn’t have to update ChangeLog files when switching Github PRs. With

Re: [webkit-dev] ChangeLog Deprecation Plans

2022-04-22 Thread Chris Dumez via webkit-dev
message a bit easier on GitHub. I support Yusuke’s proposal. It is a bit more flexible and it still means that separate full/history ChangeLog files would be a thing of the past. --  Chris Dumez > On Apr 22, 2022, at 2:10 PM, Chris Dumez via webkit-dev > wrote: > > I am stron

Re: [webkit-dev] Add CODEOWNERS to WebKit

2022-06-02 Thread Chris Dumez via webkit-dev
I’m kind of ambivalent/neutral about this. One question though: When adopting CODEOWNERS, will our existing watchlists get ported, or will each contributor have to modify CODEOWNERS themselves to match whatever was in the watchlists for them? Thanks, Chris. > On Jun 2, 2022, at 1:12 PM,

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

2022-06-02 Thread Chris Dumez via webkit-dev
I am concerned by this proposal given how slow EWS and the merge queue are these days. I think the issue is likely related to failures on the bots and the retries needed to determine if those failures are new. We’ve never had this restriction before. Seems we are becoming overly strict with

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

2022-05-11 Thread Chris Dumez via webkit-dev
> On May 11, 2022, at 11:56 AM, Jonathan Bedard via webkit-dev > wrote: > > Trying to embed previous replies is going to get messy, will be referencing > those replies but not embedding them. > > Unsafe-Merge-Queue should be very fast, I haven’t seen anything take longer > than 10 minutes

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

2022-06-02 Thread Chris Dumez via webkit-dev
> On Jun 2, 2022, at 6:29 PM, Michael Catanzaro wrote: > > > > On Thu, Jun 2 2022 at 04:06:42 PM -0700, Chris Dumez via webkit-dev > wrote: >> I am concerned by this proposal given how slow EWS and the merge queue are >> these days. > > Hopefull

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

2022-05-10 Thread Chris Dumez via webkit-dev
Hi, I think this is a step in the right direction. I hope concerns from other contributors about change log reviews can be addressed in the near future. However, I don’t think it should prevent us from moving away from ChangeLog files, given that commenting on commit logs is still possible in

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

2022-05-10 Thread Chris Dumez via webkit-dev
[Not sure why Apple Mail sent Ryosuke’s replies to the Junk folder but I finally noticed.] > On May 10, 2022, at 3:04 PM, Ryosuke Niwa via webkit-dev > wrote: > > On Tue, May 10, 2022 at 3:01 PM Jonathan Bedard via webkit-dev > wrote: >> >>> On May 10, 2022, at 2:46 PM, Geoffrey Garen

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

2022-05-11 Thread Chris Dumez via webkit-dev
> On May 11, 2022, at 12:13 AM, Ryosuke Niwa via webkit-dev > wrote: > > On Tue, May 10, 2022 at 9:27 PM Ryosuke Niwa wrote: >> >> >> On Tue, May 10, 2022 at 20:36 Chris Dumez wrote: >>> >>> [Not sure why Apple Mail sent Ryosuke’s replies to the Junk folder but I >>> finally noticed.] >>