Re: [webkit-dev] CanvasRenderingContext2D.cpp

2006-12-21 Thread Darin Adler
On Dec 21, 2006, at 7:57 AM, Mike Reed wrote: We're all excited to make canvas work on our port. However, it looks like the portable part of the implementation does not call through to the platform version of GraphicsContext, but it still has #if PLATFORM(CG) around all the good stuff.

[webkit-dev] build.webkit.org

2007-01-10 Thread Darin Adler
The build bot is pretty happy right now. As of 18741. - The Mac OS X release and debug builds are building. - The Linux/Qt build is building. - The Mac OS X release no-SVG build is building. - All jscore and layout tests are passing on the Mac OS X release and debug builds.

Re: [webkit-dev] Differentiating between JS object properties and DOM attributes

2007-03-09 Thread Darin Adler
On Mar 9, 2007, at 4:32 PM, Christian Cantrell wrote: I recently noticed something that surprised me in a new build of WebKit. I found that some dashboard widgets don't run, including some Apple widgets like Stocks. When I investigated, I found that some widgets access custom DOM

Re: [webkit-dev] Syncing javascript keycode's across platforms

2007-03-28 Thread Darin Adler
On Mar 28, 2007, at 3:43 PM, Adam Treat wrote: Currently the keycodes returned by the various platforms under WebKit are nowhere near close to uniform. Seems well worth fixing. This seems like something that should be standard across all platforms that WebKit provides. It is unclear to me

Re: [webkit-dev] notImplemented() macro definitions

2007-04-09 Thread Darin Adler
On Apr 8, 2007, at 3:38 PM, Kevin Ollivier wrote: One other issue I wanted to bring up that I've run into is an issue with needing the notImplementedGdk() macro to be defined even though we're not using the GDK port, as we use the CURL downloader. We've hacked around it in our sources for

Re: [webkit-dev] File System Access in Safari

2007-04-24 Thread Darin Adler
On Apr 24, 2007, at 12:56 PM, Jesse Costello-Good wrote: Does anyone know of a way to read/write to the file system from Safari (from a page loaded from the file: scheme)? This would be equivalent to the IE's FileSystemObject ActiveX object or Firefox's nsILocalFile XP component. We

[webkit-dev] New name for DumpRenderTree tool?

2007-05-07 Thread Darin Adler
I was thinking we should change the tool's name from DumpRenderTree to RunWebKitTest. What do you all think? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposal: reorganization of WebKitTools/Scripts

2007-05-21 Thread Darin Adler
On May 20, 2007, at 12:39 PM, Adam Treat wrote: 1. Add a dir for each port so we'd have Scripts/mac, Scripts/qt, Scripts/gdk for port specific scripts where the common defines and functions would live in the Scripts directory proper. I think very few are port-specific, and I don't want to

Re: [webkit-dev] Adding New Layout Tests

2007-05-23 Thread Darin Adler
On May 22, 2007, at 5:04 PM, Reem Yazigi wrote: I need to add some new Layout tests and everything I found online concerning this issue can be found in the following 2 links: http://webkit.org/quality/testwriting.html http://trac.webkit.org/projects/webkit/wiki/Writing%20Layout%

[webkit-dev] Help making a focus loop test case that works under IE and Gecko?

2007-07-05 Thread Darin Adler
This is a strange place to be asking this, but: Does anyone know how to make JavaScript that advances the currently focused node as hitting the tab key would for IE and for Gecko? Not focusing a particular node, but advancing the focus using the engine's concept of which is the next node

Re: [webkit-dev] Metalink: higher availability and self repairing downloads

2007-07-09 Thread Darin Adler
The best place to put data for a feature request like this would be in a bug of classification Feature at http://bugreport.apple.com. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] WebKit Project Goals

2007-07-24 Thread Darin Adler
On Jul 24, 2007, at 5:04 PM, Maciej Stachowiak wrote: I sent this a while ago with not much comment. Any thoughts? Should I post this on webkit.org somewhere? I think you should! -- Darin ___ webkit-dev mailing list

Re: [webkit-dev] Re: Automated tests (was: WebKit Project Goals)

2007-07-26 Thread Darin Adler
On Jul 26, 2007, at 11:13 AM, Andre-John Mas wrote: What should the requirements for the tool be, other than being freely available? I'm not sure these are requirements, but here are some of the things I'd like to see: - representative of real world performance - one way to

Re: [webkit-dev] type of JSChar

2007-07-27 Thread Darin Adler
On Jul 27, 2007, at 4:03 AM, Alexey Proskuryakov wrote: On 7/27/07 1:51 PM, Simon Hausmann [EMAIL PROTECTED] wrote: Does anybody know/remember why JSChar is defined to wchar_t on Windows and if it is still needed? I think this was/is needed to match ICU's definition of UChar (Define

Re: [webkit-dev] type of JSChar

2007-07-27 Thread Darin Adler
On Jul 27, 2007, at 7:45 AM, Darin Adler wrote: On Jul 27, 2007, at 4:03 AM, Alexey Proskuryakov wrote: On 7/27/07 1:51 PM, Simon Hausmann [EMAIL PROTECTED] wrote: Does anybody know/remember why JSChar is defined to wchar_t on Windows and if it is still needed? I think

Re: [webkit-dev] type of JSChar

2007-07-27 Thread Darin Adler
On Jul 27, 2007, at 11:18 AM, Lars Knoll wrote: I do understand this for your Windows port. In Qt we try to have the same types across all platforms. This is also true for our QChar abstraction that is built on top of an unsigned short. So for us typedef'ing this to wchar_t is as wrong as

Re: [webkit-dev] type of JSChar

2007-07-27 Thread Darin Adler
One last comment that might help. The idea here is that this is a low level API. Lower level than, say, the WebKit API. It's not built on top of the platform APIs like AppKit on Mac OS X. The idea is that it's potentially independent of WebKit. That's a good argument for having it match

Re: [webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-27 Thread Darin Adler
On Jul 27, 2007, at 11:36 AM, Lars Knoll wrote: 2. add a qt/XMLTokenizerQt.cpp and a libxml/XMLTokenizerLibXml.cpp and keep a common XMLTokenizer.cpp for code that is used in both. I like that option best. It's the pattern used in platform for cases like this. -- Darin

Re: [webkit-dev] type of JSChar

2007-07-27 Thread Darin Adler
On Jul 27, 2007, at 11:51 AM, Lars Knoll wrote: Could you explain what you mean by 'good reason'? A JavaScript engine API that isolates clients from implementation details and can be potentially used cross platform is valuable. The files in the API directory represent an attempt to create

Re: [webkit-dev] Determine whether all resources have been successfully loaded

2007-08-04 Thread Darin Adler
On Aug 4, 2007, at 4:36 AM, Plessl Christian wrote: What is the simplest way to check this? Will downloading the nightly webkit build and setting the DYLD_FRAMEWORK_PATH to / Applications/WebKit.app/Contents/Resources/ work? Yes, that should work. -- Darin

Re: [webkit-dev] Threading issues regarding Netscape API plugins in WebKit

2007-09-28 Thread Darin Adler
On Sep 28, 2007, at 10:26 AM, Song Yuan wrote: Does Netscape APIs in WebKit have similar APIs like NPN_PluginThreadAsyncCall (refer to http://developer.mozilla.org/en/docs/NPN_PluginThreadAsyncCall) in Gecko SDK in Mozilla? No. Is this in shipping versions of Firefox? I had the impression

[webkit-dev] for review: RefPtr document

2007-10-09 Thread Darin Adler
Hi folks. Six months ago, I wrote a document about RefPtr http:// webkit.org/coding/RefPtr.html. I haven't yet put a link to it in the website or the wiki. I'd appreciate feedback on the content, especially from people who have contributed patches using RefPtr and PassRefPtr in the past.

Re: [webkit-dev] McAfee VirusScan considers the following files as (Trojan) in window

2007-10-09 Thread Darin Adler
Sorry, I don't understand. Are you asking the folks in the WebKit project to make some kind of change? Why does it matter to our project that VirusScan thinks these files are (Trojan)? -- Darin ___ webkit-dev mailing list

Re: [webkit-dev] CAC Support in AIR?

2007-10-17 Thread Darin Adler
On Oct 17, 2007, at 7:22 AM, Jim Leether wrote: I have been building an AIR application for the US DOD since May and didn’t realize until moving my project up from the development box to the production box that Common Access Cards are not supported. If my research is correct, I see that

Re: [webkit-dev] more build errors...

2007-10-19 Thread Darin Adler
On Oct 19, 2007, at 10:12 AM, Amit Joshi wrote: Thanks adam, It got me beyond that point... But now - I am getting some template redefinition errors.. C:/MinGW/bin/../lib/gcc/mingw32/3.4.2/../../../../include/c++/3.4.2/ bits/locale_ facets.h:4558: error: redefinition of `templateclass

[webkit-dev] please don't add new code using DeprecatedXXX classes, especially in platform specific code

2007-10-28 Thread Darin Adler
Hi folks. I've noticed some new code going in using some of the Deprecated- prefix classes, such as DeprecatedString. While in some cases this could be unavoidable, in general it's a step backwards for the project. We're working as hard as we can to eliminate these classes entirely, and

[webkit-dev] Re: please don't add new code using DeprecatedXXX classes, especially in platform specific code

2007-10-29 Thread Darin Adler
On Oct 29, 2007, at 3:50 PM, Alp Toker wrote: A quick grep suggests that much of the DeprecatedString use both in the core and in the ports stems from KURL offering only DeprecatedStrings in its API. Is this because KURL is somehow deprecated, or is it just a throwback? Rewriting KURL to

Re: [webkit-dev] JavaScriptCore on Leopard?

2007-11-07 Thread Darin Adler
On Nov 7, 2007, at 8:07 PM, Dan Waylonis wrote: I noticed that JavaScriptCore is now in /System/Library/Frameworks instead of being packaged inside of WebKit. I'd like to use JSC as a generic JS engine within an application w/o a WebKit view. I saw the JSPong sample code which is really

Re: [webkit-dev] platform/ reorganization

2007-11-16 Thread Darin Adler
On Nov 16, 2007, at 4:20 AM, Nikolas Zimmermann wrote: platform/bidi: Seems fine to break things down into logical groups. Generally I think a directory is warranted if the number of files is large. It's important to look at who the clients are of these files, in addition to the

Re: [webkit-dev] platform/ reorganization

2007-11-16 Thread Darin Adler
More thoughts on this: CharacterNames could move into a text directory along with String, CString, etc. And CharsetEntry should probably move into a mac subdirectory of the text directory. I'm not sure that Movie.h should be in the graphics subdirectory. Maybe it and Sound could stay

Re: [webkit-dev] Suggestion

2007-11-18 Thread Darin Adler
On Nov 18, 2007, at 11:35 AM, Robert Błaut [EMAIL PROTECTED] wrote: I don't know why WebKit fire onClick event after using middle click or ctrl + click http://bugs.webkit.org/show_bug.cgi?id=15173 ?! Sure, that's a WebKit bug, but the other is not. Since the other is a Safari application

Re: [webkit-dev] platform/ reorganization

2007-11-28 Thread Darin Adler
On Nov 28, 2007, at 1:24 PM, Nikolas Zimmermann wrote: Am 26.11.2007 um 19:18 schrieb Darin Adler: On Nov 16, 2007, at 6:15 PM, David Hyatt wrote: I'd vote for putting all of these files under platform/text (the bidi, font and text files) rather than creating three new subdirectories

Re: [webkit-dev] Printing a WebView in ObjectiveC command-line application fails in OS X 10.5

2007-12-04 Thread Darin Adler
On Dec 4, 2007, at 10:53 AM, Plessl Christian wrote: Does anyone have an idea how to solve this problem? Is this the appropriate mailing list for this question, or would cocoa-dev be more appropriate? I think you have to put the WebView in an NSWindow. The NSWindow probably doesn't have

Re: [webkit-dev] DOMDocument to NSXMLDocument

2007-12-13 Thread Darin Adler
On Dec 13, 2007, at 4:39 PM, Major Domo wrote: Speaking in terms of Objective C, what would be the best way to convert an instance of DOMDocument into an instance of NSXMLDocument? You'll need to serialize to an NSString, then parse it. One way that might work, if you don't care about

Re: [webkit-dev] some WebCore::String plans

2007-12-18 Thread Darin Adler
On Dec 18, 2007, at 10:56 AM, Geoffrey Garen wrote: Would you suggest the same kinds of changes to KJS::UString? Probably not. I think the issues with KJS::UString are different. Long term it would be nice to consider exactly what the differences are between two classes and how to

Re: [webkit-dev] some WebCore::String plans

2007-12-19 Thread Darin Adler
On Dec 19, 2007, at 12:53 PM, Marvin Decker wrote: This sounds good. Are there any plan to replace DeprecatedString with String when this is complete? It would make a big difference. Yes, uses of DeprecatedString should all be removed. But that doesn't need to wait for this plan. Migration

Re: [webkit-dev] some WebCore::String plans

2007-12-20 Thread Darin Adler
On Dec 20, 2007, at 10:23 AM, Marvin Decker wrote: I think this would have to be done incrementally to keep the patches sane. Sure, makes sense. But the total amount of change here isn't so great. Is it okay if code has a bunch of extra DepString-String conversions while this process is

Re: [webkit-dev] Re: [webkit-changes] [29033] trunk

2007-12-31 Thread Darin Adler
On Dec 29, 2007, at 11:20 PM, Alp Toker wrote: The discussion in bug #16669 suggests this was a clean-up to make conditional database support consistent with conditional icon database support. A quick grep shows precedent for this with other features, eg. Frame.cpp: #if ENABLE(SVG)

Re: [webkit-dev] Re: [webkit-changes] [29033] trunk

2007-12-31 Thread Darin Adler
On Dec 31, 2007, at 1:58 PM, Darin Adler wrote: The #if at include sites approach is better for people who want to omit the code entirely for features that are not enabled. You don't even need the headers in your patch. But the #if in headers approach is probably lower maintenance, since

Re: [webkit-dev] Cancel non-terminating JavaScriptCore JSEvaluate()?

2007-12-31 Thread Darin Adler
On Dec 28, 2007, at 2:35 PM, Dan Waylonis wrote: If I send some non-terminating code (e.g., while(1);) to JSEvaluate(), is there a way to have a watchdog thread/timer notice that JSEvaluate() is not terminating (after some amount of time) and cancel the code evaluation? I seem to

[webkit-dev] Re: #if style

2008-01-01 Thread Darin Adler
On Jan 1, 2008, at 12:19 AM, Alp Toker wrote: I have a slight preference for Jan's convention, B: Sure, those arguments make sense; faster builds for people who have a feature disabled. * A doesn't make it clear that DATABASE is optional so it's more likely to lead to build breakage by

Re: [webkit-dev] ACCEPT request header in XMLHttpRequest not meaningful

2008-01-03 Thread Darin Adler
On Jan 3, 2008, at 12:06 PM, Max Barel wrote: As I know no way to guess xhtml capability from javascript Alexey addressed the rest of this question quite well. But I'm also wondering if the above is true. I'd expec that either using hasFeature or createDocument on DOMImplementation would

Re: [webkit-dev] Re: QWebNetworkManager triggering a memleak in Qt

2008-01-04 Thread Darin Adler
On Jan 4, 2008, at 1:40 AM, Simon Hausmann wrote: I don't believe that is a bug in Qt, I believe this leak is due to the fact that the QWebNetworkManager instance (s_manager) is never deleted, and as a result the connection is never broken up, so valgrind correctly claims a leak :) That

[webkit-dev] Who's working on merging GNUmakefile.am and DerivedSources.make?

2008-01-04 Thread Darin Adler
Right now big pieces of GNUmakefile.am are copies of DerivedSources.make. And over time they are starting to diverge, creating an unnecessary maintenance problem. The reason we're using make for derived sources is so we can share those rules among all the different build systems. Who's

Re: [webkit-dev] Two suggested minor fixes for the WebKit Coding Style Guidelines

2008-01-04 Thread Darin Adler
On Jan 4, 2008, at 12:55 PM, Anyang Ren wrote: I'd like to suggest two minor fixes for the WebKit Coding Style Guidelines at http://webkit.org/coding/coding-style.html. 1. I believe CamelCase and InterCaps mean the same thing. If so, I suggest that we use one of them consistently

[webkit-dev] regular expression notes (mostly about performance optimization)

2008-01-05 Thread Darin Adler
I've been spending some time recently on our JavaScript regular expression code. For background, our regular expression code is a much-modified fork of PCRE 6.5. When I talk about latest PCRE here, I'm talking about PCRE version 7.4. Here are a few notes I thought others might find

Re: [webkit-dev] custom containers advantage over stl containers

2008-01-07 Thread Darin Adler
On Jan 7, 2008, at 1:04 PM, Jakob Praher wrote: just out of curiosity, I would like to ask why you decided to implement your own containter structures, like Vector or HashTable/ Map/Set ... What was your driving force? We didn't make a blanket decision to implement our own container

Re: [webkit-dev] JavaScriptCore constructor callback and class questions

2008-01-09 Thread Darin Adler
On Jan 8, 2008, at 8:24 PM, Dan Waylonis wrote: Can any information (e.g., name or JSClassRef) about the class being constructed be extracted from the constructor argument? I don't get any enumerable properties from it. I did noticed that the memory address of the constructor argument is

[webkit-dev] Re: regular expression notes (mostly about performance optimization)

2008-01-14 Thread Darin Adler
On Jan 5, 2008, at 6:27 PM, Darin Adler wrote: The regexp-dna expressions all could be translated from brackets into character classes. - They have the form: /a|b/ where a and b are expressions solely containing letters and character classes of the same length. - They could be converted

Re: [webkit-dev] Safari not connecting to IPv6 server with numeric address

2008-01-18 Thread Darin Adler
On Jan 18, 2008, at 8:18 PM, Andre-John Mas wrote: If I try connecting to my web server, on my local network, which is running Apache 2 with IPv6, the following fails: http://[fe80::230:65ff:fed6:b164%en0]/ Yet at the same time, from the command line: telnet -6 fe80::230:65ff:fed6:b164%en0

Re: [webkit-dev] Abstracting the canvas

2008-01-23 Thread Darin Adler
On Jan 23, 2008, at 3:25 AM, Alp Toker wrote: Oliver has proposed the first move in abstracting WebKit's canvas implementation as part of his putImageData patch: http://bugs.webkit.org/show_bug.cgi?id=16954 The strategy involves splitting functions out into CanvasRenderingContext2DCG,

Re: [webkit-dev] troubleshooting javascript that only fails in Safari

2008-02-11 Thread Darin Adler
On Feb 11, 2008, at 10:27 AM, Nicholas Blair wrote: I'm a new member to this list; I've come by recommendation of a co- worker. I may have stumbled into a bug in Safari, but I'm not sure where to turn. Can I post my problem here? Or is there a better place to go? This web page talks about

Re: [webkit-dev] maintenance to do list

2008-02-13 Thread Darin Adler
On Feb 13, 2008, at 10:31 AM, Chris Brichford wrote: I'd suggest that ref/deref classes start out with a 0 ref count, but all their constructor and destructors should protected or private. The concrete classes that should be constructable should then have a static method that calls the

Re: [webkit-dev] window.status setting is disabled in recent nightly builds

2008-02-13 Thread Darin Adler
On Feb 13, 2008, at 12:22 PM, Max Barel wrote: Recently, we lost the ability to set window.status. I see nothing about this in Trac nor this list. I do not use it in production site but i like it for debugging (drosera slows things to much). Is there a hidden setting to get this feature

Re: [webkit-dev] Authentication dialog

2008-02-17 Thread Darin Adler
On Feb 17, 2008, at 8:06 AM, Bill Patterson wrote: I've tried didReceiveAuthenticationChallenge delegates, but this hasn't worked in every case, especially on Leopard. The above- mentioned dialogs work for me every time. Safari uses this delegate to put up authentication sheets for HTTP

Re: [webkit-dev] Rounded border rendering

2008-02-21 Thread Darin Adler
On Feb 21, 2008, at 1:41 AM, Fabian Jakobs wrote: BTW the documentation for border-radius at http://developer.apple.com/documentation/AppleApplications/Reference/SafariCSSRef/Articles/StandardCSSProperties.html#//apple_ref/doc/uid/TP30001266-BoxModel is incomplete. It does not mention

Re: [webkit-dev] Frame and FrameView references

2008-02-29 Thread Darin Adler
On Feb 29, 2008, at 4:25 AM, Artem Ananiev wrote: setView(0); ... if (d-m_view) { d-m_view-hide(); d-m_view-clearFrame(); } Good catch. This is all dead code and should be replaced with an assertion: ASSERT(!d-m_view); How this situation is

[webkit-dev] buildbot problems

2008-03-12 Thread Darin Adler
Hi folks. The WebKit project public buildbots are displaying quite a few problems right now: http://bugs.webkit.org/show_bug.cgi?id=17793: WinLauncher build failing on the buildbots (Visual Studio Express issue) http://bugs.webkit.org/show_bug.cgi?id=17794: REGRESSION (r30980): 23 tests

Re: [webkit-dev] FrameLoaderClient notifications

2008-03-13 Thread Darin Adler
On Mar 13, 2008, at 4:11 AM, Artem Ananiev wrote: I work on dispatching web load/progress events for Java port and have some questions about notifications in FrameLoaderClient class. 1. What is the right method to implement to get a 'page load started' and 'page load finished' events? I

Re: [webkit-dev] buildbot problems

2008-03-17 Thread Darin Adler
On Mar 17, 2008, at 10:21 PM, Srinivas Rao M Hamse wrote: I see the recent builds are still breaking, is it the buildbot issue or is the its a genuine bug ? To me this looks like a genuine bug. -- Darin ___ webkit-dev mailing list

Re: [webkit-dev] The thisObject parameter for JSEvaluateScript

2008-03-24 Thread Darin Adler
On Mar 24, 2008, at 11:40 AM, Scott Thompson wrote: I'm using JavaScript core to integrate JavaScript as an embedded scripting engine in my application. I've gotten a lot of stuff working (which is a lot of fun, BTW). I've been able to run scripts and see them manipulate objects in my

Re: [webkit-dev] extending webkit

2008-03-24 Thread Darin Adler
On Mar 19, 2008, at 10:50 PM, wang gang wrote: Is there a way to extend webkit so as to enable the browser or widgets (like the ones on Mac) to access the native functionalities of the machine? Sure, if you're developing the program using WebKit. The JavaScriptCore API can be used to

[webkit-dev] tests hanging on the Mac Tiger buildbot

2008-03-25 Thread Darin Adler
If you look at the buildbot, currently these tests are hanging: editing/pasteboard/4700297.html editing/pasteboard/5006779.html http://build.webkit.org/results/trunk-mac-ppc-release/11676/results.html Does anyone know why or when this started? -- Darin

Re: [webkit-dev] Safari/WebKit support in Bindows

2008-03-26 Thread Darin Adler
On Mar 26, 2008, at 4:50 AM, Johan Lund wrote: my name is Johan Lund and I am in charge of implementing Safari/ WebKit support in the Bindows AJAX framework. We currently have a working version of Bindows in Safari but one key element is missing which is issue #7138. Is this issue

Re: [webkit-dev] No more javascript parsing errors in console

2008-03-28 Thread Darin Adler
On Mar 28, 2008, at 9:36 AM, David Kilzer wrote: Adam Roben [EMAIL PROTECTED] wrote: David Kilzer wrote: This works for me with Safari 3.1 on Mac OS X 10.5.2. (I used http://www.dmregister.com/ to test.) I think the trick is that you must have the Web Inspector open before you load

Re: [webkit-dev] Questions on WebCore compoments

2008-04-02 Thread Darin Adler
On Apr 2, 2008, at 3:09 AM, 손석배[단말개발담당] wrote: - bindings: Is it for language conversion (like C++ - javascript, C ++ - Objective C? then, what is script folder for?) Yes, it's for JavaScript and other language bindings to the DOM, which is implemented in C++. There is no script folder. -

Re: [webkit-dev] Plugin Questions

2008-04-14 Thread Darin Adler
On Apr 9, 2008, at 11:19 PM, SON SEOK BAE wrote: If I want to show contents (for example, Flash animations) with WebKit port, what kind of flash player plugings should I install for webkit? I mean, will it be Flash player for Safari or Flash player for Firefox or something else? And are

Re: [webkit-dev] Regarding HashSet

2008-04-14 Thread Darin Adler
On Apr 9, 2008, at 4:01 AM, priyanka gupta wrote: I am new to Webkit, but in our project we are using Webkit 3.0 drop for application development. Is there any documentation available for proper usage of Hashset template and its member functions?? Sorry, there is not. I've been thinking

Re: [webkit-dev] Plugins again :-)

2008-04-17 Thread Darin Adler
On Apr 17, 2008, at 8:40 AM, R Bassett wrote: I've got a directfb / gtk / webkit software stack cross-compiled and running nicely on my platform. I'd like to add a plugin however I'm failing to find a simple example that I can start with. I got hold of the simple NetscapeMoviePlugIn from

Re: [webkit-dev] Async IconDatabase and reading icons from disk on startup

2008-05-11 Thread Darin Adler
On May 11, 2008, at 5:08 PM, Adam Treat wrote: It would seem that a client application should call iconDatabase()- iconForPageURL() when it needs to display a particular icon on startup. However, the way IconDatabase is written it appears that the client application would need to call this

Re: [webkit-dev] Async IconDatabase and reading icons from disk on startup

2008-05-11 Thread Darin Adler
On May 11, 2008, at 6:44 PM, Adam Treat wrote: How is it actually read from disk then? Looking at the code... the only time it is actually read from disk is in IconDatabase::readFromDatabase and even then it only reads in icons that are flagged in m_iconsPendingReading. And when grepping

Re: [webkit-dev] tabIndex

2008-05-23 Thread Darin Adler
On May 23, 2008, at 2:32 AM, Johan Lund wrote: Another question, related but regarding tabIndex. Does Safari treat a tabIndex of -1, 0 or 1... differently? I believe it is treated differently on some browsers. 1... component can be focused both by pressing tab and programatically 0

Re: [webkit-dev] Safari won't run for me.

2008-05-25 Thread Darin Adler
On May 25, 2008, at 11:10 AM, Paul Pedriana wrote: Safari is not installed. Is that I requirement? Yes, Safari has to be installed if you want to run Safari. As described on http://webkit.org/building/run.html. The answer to your question is right there in the subject of your email message!

Re: [webkit-dev] WebKit memory management?

2008-06-04 Thread Darin Adler
On Jun 3, 2008, at 7:58 PM, Paul Pedriana wrote: The application should be able to set aside a block of RAM and have the library use that block of RAM via a user-supplied memory allocator. At no time should the library attempt to use any other memory nor use its own means to access the

Re: [webkit-dev] WebKit memory management?

2008-06-04 Thread Darin Adler
On Jun 4, 2008, at 10:57 AM, Paul Pedriana wrote: As I mentioned in a previous response, this unfortunately doesn't work because all operator new is directed to FastMalloc, not just WebKit's usage of operator new. Operator new is global in a linkage unit. Did you try it, or is that

Re: [webkit-dev] WebKit memory management?

2008-06-04 Thread Darin Adler
On Jun 4, 2008, at 11:38 AM, Paul Pedriana wrote: I can understand that some developers who have spent a lot of time developing monolithic desktop or server software are used to using the built-in global operator new. The concept of controlling memory like I am proposing is the rule in

Re: [webkit-dev] WinLauncher crash on Windows XP

2008-06-12 Thread Darin Adler
On Jun 12, 2008, at 2:37 PM, [EMAIL PROTECTED] wrote: Has anybody experienced the same problem? Most people who use WinLauncher use a different networking back end; the curl one rather than CFNetwork. So I don't think there are others using the same configuration you are. -- Darin

[webkit-dev] renaming some things in JavaScriptCore

2008-06-13 Thread Darin Adler
I have some suggested name changes for JavaScriptCore code. I'll do these with the do-webcore-rename script. Use JS prefix and simpler names for basic types, to complement JSValue and JSObject. GetterSetterImp = JSGetterSetter, NumberImp = JSNumberCell, StringImp = JSString,

[webkit-dev] renaming some WebCore, too

2008-06-13 Thread Darin Adler
As with the JavaScriptCore renames, I have some WebCore renames I'd like to do. Take the K out of KURL. KURL = URL, KURLCFNet = URLCF, KURLMac = URLMac, KURL_H_ = URL_h, Use a less confusing name for the base class for all form controls. It's hard to understand how

Re: [webkit-dev] renaming some things in JavaScriptCore

2008-06-14 Thread Darin Adler
On Jun 13, 2008, at 3:51 PM, Geoffrey Garen wrote: Cut down on confusing uses of Object and Imp. Should we add the JS prefix to these, too? I'm not sure. If we want to add a JS prefix to all these names, then there'd be even more names to change because I left some closely related names

Re: [webkit-dev] renaming some things in JavaScriptCore

2008-06-14 Thread Darin Adler
On Jun 14, 2008, at 10:36 PM, Maciej Stachowiak wrote: I would prefer if we keep a JS prefix only on the objects that seem like very generic names otherwise. Makes sense. Given that rule of thumb, what do you think of these: GetterSetterImp = JSGetterSetter, NumberImp =

Re: [webkit-dev] renaming some things in JavaScriptCore

2008-06-16 Thread Darin Adler
I completed all the renaming mentioned in my original message today. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] renaming some WebCore, too

2008-06-16 Thread Darin Adler
On Jun 13, 2008, at 4:26 PM, Darin Adler wrote: As with the JavaScriptCore renames, I have some WebCore renames I'd like to do. I completed most of the renaming mentioned here, with four exceptions: Take the K out of KURL. I haven't done this one yet. Maciej slightly prefers ParsedURL

Re: [webkit-dev] DOM tree surgery and DOM tree destruction

2008-06-25 Thread Darin Adler
On Jun 25, 2008, at 10:06 AM, Pitaga wrote: For example, suppose that a browser based on WebKit has loaded a Web page and parsed it, producing a DOM tree T. As an exercise, I want to perform surgery on T and then destroy both T and the constituents that the surgery removed from T,

Re: [webkit-dev] renaming ASSERT macro

2008-06-26 Thread Darin Adler
On Jun 26, 2008, at 5:16 AM, Jörg Bornemann wrote: That means ATM that I have to make sure to always include windows.h _before_ Assertion.h. Then lets add this to Assertion.h: #if PLATFORM(WINCE) // or whatever is the right if #include windows.h #endif I'd prefer this to a

Re: [webkit-dev] renaming ASSERT macro

2008-06-27 Thread Darin Adler
On Jun 27, 2008, at 1:50 AM, Jörg Bornemann wrote: Well, this is a small change but also a very bad idea. Not because of compilation time, but because of the crappy Windows headers which define *a* *lot* of global stuff. E.g. the XSLT parser of WebKit won't build because there's a #define

Re: [webkit-dev] renaming ASSERT macro

2008-07-01 Thread Darin Adler
On Jul 1, 2008, at 1:45 AM, Jörg Bornemann wrote: This solution is easy to do, leads to the smallest source diff but is a very dirty hack, which will lead to problems on WinCE, because we will include windows.h in public headers. Adding windows.h to Assertions.h will not cause it to be

Re: [webkit-dev] renaming ASSERT macro

2008-07-01 Thread Darin Adler
On Jul 1, 2008, at 10:39 AM, Paul Pedriana wrote: On a related note, I would like to propose (possibly in a separate email) that the CRASH macro in Assertions.h that ASSERT uses be augmented to the following for improved debugging and portability across most platforms: That sounds like

Re: [webkit-dev] Where's the Xcode project file for WebKit?

2008-07-01 Thread Darin Adler
On Jul 1, 2008, at 3:29 PM, Conrad Taylor wrote: Hi, could someone tell me what's the name of the main Xcode project file for WebKit? Each of the projects has a separate project file. There's no overall one for the entire project. That's one of the reasons the build-webkit script exists.

Re: [webkit-dev] memory consumption

2008-07-02 Thread Darin Adler
On Jul 2, 2008, at 7:19 AM, Akos Kiss wrote: I'd like to ask you whether the memory consumption of the JS engine is of importance for you or does performance have higher priority? Memory consumption is quite important. we found in the newest version of the RegisterFile that it's memory

Re: [webkit-dev] r35040 -- issue with gtk

2008-07-10 Thread Darin Adler
On Jul 10, 2008, at 9:58 AM, Refstrup, Jacob Grundtvig wrote: With your recent change (r35040) to KURL.cpp in setRef() (line 708) testing for isNull() rather than isEmpty() caused a problem on GTK where called setRef() which ends up being not being null (but would have been empty). This

Re: [webkit-dev] Canvas 3D support in Webkit

2008-07-10 Thread Darin Adler
On Jul 7, 2008, at 9:52 PM, cem tozkoparan wrote: I was wondering if there is(or will be) support for Canvas 3D in WebKit similar to Opera and Mozilla. I don't think anyone has started work on this yet, but it seems like a good idea. It'd be great to match cross-browser rather than just

Re: [webkit-dev] Faster run-webkit-tests?

2008-07-10 Thread Darin Adler
On Jul 10, 2008, at 5:11 PM, Refstrup, Jacob Grundtvig wrote: Has anyone looked into making run-webkit-tests run faster by taking advantage of multiple CPUs? E.g. my workstation is 8gb, with 2 x dual core and I think it'd do just fine in running 4-8 tests simultaneously. If there's no

Re: [webkit-dev] WebView Background Color in WebKit Control

2008-07-28 Thread Darin Adler
On Jul 19, 2008, at 7:13 AM, Bruce Cresanta wrote: I am writing an application using WebView that uses the [[WebView mainFrame] loadRequest:req] method. The problem is that my background is dark and the view flashes the color White upon adding it as a subview of a view. You might want

Re: [webkit-dev] How to determine the could cut status ?

2008-08-06 Thread Darin Adler
On Aug 5, 2008, at 7:46 PM, Andy wrote: Is there any API method I could use ? There's no platform-independent WebKit API, so this is a platform- specific question. In the Mac OS X API, the way you determine this is by checking to see if the cut: command is enabled using the

Re: [webkit-dev] IDL and JavaScript bindings .. ?

2008-08-07 Thread Darin Adler
On Aug 7, 2008, at 8:49 AM, Javed Rabbani wrote: Why is there any need to generate JavaScript bindings via IDL files using Perl scripts. What I want to say is why these binding files are not part of the source? There are at least two different answers to your question: 1) Using IDL

[webkit-dev] 9 regression tests failing on the buildbot!

2008-08-12 Thread Darin Adler
Does anyone know why these tests are failing on Mac OS X? I presume these are recent regressions. There are even more failing on Windows and other platforms fast/dom/cssTarget-crash.html Due to a change to handling of anchors in URLs perhaps? fast/dom/defaultView.html Dumping

Re: [webkit-dev] how do you do callbacks out of webkit into c++, objC or other bindings - e.g. onclick ?

2008-08-30 Thread Darin Adler
On Aug 30, 2008, at 5:35 PM, Luke Kenneth Casson Leighton wrote: in javascript, you can set an element's onclick method. how the heck do i get a callback, into c++, objc or any other binding, from an onclick? is there a mechanism for calling back, from javascript, into the bindings?

Re: [webkit-dev] how do you do callbacks out of webkit into c++, objC or other bindings - e.g. onclick ?

2008-08-30 Thread Darin Adler
On Aug 30, 2008, at 7:00 PM, Darin Adler wrote: The clickListener object must be a class that implements the DOMEventListener protocol. What I meant to say was: The clickListener object must be an object of a class that conforms to the DOMEventListener protocol. -- Darin

Re: [webkit-dev] FrameLoaderClient misses NewWindowAction policy check

2008-09-05 Thread Darin Adler
On Sep 3, 2008, at 4:56 AM, Anton V. Tarasov wrote: The method FrameLoader::continueAfterNavigationPolicy (the first stack) calls m_client-canHandleRequest(request) in its turn in order to request an approval from the client. Yes, there is a client function named canHandleRequest, but

  1   2   3   4   5   6   7   8   9   10   >