Re: [webkit-dev] Potential performance/responsiveness problem with timers

2007-01-11 Thread David Hyatt
My understanding of the Mozilla system is that it has real trouble firing timers at the correct times because of the additional processing delays you described. I think our current model is sound (given that we have to process these timers on the main thread anyway, so they all wait on one

Re: [webkit-dev] Text selection bug: text disappearing (WINDOWS)

2007-01-16 Thread David Hyatt
It is indeed a Cairo bug. We should maybe try syncing up to a later version to see if it has been fixed. dave On Jan 16, 2007, at 2:09 PM, Ionut Durbaca wrote: Hello, I encountered the following problem with WebKit rendering (WINDOWS only): When selecting text in HTML documents -

Re: [webkit-dev] Open Design beyond Open Source

2007-02-16 Thread David Hyatt
I think this is a constructive email, George. Thanks for writing it. Specific responses below. On Feb 16, 2007, at 10:29 PM, George Staikos wrote: We made some great progress but it's an absolutely ridiculous development model as far as getting real work done. So far we had: 1) Work

Re: [webkit-dev] HTML4 and CSS2 table column styling

2007-03-02 Thread David Hyatt
On Mar 2, 2007, at 2:06 PM, Rob Burns wrote: I started to post a reaply on this bug on HTML/CSS column issues, when it grew to more listserv length post. So here it is. I would suggest posting this to the bug. We usually like to track discussions regarding specific bug fixes in the bug

Re: [webkit-dev] Adobe Apollo's port of WebKit

2007-03-21 Thread David Hyatt
Here's my opinion. Others may disagree. :) On Mar 21, 2007, at 2:34 PM, Chris Brichford wrote: * What to call our sub-directory in WebCore/platform I think apollo is appropriate. While I know it is just a code name, it's very recognizable/familiar to people at this point. * Should

Re: [webkit-dev] Bit fields cause Purify to report UMRs

2007-05-02 Thread David Hyatt
This seems like a pretty sad technical limitation of Purify. On May 2, 2007, at 5:31 PM, Anyang Ren wrote: There are so many UMRs that I am forced to ignroe all UMRs. This is bad. I am wondering if you'd consider not using bit fields so that these UMRs can be eliminated. You can either just

Re: [webkit-dev] Augmenting WebKit contextual menus for non-plugin content

2007-05-25 Thread David Hyatt
Augmenting contextual menus really has nothing to do with plug-ins, so I'm not sure how the conversation ended up at plug-ins. :) Changing context menus is getting more into the realm of extensions. dave On May 25, 2007, at 4:15 PM, David Hyatt wrote: On May 25, 2007, at 4:07 PM

Re: [webkit-dev] WebForms 2.0 and Webkit

2007-06-06 Thread David Hyatt
Web Forms 2 is a subset of HTML5. It is not XForms. Speaking for Apple, we do plan to work on Web Forms 2 support eventually. We have no plans to work on XForms, but contributions/patches are always welcome. dave On Jun 6, 2007, at 1:42 PM, David D. Kilzer wrote: Hi Andre, Is Web

Re: [webkit-dev] Reflections on FontPlatformData, FontCache

2007-06-30 Thread David Hyatt
Yes, the ownership model is kind of a mess right now. It doesn't really matter yet, since the font cache just grows without bound throughout the lifetime of a session. The reality is that a lot of refcounting probably needs to be added. I want to hold off changing the messed up ownership

Re: [webkit-dev] platform/ reorganization

2007-11-28 Thread David Hyatt
On Nov 28, 2007, at 3:24 PM, Nikolas Zimmermann wrote: Am 26.11.2007 um 19:18 schrieb Darin Adler: On Nov 16, 2007, at 6:15 PM, David Hyatt wrote: I'd vote for putting all of these files under platform/text (the bidi, font and text files) rather than creating three new subdirectories

Re: [webkit-dev] platform/ reorganization

2007-11-28 Thread David Hyatt
We should maybe rename TextStyle to FontStyle. dave On Nov 28, 2007, at 3:44 PM, Nikolas Zimmermann wrote: Am 28.11.2007 um 22:33 schrieb Darin Adler: On Nov 28, 2007, at 1:24 PM, Nikolas Zimmermann wrote: Am 26.11.2007 um 19:18 schrieb Darin Adler: On Nov 16, 2007, at 6:15 PM, David

Re: [webkit-dev] custom containers advantage over stl containers

2008-01-07 Thread David Hyatt
On Jan 7, 2008, at 3:19 PM, Darin Adler wrote: The standard C++ library std::vector and std::hash_map also rely on C ++ exceptions, and our entire project works with a limited dialect of C++ that doesn't use RTTI or exceptions. To clarify this point, we found that using RTTI/exceptions

Re: [webkit-dev] Pulling together on WebKit Mobile

2008-01-16 Thread David Hyatt
This is how we did it when we (briefly) had CG and Cairo compiling simultaneously. The problem with it though is that we had a copy of Cairo in our source tree and ended up having to hack the Cairo source to put #if PLATFORM(CAIRO) around those files. If Cairo is going to be brought in

[webkit-dev] absolutePosition

2008-01-17 Thread David Hyatt
The absolutePosition function in the render tree is extremely problematic. It also does not work in the presence of transforms or multi-column layout and is extremely slow (calling it inside other loops is often the cause of O(n^2) behavior). I would like every WebKit reviewer to be on

Re: [webkit-dev] whats bidi stand for?

2008-02-02 Thread David Hyatt
I'd vote for LineLayout.cpp. dave On Feb 2, 2008, at 5:09 PM, Eric Seidel wrote: That sounds like one vote for renaming that file. BidirectionalTextLayout.cpp :) Or maybe BidirectionalWordSorting or similar. Mitz and Hyatt are two of very few to ever have hacked on that file. -eric

Re: [webkit-dev] Full page zooming support on WebKit over GTK

2008-02-28 Thread David Hyatt
I am planning to pick this feature up and work on it pretty soon (once I clean up some of my Acid3 regressions). dave On Feb 28, 2008, at 9:25 AM, Srinivas Rao M Hamse wrote: Hi Alp, I was trying to enable the full page zooming support on WebKit (on Gtk build over DirectFB). While

[webkit-dev] Wrestling with Widgets

2008-03-14 Thread David Hyatt
I am wrestling with how to handle transforms on Widgets (for features like full page zoom) and am basically looking for some advice/feedback. Widgets currently are: (1) Frames (2) Scrollbars (3) Plugins On Mac, all three of these widget types are backed by NSViews. On Windows, we hand-roll

Re: [webkit-dev] Web Inspector Can't Save Images or Open Images in New Window

2008-03-18 Thread David Hyatt
I would guess that you have a misbehaving extension/add-on installed. dave On Mar 18, 2008, at 5:07 PM, Ben Mills wrote: After upgrading to Safari 3.1 why can I no longer open web inspector and download images or open them in a new window. The contextual menu has the options but they do

Re: [webkit-dev] dectecting changes from event handling

2008-03-26 Thread David Hyatt
On Mar 26, 2008, at 10:35 AM, [EMAIL PROTECTED] wrote: Hi, I am trying to understand event handling in the webkit. I have a few questions/confusions. Could anyone tell me how to detect layout changes in the view that are triggered from the event model? For example, when a click occurs

[webkit-dev] Changes related to canvas

2008-04-16 Thread David Hyatt
This is a heads up to let people know that the way canvas draws is going to be changing soon. Right now canvas uses two methods on GraphicsContext to draw: paintBuffer drawImage (ImageBuffer version) I recently added a cross-platform Image* accessor (image()) to ImageBuffer. However

Re: [webkit-dev] Font description + font family = redundancy?

2008-06-18 Thread David Hyatt
You can specify multiple font families in a single CSS font declaration. Therefore a FontDescription can contain multiple families in a list. The AtomicString represents one of the families in the list. dave On Jun 18, 2008, at 5:04 PM, Joshua Chia wrote: I'm trying to understand the

Re: [webkit-dev] Update on memory allocation control proposal...

2008-06-18 Thread David Hyatt
Maybe move this work into a WebKit bug? dave On Jun 18, 2008, at 5:09 PM, Paul Pedriana wrote: I've created a working wtf/New.h file and a basic unit test for it. It implements both of Maciej's recent proposals, which were essentially 1: provide an allocation base class and 2: provide a

Re: [webkit-dev] LengthType

2008-07-03 Thread David Hyatt
auto = no value specified in CSS relative = the * unit notation used in table layout, e.g., 5* percent = percent units in CSS, e.g., 50% fixed = a fixed value in CSS pixels The rest are almost not worth going into as they are not fully fleshed out (Intrinsic, MinIntrinsic are used a little bit

Re: [webkit-dev] Translucent (i)frames support

2008-07-17 Thread David Hyatt
The bug on Mac at least is just that NSScrollViews blit when scrolling, and they know nothing about transparency layers. Our solution to similar problems has been to just disable blitting in these cases and do slow repainting when scrolling happens. Because there is *no cache* of

Re: [webkit-dev] Translucent (i)frames support

2008-07-21 Thread David Hyatt
On Jul 21, 2008, at 3:24 AM, Artem Ananiev wrote: David Hyatt wrote: The bug on Mac at least is just that NSScrollViews blit when scrolling, and they know nothing about transparency layers. Our solution to similar problems has been to just disable blitting in these cases and do slow

Re: [webkit-dev] JavaScriptCore cleanup

2008-09-07 Thread David Hyatt
I like JSCore. dave On Sep 7, 2008, at 7:16 PM, Maciej Stachowiak wrote: I like JSC or SFX or JSCore. JavaScriptCore is too long. - Maciej On Sep 7, 2008, at 1:56 PM, Cameron Zwarich wrote: Now that SquirrelFish Extreme has landed, we should perform some of the cleanup that we've been

Re: [webkit-dev] ScrollbarPart and the way it is used

2008-09-20 Thread David Hyatt
On Sep 20, 2008, at 9:55 AM, Darin Adler wrote: I believe this is Hyatt's design: ScrollbarPart is used when the argument is going to be a single part. ScrollbarControlPartMask is used when the argument is a set of parts. The same enum values, from the definition of ScrollbarPart, are used

Re: [webkit-dev] ScrollbarPart and the way it is used

2008-09-20 Thread David Hyatt
I looked at your patch and it was fine. Your theme APIs on Qt are so good that your theme is actually much simpler than the other platforms. :) dave On Sep 20, 2008, at 9:03 AM, Holger Freyther wrote: Hey, So ScrollBarPart is a bitmask and could be ored together but then I see code

Re: [webkit-dev] iPhone + SVG

2008-09-23 Thread David Hyatt
Yes, it was flipped on in 2.1. http://ajaxian.com/archives/svg-working-on-the-iphone dave ([EMAIL PROTECTED]) On Sep 23, 2008, at 12:40 PM, Nikolas Zimmermann wrote: Good evening WebKit crowd, I came around a page using SVG on the iPhone today, and I'm puzzled - it actually displays SVG

Re: [webkit-dev] setTimeout as browser speed throttle

2008-09-29 Thread David Hyatt
We encountered 100% CPU spins on amazon.com, orbitz.com, mapquest.com, among others (looking through Radar histories). This was pre-clamp. Web sites make this mistake because they don't know any better, and it works fine in IE. It is a mistake these sites will continue to make, and

Re: [webkit-dev] setTimeout as browser speed throttle

2008-09-30 Thread David Hyatt
On Sep 30, 2008, at 9:37 AM, Mike Belshe wrote: Thanks for the concrete examples, Dave! I tested all 3 of these, and haven't yet found any problems. But I don't have specific URLs. I also looked through the webkit bugs database as much as I could, and could not locate them. When

Re: [webkit-dev] changes to gtk+ port

2008-10-01 Thread David Hyatt
ScrollView is undergoing heavy refactoring right now to make it more cross-platform (to enable all ports to share a lot more of the code). The code in question just moved (today) into the chrome clients over on the WebKit side. WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp The method

Re: [webkit-dev] changes to gtk+ port

2008-10-01 Thread David Hyatt
Oh, by the way https://bugs.webkit.org/show_bug.cgi?id=21083 is the bug tracking the ScrollView refactoring. dave ([EMAIL PROTECTED]) On Oct 1, 2008, at 3:06 AM, David Hyatt wrote: ScrollView is undergoing heavy refactoring right now to make it more cross-platform (to enable all ports

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread David Hyatt
Kind of an unrelated note, but it would be nice to rename KURL to something else e.g., WebCoreURL, URL, WebURL, etc. dave On Oct 2, 2008, at 3:07 PM, Brett Wilson wrote: About a year ago, Google released the Google URL Parsing and Canonicalization Library (Google-URL) as a separate

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread David Hyatt
It's kind of ridiculous to have an external dependency on a piece of code this tiny. dave On Oct 2, 2008, at 4:41 PM, Peter Kasting wrote: On Thu, Oct 2, 2008 at 2:23 PM, Maciej Stachowiak [EMAIL PROTECTED] wrote: I consider the option of completely replacing WebKit's URL implementation

Re: [webkit-dev] Using Google-URL in WebKit

2008-10-02 Thread David Hyatt
On Oct 2, 2008, at 5:35 PM, Darin Fisher wrote: On Thu, Oct 2, 2008 at 3:27 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 2, 2008, at 4:23 PM, Maciej Stachowiak wrote: I have mentioned optionally replacing KURL with an ifdef to a number of WebKit members. The reception has been

Re: [webkit-dev] The WebCore/platform/ directory situation

2008-10-04 Thread David Hyatt
, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 3, 2008, at 9:17 PM, David Hyatt wrote: After working for a while on the WebCore/platform/ directory, it's become clear that people don't really know what this directory is supposed to contain (and by people I mean pretty much everybody, both

Re: [webkit-dev] Zoom functionality

2008-10-07 Thread David Hyatt
On Oct 7, 2008, at 1:22 AM, Pradnya Pathak wrote: Hello All, Does anyone has idea about if the 'zoom factor' style is inherited from parent of a node? can a node have different zoom factor than its parent? It can yes. zoom is multiplicative so if a parent has a zoom of 2 and a child

Re: [webkit-dev] webkit core need to be cleanly separated from ports, behind a vector table

2008-10-14 Thread David Hyatt
The term webkit core in your subject is very confusing. Do you mean WebKit or WebCore? There is platform-specific code in both. dave On Oct 14, 2008, at 4:24 PM, Luke Kenneth Casson Leighton wrote: https://bugs.webkit.org/show_bug.cgi?id=21598 copy of the bugreport is here: a c struct

[webkit-dev] EOT Support in WebKit

2008-10-17 Thread David Hyatt
I would like to talk about EOT support in WebKit. http://www.w3.org/Submission/EOT/ EOT is an alternate file format for delivery of fonts using the @font- face directive. It is supported by Internet Explorer on Windows. Microsoft has been trying to push it as a standard instead of allowing

Re: [webkit-dev] EOT Support in WebKit

2008-10-17 Thread David Hyatt
On Oct 17, 2008, at 10:35 AM, Peter Kasting wrote: I'm not convinced that supporting EOT in the no-DRM way Hixie proposes is harmful, although I wish it weren't needed. My problem with this idea is that it's one thing to support a DRM-free open format. It's another thing entirely to

Re: [webkit-dev] EOT Support in WebKit

2008-10-17 Thread David Hyatt
On Oct 17, 2008, at 2:22 PM, Amanda Walker wrote: On Fri, Oct 17, 2008 at 12:41 PM, David Hyatt [EMAIL PROTECTED] wrote: The big problem is if you support it, EOT wins. We may as well remove the TTF code path from the tree. EOT is unwieldy to use, doesn't support the full range of TTF

Re: [webkit-dev] EOT Support in WebKit

2008-10-17 Thread David Hyatt
On Oct 17, 2008, at 4:58 PM, Peter Kasting wrote: On Fri, Oct 17, 2008 at 2:52 PM, David Hyatt [EMAIL PROTECTED] wrote: It's important to recognize that if you flip the EOT switch, you're going to end up using EOT over TTF in many cases. In fact if IE *does* in end up skipping TTF files

Re: [webkit-dev] EOT Support in WebKit

2008-10-17 Thread David Hyatt
On Oct 17, 2008, at 5:03 PM, Amanda Walker wrote: On Fri, Oct 17, 2008 at 5:52 PM, David Hyatt [EMAIL PROTECTED] wrote: On Oct 17, 2008, at 2:22 PM, Amanda Walker wrote: EOT is irrelevant to the technical and operational advantages of TTF. That's simply not true. In order to avoid using

Re: [webkit-dev] globals and guidelines

2008-12-09 Thread David Hyatt
This is an area where we haven't settled on a convention yet, which is why you see these inconsistencies. At various times I've used gXXX as well as s_. My own preference is for gXXX, even though it isn't particularly consistent with the m_XXX member variable convention. dave On

Re: [webkit-dev] WebKit runtime image compression

2008-12-15 Thread David Hyatt
On Dec 14, 2008, at 1:12 AM, Paul Pedriana wrote: For a lot of web pages, images are the primary source of memory usage. These images seem to be typically stored as RGB or ARGB data in the BitmapImage class. This isn't always true though. For example, the ports that use CG have

Re: [webkit-dev] Rendering of HTML Form controls

2009-01-15 Thread David Hyatt
Long-term this code will move into the platform directory. This refactoring has already been started with the new Theme class. dave (hy...@apple.com) On Jan 15, 2009, at 3:14 PM, Adele Peterson wrote: Hi Javed, Take a look at RenderThemeWin in the rendering directory. - Adele On Jan 15,

Re: [webkit-dev] SVG pixel test failures (recent regressions?)

2009-01-26 Thread David Hyatt
On Jan 26, 2009, at 1:56 AM, Darin Adler wrote: It looks to me like the pixel test failures are showing some real regressions; they must be recent ones. For example, take a look at this test. http://build.webkit.org/results/trunk-mac-intel-pixel/1625/svg/text/text-align-03-b-diffs.html

Re: [webkit-dev] SVG pixel test failures (recent regressions?)

2009-01-26 Thread David Hyatt
On Jan 26, 2009, at 12:02 PM, Darin Adler wrote: On Jan 26, 2009, at 9:58 AM, David Hyatt wrote: Yes. I'd have done it myself, but I have Perian installed. run- webkit-tests is refusing to allow me to generate new pixel test results (despite the fact that Perian affects only tests

Re: [webkit-dev] Optimizations for loading images referenced in CSS

2009-01-26 Thread David Hyatt
An image specified in CSS only loads if some element in the page matches that particular style rule. dave On Jan 26, 2009, at 12:52 PM, Jesse Young wrote: How are the referenced images inside a CSS file loaded? Does it load all at once, or only the images from the styles on the current

[webkit-dev] Please stop sending mail to this list about specific bugs

2009-02-19 Thread David Hyatt
Bugzilla has comment posting for a reason. Stop sending mail about specific bugs to this list. If you have something to say about a particular bug, just post it in the bug. Thank you. dave (hy...@apple.com) ___ webkit-dev mailing list

Re: [webkit-dev] Applying transforms to box-reflect

2009-03-04 Thread David Hyatt
That's not possible (mainly just a syntactic limitation). Right now the transform is essentially determined by the first keyword, e.g., below. Internally the code could handle an arbitrary transform, but the syntax doesn't support it. dave (hy...@apple.com) On Mar 4, 2009, at 12:04 PM,

Re: [webkit-dev] Is there any Windows-GDI-only port?

2009-03-23 Thread David Hyatt
On Mar 23, 2009, at 5:18 AM, 김인기 wrote: Dear all. I’m new comer to WebKit. I want to port WebKit to Windows-Mobile device. But, I could find only CoreGraphics-port and Cairo-port. Is there no Windows-GDI-only port? If it is not exist, there is any reason for it? In my humble thought, porting

Re: [webkit-dev] How does webkit keep track of co-ordinates/dimension of each line of text in a Paragraph tag?

2009-03-29 Thread David Hyatt
Check out InlineTextBox in the rendering directory. dave On Mar 29, 2009, at 5:40 PM, ying lcs wrote: Hi, Can you please tell me how does webkit keep track of co-ordinates/dimension of each line of text in a Paragraph tag? For example, if I have a Paragraph of text. Web kit will split it up

Re: [webkit-dev] nodeAtPoint is very confusing

2009-04-08 Thread David Hyatt
Yeah this was on my list of things to do, but I stopped my big render tree refactoring for the sake of stability. I think we should hold off on more big changes to render tree methods for now. dave On Apr 8, 2009, at 5:50 PM, Maciej Stachowiak wrote: On Apr 8, 2009, at 9:23 AM, Simon

Re: [webkit-dev] An idea to improve render performance by caching image-data's intrinsic size

2009-04-10 Thread David Hyatt
On Apr 10, 2009, at 8:51 AM, Johnny Ding wrote: Hi all, I have an idea about caching image's intrinsic size to improve render performance. We have discussed this idea in the past and discarded it for a number of reasons, mainly: (1) Most Web pages at this point specify an explicit size

Re: [webkit-dev] An idea to improve render performance by caching image-data's intrinsic size

2009-04-10 Thread David Hyatt
popping in typically beat the first actual layout (at the 250ms mark) anyway. dave (hy...@apple.com) On Apr 10, 2009, at 11:20 AM, David Hyatt wrote: On Apr 10, 2009, at 8:51 AM, Johnny Ding wrote: Hi all, I have an idea about caching image's intrinsic size to improve render performance. We

Re: [webkit-dev] An idea to improve render performance by caching image-data's intrinsic size

2009-04-13 Thread David Hyatt
On Apr 13, 2009, at 2:16 PM, Johnny Ding wrote: Hi Dave, Maciej Thanks very much for quick response and detail explanation! It did convince me. I will try to add log like Maciej suggested to see how common the situation is. Yes, some logging data would be very helpful. If it turns out

Re: [webkit-dev] WebKit partial rendering issue

2009-05-11 Thread David Hyatt
On May 11, 2009, at 11:58 AM, lkcl wrote: Paul Pedriana-3 wrote: The ScrollView::paint function seems wrong to me too. The function source is shown below. I don't understand why it uses context-clip(visibleContentRect()) without accounting for documentDirtyRect. Shouldn't it make a union

Re: [webkit-dev] WebKit partial rendering issue

2009-05-15 Thread David Hyatt
On May 15, 2009, at 12:18 PM, lkcl wrote: https://bugs.webkit.org/show_bug.cgi?id=25696#c2 thanks to paul for the guidance and for the leading work / patches on which this is based, paul, the code that you sent me has a bug where the scrollbars on a frame will go blank and disappear when

Re: [webkit-dev] Multiple views of the same RenderBlock

2009-05-23 Thread David Hyatt
This will be a fair bit of work to do cleanly, but basically you would need to enable a document to have multiple FrameViews. In addition, each frame view would need its own unique render tree, so you'd have to move ownership of m_renderer member variables off of Node and into something

Re: [webkit-dev] WebCore rendering questions

2009-05-26 Thread David Hyatt
On May 26, 2009, at 1:42 PM, ying lcs wrote: Hi, In here http://webkit.org/blog/114/webcore-rendering-i-the-basics/, it talks about DOM tree and Render tree. Can you please tell me does it mean for each DOM element, * there will be a Render Object (1-to-1 mapping)? What about invisible

Re: [webkit-dev] Duplicate page: Implementing Print Preview

2009-05-27 Thread David Hyatt
Can you render the page to PDF and display the PDF? Maybe you could render the page into bitmaps if you aren't able to support PDF. dave (hy...@apple.com) On May 27, 2009, at 11:53 AM, Sverrir Á. Berg wrote: Hi all, I'm working on Google Chrome and trying to come up with a way to

Re: [webkit-dev] Need help in understanding Webkit reflow

2009-05-27 Thread David Hyatt
Check out the layout() methods on RenderObject and its subclasses. dave On May 27, 2009, at 3:17 PM, Lucius Fox wrote: HI, I would like some help/pointers in how to understand Webkit reflow logic/mechanism. I would like to know given a URL, what elements are re-layout/re-calculate dimension

Re: [webkit-dev] Duplicate page: Implementing Print Preview

2009-05-28 Thread David Hyatt
On May 28, 2009, at 1:13 PM, Marc-Antoine Ruel wrote: To clarify Sverrir and my intent; PDF (or EMF as it's currently done on the windows port of Chromium) snapshot is fine for a static print preview but useless for a dynamic one. We'd prefer to have something interactive. If a user

Re: [webkit-dev] Ruby design document

2009-06-03 Thread David Hyatt
On Jun 3, 2009, at 4:59 PM, Roland Steiner wrote: Hi Peter, You're right, that was an oversight, I added the reference to the introduction part, and highlighted the differences as you mentioned. My current implementation aims to be forward-compatible with both HTML5 and CSS3, which seems

Re: [webkit-dev] Ruby design document

2009-06-03 Thread David Hyatt
On Jun 3, 2009, at 7:15 PM, Maciej Stachowiak wrote: On Jun 3, 2009, at 5:12 PM, Peter Kasting wrote: On Wed, Jun 3, 2009 at 5:04 PM, Roland Steiner rolandstei...@google.com wrote: However, if the consensus is that we should rather take those objects out (Ian Hickson doesn't seem to be a

Re: [webkit-dev] Ruby design document

2009-06-03 Thread David Hyatt
On Jun 3, 2009, at 7:33 PM, David Hyatt wrote: The CSS3 draft is clearly very incomplete and not ready for primetime, so the more I look at it, the more I'm thinking we should maybe just limit ourselves to an HTML5/IE-compatible implementation. In other words I'm thinking we should

Re: [webkit-dev] Question about CSS in Webkit

2009-06-04 Thread David Hyatt
On Jun 4, 2009, at 3:24 PM, Darin Adler wrote: On Jun 4, 2009, at 1:19 PM, Nathan Summer wrote: My question is if the CSS information stored Twice? onces are in the internal data structure built after parsing the CSS and other is in RenderStyle? The CSS stores the style rules. The

Re: [webkit-dev] Quesition about DumpRenderTree output

2009-06-17 Thread David Hyatt
On Jun 16, 2009, at 12:26 AM, Lucius Fox wrote: Hi, Can you please tell me what is the meaning of relative positioned and the meaning of positioned in DumpRenderTree? Those are CSS terms. Relative positioned means you have position:relative specified in CSS. Positioned with no qualifier

Re: [webkit-dev] Review states

2009-06-17 Thread David Hyatt
On Jun 17, 2009, at 1:20 PM, Joe Mason wrote: Eric Seidel wrote: It would appear bugzilla is too lame to support changing flag values +/-/? are all we get. :( https://bugs.webkit.org/editflagtypes.cgi (only accessible to bugzilla users with edit privilages). Maybe the solution is a different

Re: [webkit-dev] InlineBox::m_isSVG

2009-06-19 Thread David Hyatt
On Jun 18, 2009, at 9:38 PM, Eric Seidel wrote: Agreed. That should just be a virtual call. I don't see any reason for that to need to be a bit on the baseclass. I do not think that changing ti to be a virtual call would cause a noticeable performance change. -eric You can test and see,

Re: [webkit-dev] InlineBox::m_isSVG

2009-06-22 Thread David Hyatt
On Jun 21, 2009, at 11:18 PM, Roland Steiner wrote: Hi Dave, as I will probably need to special-case height() for ruby InlineBox objects in the same way as is done for SVG boxes (still ironing out the details, though), making height() virtual was exactly my intent. I would have thought

Re: [webkit-dev] Should we restrict Web Fonts to same-origin by default?

2009-06-22 Thread David Hyatt
On Jun 22, 2009, at 2:38 PM, Maciej Stachowiak wrote: Mozilla restricts downloaded fonts to same-origin by default, with the ability for the hosting site to open up access via Access- Control (aka CORS). Apparently this step has the potential to make font foundries more comfortable about

Re: [webkit-dev] Dimension of Render Containers

2009-06-25 Thread David Hyatt
On Jun 25, 2009, at 11:50 AM, n179911 wrote: Hi, Does the dimension (width X height) of Render Containers (e.g. RenderBlock, RenderTableRow, RenderTableCell) always encompass all its children? For example, The Render Block is 145 x 14 which encompasses its children RenderInline (145x12),

Re: [webkit-dev] WebKit zooming behavior

2009-06-25 Thread David Hyatt
That API is more about desktop zooming. I wouldn't really recommend using it as a model for zooming on a mobile platform. dave (hy...@apple.com) On Jun 25, 2009, at 12:15 PM, Javed Rabbani wrote: Hello everyone, I was trying to zoom a web page (text + images) through WebKit API:

Re: [webkit-dev] Dimension of Render Containers

2009-06-25 Thread David Hyatt
On Jun 25, 2009, at 8:36 PM, David Hyatt wrote: On Jun 25, 2009, at 11:50 AM, n179911 wrote: Hi, Does the dimension (width X height) of Render Containers (e.g. RenderBlock, RenderTableRow, RenderTableCell) always encompass all its children? For example, The Render Block is 145 x 14 which

Re: [webkit-dev] italics and blink support on GTK port

2009-06-30 Thread David Hyatt
On Jun 30, 2009, at 1:56 PM, zaheer ahmad wrote: 2- blink css tag (text-decoration: blink;} is not working Blink is (deliberately) not supported in WebKit. dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org

[webkit-dev] Important change for ports regarding FocusController

2009-07-01 Thread David Hyatt
In order to get focus memory for tabs working properly, we need a notion of whether or not the underlying Page is focused. We need this since Web pages should be able to shift around programmatic focus in background tabs and have the new focused frame and focused node be remembered if you

Re: [webkit-dev] Reviewer Nomination: Peter Kasting

2009-07-02 Thread David Hyatt
Seconded. On Jul 2, 2009, at 3:10 AM, Eric Seidel wrote: I would like to nominate Peter Kasting as a WebKit reviewer. Peter is most well known for all his work on the Image Decoders. At this point, I believe he's webkit's #1 expert on how they work. Peter also worked on other random bits of

Re: [webkit-dev] Bug 22759 - dropdown menu disappears on mouse-over

2009-07-06 Thread David Hyatt
Can't you just post this in the bug? I fail to see why this should be a topic for discussion on webkit-dev. dave (hy...@apple.com) On Jul 5, 2009, at 1:18 PM, Vamsi Kalyan wrote: Hi, this post is related to issue https://bugs.webkit.org/show_bug.cgi?id=22759. corresponding chrome issue

Re: [webkit-dev] Detecting a finished paint via JavaScript

2009-07-08 Thread David Hyatt
On Jul 8, 2009, at 12:45 PM, RDC wrote: Would you be willing elaborate on why you want this? Of course; I would like it for benchmarking page rendering times-- something I believe would be possible with Web Inspector, but I'm after a cross-browser way of achieving it. At the moment I

Re: [webkit-dev] Detecting a finished paint via JavaScript

2009-07-08 Thread David Hyatt
This still omits the cost of painting from a benchmark though. dave On Jul 8, 2009, at 12:57 PM, Darin Fisher wrote: While this is not a perfect solution, a common technique is to call (from onload) a DOM method like offsetHeight that forces layout to run. That way the bulk of the work

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread David Hyatt
I agree. We should formalize this as policy too in my opinion. Maybe something time-based, e.g., if you have an implementation of a new Web technology that is going to take (1month?) to implement, then the feature should be landed inside ENABLE ifdefs (that can then be removed when the

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread David Hyatt
On Jul 13, 2009, at 12:52 PM, Peter Kasting wrote: On Mon, Jul 13, 2009 at 10:47 AM, David Hyatt hy...@apple.com wrote: I agree. We should formalize this as policy too in my opinion. Maybe something time-based, e.g., if you have an implementation of a new Web technology that is going

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread David Hyatt
On Jul 13, 2009, at 1:52 PM, Jeremy Orlow wrote: On Mon, Jul 13, 2009 at 11:40 AM, David Hyatt hy...@apple.com wrote: On Jul 13, 2009, at 12:52 PM, Peter Kasting wrote: On Mon, Jul 13, 2009 at 10:47 AM, David Hyatt hy...@apple.com wrote: I agree. We should formalize this as policy too in my

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread David Hyatt
On Jul 13, 2009, at 5:02 PM, Darin Fisher wrote: This small interval rule-of-thumb idea sounds pretty good, but I still wish it didn't put the burden on the guy doing the branch to figure out what is or isn't incomplete about a particular snapshot of WebKit. That guy might not be savy

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread David Hyatt
On Jul 13, 2009, at 5:17 PM, David Hyatt wrote: It's the organization shipping their product that should be working to determine when their product is shippable. This may in fact be the most incomprehensible sentence I have ever typed. :) dave (hy...@apple.com

Re: [webkit-dev] Reformatting-only patches being applied to trunk

2009-07-25 Thread David Hyatt
On Jul 25, 2009, at 3:08 AM, Oliver Hunt wrote: I've just noticed that there have been a few purely style related patches being landed in the tree recently, I don't believe these are a good idea and that any further reformatting only patches be rejected. I completely disagree. I see

Re: [webkit-dev] initializing protected variable in a subclass

2009-08-03 Thread David Hyatt
Make your base class constructor take the role as an argument. Then the subclasses can just pass in the value they want to use to initialize it e.g., AccessibilityObject(AccessibilityRole role) : m_role(role) { } and then in the subclass AccessibilityImageMapLink() :

Re: [webkit-dev] I *HATE* CHANGELOGS!!!

2009-08-26 Thread David Hyatt
On Aug 26, 2009, at 3:43 PM, Maciej Stachowiak wrote: On Aug 26, 2009, at 3:37 PM, David Hyatt wrote: If the files could just merge properly, I would not be so annoyed, but the fact that you basically have to re-resolve conflicts every time anyone beats you to a checkin is just horrible

Re: [webkit-dev] Inline vs Inline Block and relative positioning for MathML

2009-08-27 Thread David Hyatt
You really don't want to use relative positioning to move objects around like this. The objects should just be placed into the correct positions by the layout() method without having to resort to relative positioning. You also can't mutate a DOM-backed renderer's style like that as it

[webkit-dev] User Stylesheets changes I'd like to make

2009-09-04 Thread David Hyatt
Right now the user stylesheet location is stored as a URL. This is based off ancient history, namely that we happened to store the preference this way on Mac. Even though Safari only allows you to pick local files from its UI for user stylesheets, the preference itself is a URL. Because

Re: [webkit-dev] User Stylesheets changes I'd like to make

2009-09-04 Thread David Hyatt
either, and going forward we should be discouraging file accesses like this from being done inside WebCore. dave (hy...@apple.com) On Sep 4, 2009, at 2:52 PM, Tor Arne Vestbø wrote: On 9/4/09 9:47 PM, David Hyatt wrote: Right now the user stylesheet location is stored as a URL. This is based

Re: [webkit-dev] mfenced - more MathML questions

2009-09-09 Thread David Hyatt
It's hard for me to understand what this problem is without more information. Are these objects inlines or blocks or what? dave On Sep 8, 2009, at 6:30 PM, Alex Milowski wrote: I've been doing some comprehensive testing and find that my technique for handling fencing isn't working properly

Re: [webkit-dev] mfenced - more MathML questions

2009-09-09 Thread David Hyatt
So fencing should extend from the line top to the line bottom it sounds like without affecting the overall height of the line? Have you tried placing them with a y position of the root line box's line top and a height of line bottom - line top? dave On Sep 9, 2009, at 12:39 PM, Alex

Re: [webkit-dev] Review Flag Requestee field

2009-10-05 Thread David Hyatt
I agree with just disabling/removing it. On Oct 5, 2009, at 2:23 PM, Eric Seidel wrote: It seems that the requestee field is a source of confusion for new contributers. Especially so when the new contributor comes from another project where the requestee field may be required (Google,

Re: [webkit-dev] Landing your own patches

2009-10-14 Thread David Hyatt
On Oct 14, 2009, at 1:22 AM, Sam Weinig wrote: I understand the concern of those working on Windows who don't necessarily have access to a Mac and I applaud your fear of breaking the build, but I think in the end you are using the wrong tool (admittedly due to a lack of trybots, but the

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread David Hyatt
On Oct 16, 2009, at 7:07 PM, Evan Martin wrote: When you select multiple lines of text in WebKit, the highlight paints over whitespace on the right margin. This is correct behavior for Mac, but not for Windows or Linux. I would suggest making it be controlled by a Setting rather than

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-19 Thread David Hyatt
On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote: On Mon, Oct 19, 2009 at 1:10 PM, David Hyatt hy...@apple.com wrote: I can get how editing in text fields you might feel a desire to match the platform (where ragged selection may be the convention), but once you get into rich text selection

  1   2   3   >