Re: [webkit-dev] SquirrelFish Extreme for non x-86 platforms

2008-12-26 Thread Gavin Barraclough
On Dec 25, 2008, at 3:51 AM, Oliver Hunt wrote: You can manually align the memory, eg. char* memory = malloc(size + alignment - 1); memory += alignment; memory = ~(alignment - 1) return memory; Oops, think you meant: memory += (alignment - 1); G. The obvious problem with this is

Re: [webkit-dev] want to port JIT to MIPS, any coworker or any hint?

2009-01-25 Thread Gavin Barraclough
On Jan 24, 2009, at 8:36 PM, x yz wrote: Just build webkit on XP using cgywin, not tested yet. I want to port to 32bit MIPS, it seems I need to touch JIT and rewrite assembler folder. Once you have the bytecode interpreter up and running on MIPS, I'd recommend starting by just trying to

Re: [webkit-dev] want to port JIT to MIPS - using X86::ecx as base

2009-02-06 Thread Gavin Barraclough
On Feb 6, 2009, at 2:52 PM, x yz wrote: 1.what's the meaning of ALTERNATE_JSIMMEDIATE and slow case? On x86-64 we use a different implementation of the class JSImmediate. See JSImmediate.h. Re 'slow case', in the JIT code generation is performed as two passes over the bytecode – see

Re: [webkit-dev] want to port JIT to MIPS

2009-02-19 Thread Gavin Barraclough
? To: Gavin Barraclough Cc: WebKit Development Date: Monday, February 16, 2009, 5:25 AM Hi, from paltform.h it is enabled only on X86 MAC/WIN; from javaScriptCore.pri it is also enabled for (QT_ARCH,i386). But, from config.log I see them are enabled

Re: [webkit-dev] want to port JIT to MIPS - how to get of SSE2 now?

2009-02-26 Thread Gavin Barraclough
time! joe --- On Sun, 2/22/09, x yz wrote: From: x yz Subject: Re: [webkit-dev] want to port JIT to MIPS To: WebKit Development, Gavin Barraclough Date: Sunday, February 22, 2009, 4:34 PM Thanks a lot

Re: [webkit-dev] want to port JIT to MIPS - how to get of SSE2 now?

2009-02-26 Thread Gavin Barraclough
). cheers, G. On Feb 26, 2009, at 5:39 PM, x yz wrote: yes but if isSSE2Present() returns false the code becomes very simple so I doubt it may be slow. what's the benefit to enable/disable ALTERNATE_JSIMMEDIATE? thanks joe --- On Fri, 2/27/09, Gavin Barraclough wrote

Re: [webkit-dev] want to port JIT to MIPS - JIT reg usage clean up?

2009-02-27 Thread Gavin Barraclough
On Feb 27, 2009, at 4:55 PM, x yz wrote: The regTx seems to be working registers here, yet their definition are regparm(3) registers for function arugments. Such usage would cause conflict on other platforms. May I suggest that we use individual defined set of regs for func i/o argument

Re: [webkit-dev] how to store javascript identifier

2009-03-04 Thread Gavin Barraclough
On Mar 4, 2009, at 2:22 AM, zhenghe zhang wrote: When running a webpage, and the javascriptcore will parse the javascript function, and will obtain some identifiers. I don't know how to store these identifiers and where to store these identifiers. These identifiers are stored in the

Re: [webkit-dev] want to port JIT to MIPS - can anybody explain JIT::linkCall?

2009-03-06 Thread Gavin Barraclough
patchOffsetPutByIdStructure = 7; static const int patchOffsetPutByIdPropertyMapOffset = 22; static const int patchOffsetGetByIdBranchToSlowCase = 13; thanks for help, I'm stucked here now. joe --- On Sat, 2/28/09, Gavin Barraclough wrote: From: Gavin Barraclough

Re: [webkit-dev] x86-64 JIT

2009-03-18 Thread Gavin Barraclough
On Mar 18, 2009, at 11:06 AM, Mike Hommey wrote: An earlier call to JSC::JITStubs::cti_op_call_NotJSFunction works and a lot of other stub functions are called before the crash, so it means most of the JIT works, but it is failing in a subtle way. I'd suggest trying to produce a reduction

Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs

2009-04-30 Thread Gavin Barraclough
Maciej, This sounds good, and sounds like it could clean things up a lot. In the breakdown below you don't explicitly mention what would happen to h/w specific macros like PLATFORM_X86, though you do mention 'CPU' in your email, OOI are you thinking something like?: CPU() Examples:

Re: [webkit-dev] YARR

2009-05-19 Thread Gavin Barraclough
On May 19, 2009, at 12:55 PM, Kenneth Christiansen wrote: Great! I notices that RegExp.h still includes WREC, will that be changed? WREC should be removed completely fairly soon. We just wanted to leave some overlap with YARR and WREC both in ToT, in case we needed to revert back to

Re: [webkit-dev] Webkit JavaScript question

2009-05-27 Thread Gavin Barraclough
Hi Zoltan, I don't think so. It is not worth to do it on a desktop pc since interpreter is always slower than JIT. However, the story is different for embedded systems, when they enter low-memory mode. Whilst it is certainly true that this would likely be of most benefit on embedded

Re: [webkit-dev] stack alignment bug

2009-06-03 Thread Gavin Barraclough
This code is designed to keep the stack correctly aligned, and appears to be working correctly. If you think there is a bug here, please report it at cheers, G. On Jun 2, 2009, at 5:26 PM, x yz wrote: I don't know how to file bug so I posted here. In

Re: [webkit-dev] stack alignment bug

2009-06-04 Thread Gavin Barraclough
Hi Zoltan, I'm a little confused – maybe I'm misunderstanding you, but the JIT does just subtract a fixed amount from the stack pointer on entry (28 on x86, for a total frame size including return address, caller frame pointer and callee preserved registers of 48, a multiple of 16 to

Re: [webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Gavin Barraclough
We check in JIT code for cases where arity match, and skip the call to the stub; this function is only called if there is a mismatch to be resolved. The function would probably be better named something like 'cti_op_call_handleArityMismatch'. cheers, G. On Jun 4, 2009, at 1:50 PM,

Re: [webkit-dev] arm jit

2009-06-09 Thread Gavin Barraclough
On Jun 9, 2009, at 2:38 PM, Akos Kiss wrote: Dear Community, Today, we realized that there is a new ARM JIT port for WebKit. ( ) Congratulations on getting this working!, great job. Hi Akos, Thank you! Just to clarify, we have just landed a ARMv7

Re: [webkit-dev] ScopeChainNode leak?

2009-06-10 Thread Gavin Barraclough
Hi Andrew, It certainly sounds likely this is a bug, and the best person to comment on it is probably Oliver, who is not on this list. Could you please file a bug at Many thanks, G. On Jun 10, 2009, at 11:26 AM, Andrew Webster wrote: I've been tracking down a memory leak

Re: [webkit-dev] arm jit

2009-06-10 Thread Gavin Barraclough
On Jun 10, 2009, at 1:15 PM, Toshiyasu Morita wrote: --- On Wed, 6/10/09, Geoffrey Garen wrote: I'm having a hard time understanding from your comment what optimization changes you think are appropriate, but if you can produce a patch that implements your idea, and shows

Re: [webkit-dev] arm jit

2009-06-10 Thread Gavin Barraclough
Toshiyasu, On Jun 10, 2009, at 2:24 PM, Toshiyasu Morita wrote: Why does the arity check need to be in the caller, and not the callee? The majority of call sites always call to the same callee, and we can optimize these cases for calling that same function repeatedly. Within the

Re: [webkit-dev] Trampoline problem

2009-06-11 Thread Gavin Barraclough
On Jun 11, 2009, at 10:20 AM, Toshiyasu Morita wrote: I've tracked down a crash in our JIT port to a problem with the trampoline generation. The symptom of the crash is: the ScopeChain becomes corrupted and acquires the value of 1. void

Re: [webkit-dev] arm jit

2009-06-11 Thread Gavin Barraclough
And here, I have to make a short comment on the non-acceptance of our ARM JIT implementation. In your mail you mention that you would remain reluctant to accept a duplicate of the JIT into the tree, rather than a port of the existing JIT utilizing the MacroAssembler abstraction. Well, did

Re: [webkit-dev] unwritten rules of webkit style

2009-09-03 Thread Gavin Barraclough
I believe the C spec requires that files end in a newline, though I couldn't comment on the c++ spec. Possibly redundant to list this as WebKit style issue, if required by the language? G. On Sep 3, 2009, at 10:11 AM, Darin Adler wrote: On Sep 2, 2009, at 11:18 PM, Brent Fulgham wrote:

Re: [webkit-dev] jit for arm

2009-11-17 Thread Gavin Barraclough
On Nov 4, 2009, at 8:37 AM, ll Jefferry wrote: Hi, when i reading the jit for arm source code, i am not very clear the functionality of the flowing functions: ctiTrampoline This code is used when entering from the C runtime into JIT generated code. JIT generated code does not

Re: [webkit-dev] jit for arm

2009-11-18 Thread Gavin Barraclough
From ListDescription webkit-help [no description available] Hmmm, yes, there would seem to be some scope to make that a little more descriptive! ;-) G. On Nov 17, 2009, at 11:46 PM, Zoltan Herczeg wrote:

Re: [webkit-dev] Proposing style guide change regarding braces on conditional arms

2009-12-03 Thread Gavin Barraclough
On Dec 2, 2009, at 9:57 PM, Dan Bernstein wrote: I am satisfied with the existing rule. +1 ___ webkit-dev mailing list

Re: [webkit-dev] [webkit-changes] [56825] trunk

2010-03-31 Thread Gavin Barraclough
On Mar 31, 2010, at 10:08 AM, Alexey Proskuryakov wrote: On 30.03.2010, at 22:44, wrote: +WebCString::operator WTF::CString() const There probably should be a using CString directive in CString.h - we do that for all public symbols in WTF. There should be ...

Re: [webkit-dev] JSC String re-factorings are hosing the tree.

2010-04-21 Thread Gavin Barraclough
Hi Eric, Many apologies for the redness. These changes are pretty much complete now, so hopefully there shouldn't be any more big file moves like this too soon. One thing that was hugely useful in minimizing the breakage as much as possible while making these changes was the ews bots –

Re: [webkit-dev] Tests that separate JS and HTML

2010-08-13 Thread Gavin Barraclough
On Aug 13, 2010, at 3:17 AM, Alexey Proskuryakov wrote: Of course, there is the special case of fast/js tests, which we (I think) still hope to run without a WebView one day. For that, keeping JS separate is obviously desirable. Absolutely agreed - and these can already be run in a

[webkit-dev] [Qt] QTest / tst_QWebFrame::connectAndDisconnect()

2010-11-15 Thread Gavin Barraclough
Hi, Apologies, I've introduced some red to the tree, a test on Qt needs some new expected results adding, and I can't find where they're kept. The test is tst_QWebFrame::connectAndDisconnect(), the new output is correct (the format for some exception messages has changed slightly), if someone

Re: [webkit-dev] [Qt] QTest / tst_QWebFrame::connectAndDisconnect()

2010-11-15 Thread Gavin Barraclough
Problem solved, thanks to mitzpettel! cheers, G. On Nov 15, 2010, at 8:24 PM, Gavin Barraclough wrote: Hi, Apologies, I've introduced some red to the tree, a test on Qt needs some new expected results adding, and I can't find where they're kept. The test is tst_QWebFrame

Re: [webkit-dev] Question about StringImpl::create

2010-12-16 Thread Gavin Barraclough
On Dec 16, 2010, at 9:45 PM, 谢愈挺 wrote: I have a question about StringImpl::create(). Is it can only input latin1 data? Yes, this method takes latin1 data all const char* arguments in WTFString are handled as latin1. String::fromUTF8 can be used to create strings with utf8 data. If it can

Re: [webkit-dev] String::impl() returns NULL causes crash

2011-04-13 Thread Gavin Barraclough
On Apr 13, 2011, at 5:32 PM, Mo, Zhenyao wrote: What value should we return for hash(NULL)? From the top of the file: // The hash() functions on StringHash and CaseFoldingHash do not support // null strings. get(), contains(), and add() on HashMapString,..., StringHash // cause a

Re: [webkit-dev] WTF StackBounds not compatible with Windows fiber threads custom fiber or thread stack size

2011-08-30 Thread Gavin Barraclough
I had a partially working solution to this using the deallocation stack member of the Win32 Thread Information Block, see – but I didn't manage to get this working consistently. Perhaps

Re: [webkit-dev] unsigned versus size_t in WTFString.h

2011-09-07 Thread Gavin Barraclough
Hi Adam, Yes, I believe our current thinking is that the external interface to String lengths / indices should all be in size_t (though unless we believe we need to support strings 4GB we should keep the length stored as a 32 bit value internally). There are a couple of bugzilla bugs

Re: [webkit-dev] old-run-webkit-tests is officially deprecated.

2011-10-31 Thread Gavin Barraclough
On Oct 27, 2011, at 3:00 PM, Eric Seidel wrote: If you're still using old-run-webkit-tests for your work, I would *love* to know and fix any issues you may have with NRWT. Hi Eric, Unless there is a trick to this that I am unaware of, I think NRWT doesn't support running 32-bit tests on a

Re: [webkit-dev] squirrefish extreme on Arm.

2011-11-29 Thread Gavin Barraclough
-d should work fine on ARM - check your build settings, is any #ifndef NDEBUG code getting built? In addition there are a set of switches in dfg/DFGCommon.h that include ones to enable further dumping of the intermediate representation. G. On Nov 29, 2011, at 2:51 AM, vahagvahag wrote: Hi

Re: [webkit-dev] multithreading in JSC

2011-12-02 Thread Gavin Barraclough
On Dec 2, 2011, at 12:10 PM, venkeng koon wrote: Hi! I have started to invistigate SFX and now have some information about it. But I have still had some quetions and will be very gratefull if you could help me. First. Does SFX support multithreading? Can he compile several funcotion at

Re: [webkit-dev] JavaScriptCore and ES6

2011-12-16 Thread Gavin Barraclough
Hi Andy, As you probably know, the ECMA TC39 committee is slowly approaching consensus on a new revision of the ECMAScript language. The interim results of this process have gone under various names: Harmony,, and ES6. They are the same thing. This mail is intended to open the

Re: [webkit-dev] new shell for JavaScriptCore?

2012-01-10 Thread Gavin Barraclough
On Jan 10, 2012, at 7:33 AM, Andy Wingo wrote: Hello JSC hackers, I've been thinking for some time now that there is room for another command-line shell for JSC. Hi Andy, Yes! Some more things to add to the wish list: * tab completion (e.g. -tab- Math.sin) *

Re: [webkit-dev] Moving to Git?

2012-03-10 Thread Gavin Barraclough
On Mar 9, 2012, at 12:30 PM, Mark Rowe wrote: What you'll find is that the vast majority of SVN users are simply not participating in this email thread. You'll also find that many people that use git-svn are happy enough with the status quo since it gives those who chose to use it most of

Re: [webkit-dev] SH4, MIPS, and legacy-ARM assemblers in JavaScriptCore

2012-06-23 Thread Gavin Barraclough
On the topic of JIT support, the baseline JIT's role is increasingly only to serve only to gather profiling data for the DFG JIT, and if you want high performance JavaScript on your platform you need to have the DFG JIT enabled. As the purpose of the two JITs becomes increasingly coupled it may

Re: [webkit-dev] Breaking cycles in mutation observers in JSC

2012-08-23 Thread Gavin Barraclough
JSC already supports private named properties – you just need allocate a 'PrivateName' object use this as a property name. cheers, G. On Aug 23, 2012, at 1:04 PM, Adam Barth wrote: Another approach might be to implement hidden properties in JavaScriptCore, but I don't

Re: [webkit-dev] MIPS port status update

2012-10-15 Thread Gavin Barraclough
On Oct 15, 2012, at 7:13 AM, Gergely Kis wrote: Should we CC someone directly on these bugs to make the reviews easier? Likely reviewers would be me, Oliver, Filip or Geoff, feel free to cc. cheers, G. ___ webkit-dev mailing list

Re: [webkit-dev] …Inlines.h vs …InlineMethods.h

2012-11-05 Thread Gavin Barraclough
These rules generally look great. One suggestion: On Nov 5, 2012, at 8:47 AM, Geoffrey Garen wrote: (5) Adopt the convention that any function that is not as trivial as int x() { return m_x; } moves out of the class declaration. How about we simplify this slightly to: (5) Adopt the

Re: [webkit-dev] Feature announcement: Web VHS API

2013-04-01 Thread Gavin Barraclough
On Apr 1, 2013, at 12:36 PM, Glenn Adams wrote: correction... NTSC = Never The Same Color (twice) How do we intend to implement this? – any pseudo random behaviour needs to be cryptographically secure to avoid risking an information leak here. G.

Re: [webkit-dev] For your consideration: Naming scheme for fooIfExists/ensureFooclearStyleResolver

2013-06-19 Thread Gavin Barraclough
On Jun 18, 2013, at 10:16 PM, Ryosuke Niwa wrote: On Tue, Jun 18, 2013 at 7:20 PM, Simon Fraser wrote: On Jun 18, 2013, at 7:11 PM, Darin Adler wrote: On Jun 18, 2013, at 7:05 PM, Ryosuke Niwa wrote: Why don't we

Re: [webkit-dev] For your consideration: Naming scheme for fooIfExists/ensureFoo

2013-06-19 Thread Gavin Barraclough
I find ‘requireStyleResolver()’ a little confusing. My first expectation is often that a method is an imperative command on the receiver, so I first read 'requireStyleResolver()’ as mandating that the document now requires a StyleResolver, rather than referring to the need of the caller. In a

Re: [webkit-dev] Pepper and NaCl supporting (prototype)

2013-07-13 Thread Gavin Barraclough
On Jul 12, 2013, at 9:59 PM, Jake wrote: getting on your standards soapbox OOI standards conformance is a WebKit project goal. ___ webkit-dev mailing list

Re: [webkit-dev] Uint8ClampedArray: subtype of Uint8Array or not? (Was: Heads up: large typed array rewrite)

2013-08-14 Thread Gavin Barraclough
The spec ( says Constructors: None”, looks like FireFox is right, we should probably just remove this. G. On Aug 14, 2013, at 12:34 AM, Filip Pizlo wrote: And on a similar note: ArrayBufferView. What's that all about?

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Gavin Barraclough
I’m a bit of a luddite and edit my change log entries by hand. The old format is more amenable to this, the new format is a regression. cheers, G. On Aug 21, 2013, at 2:25 PM, Ryosuke Niwa wrote: On Wed, Aug 21, 2013 at 2:04 PM, Ryosuke Niwa wrote: Hi, I

Re: [webkit-dev] [JavaScriptCore] Is property attribute ReadOnly working as intended here?

2013-12-02 Thread Gavin Barraclough
On Dec 2, 2013, at 10:53 AM, Geoffrey Garen wrote: Hi Alexei. To my knowledge, an object's prototype is consulted when a property is not found on the object itself. Any new property is written to the object, never its prototype. That’s not quite right. The prototype

[webkit-dev] Removing PAGE_VISIBILITY_API compile guard

2014-01-22 Thread Gavin Barraclough
Hi, This feature is now stable I think this is enabled on all ports, I plan to remove the #ifdefs. cheers, G. ___ webkit-dev mailing list

Re: [webkit-dev] EFL EWS Bot output

2014-02-05 Thread Gavin Barraclough
Yay! – that was annoying, thank you for the fix Ossy! On Feb 5, 2014, at 12:29 AM, Osztrogonác Csaba wrote: Hi, Fix already landed in ;) Ossy Gyuyoung Kim írta: Hello Oliver, I'm really sorry about the inconvenience to you.

Re: [webkit-dev] Removing PAGE_VISIBILITY_API compile guard

2014-06-20 Thread Gavin Barraclough
Balazsfalvi Gavin Barraclough wrote: Hi, This feature is now stable I think this is enabled on all ports, I plan to remove the #ifdefs. cheers, G. ___ webkit-dev mailing list

Re: [webkit-dev] Swift in WebKit

2014-07-28 Thread Gavin Barraclough
On Jul 28, 2014, at 12:47 PM, David Farler wrote: - Swift is a fully supported, albeit new, language starting in Xcode 6. I think you missed a word off the end of this sentence – Swift support is available in Xcode 6 beta. ;-) Too soon. G.

Re: [webkit-dev] Pattern for singleton classes instance getters

2015-01-28 Thread Gavin Barraclough
Gotta say, ‘singleton’ seems like a really good name for singletons. G. On Jan 28, 2015, at 7:06 PM, Filip Pizlo wrote: This is shorter: Class::singleton() It's also more consistent with the rest of our style (we usually don't put get in getter names). -Filip On

Re: [webkit-dev] WebCore/platform standalone library

2015-03-22 Thread Gavin Barraclough
On Mar 22, 2015, at 4:35 AM, Maciej Stachowiak wrote: Web Abstraction Toolbox (it’s hard to tell the difference between wat and WTF sometimes…) +1 ___ webkit-dev mailing list

Re: [webkit-dev] Proposal for serializing alpha channel values; request for algorithm help

2015-11-02 Thread Gavin Barraclough
> On Nov 1, 2015, at 7:40 PM, Darin Adler wrote: > > 3) Can you help me come up with a super-efficient algorithm to do this > serialization? Table lookup? FP conversion code is hard, and this is a relatively small number of strings. You could also flatten all the strings

Re: [webkit-dev] Proposal for serializing alpha channel values; request for algorithm help

2015-11-02 Thread Gavin Barraclough
> On Nov 1, 2015, at 7:40 PM, Darin Adler wrote: > > 3) Can you help me come up with a super-efficient algorithm to do this > serialization? Oh – I guess if you just store the fractions as BCD & unpack you can get the table size down to 512 bytes. If you decide against

[webkit-dev] The WebKit tree is OPEN!

2016-11-09 Thread Gavin Barraclough
Hi folks, We’re back in action! – we should have enough of our infrastructure up to keep the build green & guard against regressions, so the repository is open again to commits. We’d really like to minimize broken builds over the next day as any backlog of patches is being landed. We can all