[webkit-dev] Test conversion to use W3C testharness.js

2012-03-09 Thread Jacob Goldstein
I recently uploaded a patch to https://bugs.webkit.org/show_bug.cgi?id=80709 which converted an existing JavaScript regions parsing test to use the W3C testharness.js in place of js-test-pre.js/js-test-post.js. This patch also places testharness.js and a WebKit-specific testharnessreport.js

Re: [webkit-dev] Test conversion to use W3C testharness.js

2012-03-09 Thread Jacob Goldstein
...@webkit.orgmailto:rn...@webkit.org Date: Fri, 9 Mar 2012 14:37:18 -0800 To: Jacob Goldstein jac...@adobe.commailto:jac...@adobe.com Cc: webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Test conversion to use

Re: [webkit-dev] Test conversion to use W3C testharness.js

2012-03-09 Thread Jacob Goldstein
On Fri, Mar 9, 2012 at 3:19 PM, Jacob Goldstein jac...@adobe.com wrote: LayoutTests/resources is fine with me ­ that was the location I considered using originally and only moved them to LayoutTests/fast/js/resources because that is where js-test-pre and ­post are. I'll upload a new patch

Re: [webkit-dev] Test conversion to use W3C testharness.js

2012-03-09 Thread Jacob Goldstein
:before to put the word PASS at the beginning of the line for each subtest? Adam On Fri, Mar 9, 2012 at 3:51 PM, Jacob Goldstein jac...@adobe.com wrote: I replied to your comment in the bug, but will also copy below - I understand your concern. Some of this is user defined, and the output

Re: [webkit-dev] Test conversion to use W3C testharness.js

2012-03-09 Thread Jacob Goldstein
with the next couple words. Having spaces between the words would address my concern. Thanks! Adam 2012/3/9 Jacob Goldstein jac...@adobe.com: Is your concern that the Pass is not in all caps? The current output looks like this: Result Test Name Message PasstestParse

Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite)

2012-04-11 Thread Jacob Goldstein
+1 on not introducing new pixel tests and allowing someone other than the test author to create the -expected file. We may also be able to streamline some of this process by implementing some helper scripts. Ultimately, someone will still have to review new files manually, but scripts should be

Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite)

2012-04-11 Thread Jacob Goldstein
@lists.webkit.org Subject: Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite) On Wed, Apr 11, 2012 at 3:52 PM, Jacob Goldstein jac...@adobe.commailto:jac...@adobe.com wrote: +1 on not introducing new pixel tests and allowing someone other than the test author to create the -expected file. We may

Re: [webkit-dev] Handling failing reftests

2012-04-12 Thread Jacob Goldstein
Isn't the goal of writing a ref test that it is not platform specific? From: Ryosuke Niwa rn...@webkit.orgmailto:rn...@webkit.org Date: Thu, 12 Apr 2012 12:29:42 -0700 To: Ojan Vafai o...@chromium.orgmailto:o...@chromium.org Cc: Dirk Pranke dpra...@chromium.orgmailto:dpra...@chromium.org, WebKit

Re: [webkit-dev] Handling failing reftests

2012-04-12 Thread Jacob Goldstein
...@webkit.orgmailto:rn...@webkit.org Date: Thu, 12 Apr 2012 13:43:26 -0700 To: Jacob Goldstein jac...@adobe.commailto:jac...@adobe.com Cc: Ojan Vafai o...@chromium.orgmailto:o...@chromium.org, Dirk Pranke dpra...@chromium.orgmailto:dpra...@chromium.org, WebKit Development webkit-dev

[webkit-dev] Process for importing third party tests

2012-04-23 Thread Jacob Goldstein
At the recent WebKit Contributors Meeting, a process was drafted for importing third party tests into WebKit. I created a wiki page that captures the process that we came up with here: http://trac.webkit.org/wiki/ImportingThirdPartyTests We'd like to get more input from the community on all

[webkit-dev] Importing W3C tests to webkit

2012-05-23 Thread Jacob Goldstein
At the WebKit contributor's meeting in April, we discussed a process for importing third party tests into the WebKit repository (specifically, from the W3C test repository). I documented the process that we came up with at the meeting on the WebKit wiki, here:

Re: [webkit-dev] Importing W3C tests to webkit

2012-05-23 Thread Jacob Goldstein
I agree. If nothing else, getting W3C tests into the WebKit repository will help catch regressions. From: Ryosuke Niwa rn...@webkit.orgmailto:rn...@webkit.org To: Jacob Goldstein jac...@adobe.commailto:jac...@adobe.com Cc: WebKit Development webkit-dev@lists.webkit.orgmailto:webkit-dev

Re: [webkit-dev] Importing W3C tests to webkit

2012-05-23 Thread Jacob Goldstein
Dirk, my apologies, I was on travel the week you replied and missed your message. I found it and will review / update now. On 5/23/12 1:25 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, May 23, 2012 at 11:56 AM, Ryosuke Niwa rn...@webkit.org wrote: As I have said in the past, we should

Re: [webkit-dev] Importing W3C tests to webkit

2012-05-23 Thread Jacob Goldstein
On 5/23/12 2:30 PM, Maciej Stachowiak m...@apple.com wrote: On May 23, 2012, at 2:16 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, May 23, 2012 at 1:41 PM, Ryosuke Niwa rn...@webkit.org wrote: The only sane argument I've heard so far to gate pixel tests is that the correctness of

[webkit-dev] testharness Wiki page added

2012-05-31 Thread Jacob Goldstein
I added the following Wiki page to provide some information on testharness.js (the JavaScript framework from W3C recently landed in WebKit): http://trac.webkit.org/wiki/Writing%20testharness%20Tests I also updated the text under Writing JavaScript-based DOM only test cases on this page

Re: [webkit-dev] We should rename layoutTestController to testController

2012-05-31 Thread Jacob Goldstein
On 5/31/12 11:56 AM, Darin Adler da...@apple.com wrote: I am thinking we should rename layoutTestController to testController. Or if you don¹t like that name, maybe testHarness or some even better name. testHarness is probably not a good choice as the W3C JavaScript framework that recently

Re: [webkit-dev] testharness Wiki page added

2012-05-31 Thread Jacob Goldstein
wrote and maintains the W3C testharness, would likely be open to suggestions for improvement if there is anything specific that we want to change. From: Maciej Stachowiak m...@apple.commailto:m...@apple.com To: Jacob Goldstein jac...@adobe.commailto:jac...@adobe.com Cc: WebKit Development

Re: [webkit-dev] testharness Wiki page added

2012-05-31 Thread Jacob Goldstein
Actually, I misspoke, it's not Peter Linss who maintains testharness, it's James Graham. From: Jacob Goldstein jac...@adobe.commailto:jac...@adobe.com To: Maciej Stachowiak m...@apple.commailto:m...@apple.com Cc: WebKit Development webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org

Re: [webkit-dev] testharness Wiki page added

2012-05-31 Thread Jacob Goldstein
On Thu, May 31, 2012 at 11:18 AM, Jacob Goldstein jac...@adobe.commailto:jac...@adobe.com wrote: I added the following Wiki page to provide some information on testharness.js (the JavaScript framework from W3C recently landed in WebKit): http://trac.webkit.org/wiki/Writing%20testharness%20Tests

Re: [webkit-dev] testharness Wiki page added

2012-06-01 Thread Jacob Goldstein
On 5/31/12 7:55 PM, Maciej Stachowiak m...@apple.commailto:m...@apple.com wrote: On May 31, 2012, at 5:51 PM, Jacob Goldstein jac...@adobe.commailto:jac...@adobe.com wrote: I haven't found that to be the case for the tests I have written for each suite, the output from testharness can

Re: [webkit-dev] testharness Wiki page added

2012-06-01 Thread Jacob Goldstein
testharness for the assert that appears on line 36, as follows: test(function() {assert_equals(oAnchor.getAttribute('href'), value, Optional debug info.)}, description); On 6/1/12 2:40 PM, Jacob Goldstein jac...@adobe.commailto:jac...@adobe.com wrote: On 5/31/12 7:55 PM, Maciej Stachowiak m

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

2012-06-11 Thread Jacob Goldstein
On 6/11/12 11:11 AM, Alexis Menard alexis.men...@openbossa.org wrote: On Mon, Jun 11, 2012 at 3:09 PM, Simon Fraser simon.fra...@apple.com wrote: I think imported tests should be outside of LayoutTests/fast. I agree a dedicated folder seems more appropriate. My two cents. Simon On Jun 11,

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

2012-06-11 Thread Jacob Goldstein
On 6/11/12 2:24 PM, Ryosuke Niwa rn...@webkit.orgmailto:rn...@webkit.org wrote: On Mon, Jun 11, 2012 at 2:21 PM, Jacob Goldstein jac...@adobe.commailto:jac...@adobe.com wrote: Can we just create an imported-w3c folder at the same level as LayoutTests? You mean at trunk? I don't think

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

2012-06-11 Thread Jacob Goldstein
On 6/11/12 2:37 PM, Ryosuke Niwa rn...@webkit.orgmailto:rn...@webkit.org wrote: On Mon, Jun 11, 2012 at 2:33 PM, Dirk Pranke dpra...@chromium.orgmailto:dpra...@chromium.org wrote: Technically, it does (at least NRWT does), but I wouldn't recommend it. NRWT is designed to allow tests to live in

[webkit-dev] Building on Mountain Lion

2012-07-25 Thread Jacob Goldstein
Has any tried to build WebKit on Mountain Lion? I just attempted with a new install of Mountain Lion and Xcode 4.4 and the build keeps failing while trying to compile AlternativeTextUIController. If anyone has thoughts as to why this could be, please let me know.

Re: [webkit-dev] Building on Mountain Lion

2012-07-25 Thread Jacob Goldstein
On 7/25/12 2:21 PM, Mark Rowe mr...@apple.com wrote: On 2012-07-25, at 14:15, Jacob Goldstein jac...@adobe.com wrote: Has any tried to build WebKit on Mountain Lion? I just attempted with a new install of Mountain Lion and Xcode 4.4 and the build keeps failing while trying to compile