[webkit-dev] CSS Regions and multi-range Selection

2013-07-25 Thread Javier Fernandez
hi, During the last Contributors Meeting there was a discussion about how to improve the Selection when using CSS Regions. These are some of the conclusions got at that meeting: * multi-range selection would help with this. * come up with a better way to do selection that would allow a

[webkit-dev] Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?

2013-07-31 Thread Javier Fernandez
Hi, While looking into the bug #118595 I've found out that the root cause was an arithmetic overflow during the layout process, at least in the case of the WebKitGtk+ port, but I guess other ports have similar root cause. Notice that webkitgtk+ port enables the SUBPIXEL-LAYOUT by default. Later,

Re: [webkit-dev] Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?

2013-08-01 Thread Javier Fernandez
Hi, On 31/07/13 22:40, Ryosuke Niwa wrote: Can't we encounter the same bug if we you multiplied the same height by 64 even if the sub pixel layout is not turned off? Or is there some parser and other component that prevents such an overflow to happen? For the specific case of max-height,

Re: [webkit-dev] Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?

2013-08-01 Thread Javier Fernandez
Hi, On 31/07/13 22:35, Benjamin Poulain wrote: It looks to me like it is a good idea on the long term to have saturated arithmetic enabled when you have subpixel layout. I believe only GTK and EFL enable subpixel layout at the moment(?). You can probably lead the way and mature the feature

Re: [webkit-dev] Do we need subpixel layout (Was: Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?)

2013-08-01 Thread Javier Fernandez
Hi, On 01/08/13 00:26, Balazs Kelemen wrote: I think first we should clarify some more basic questions about subpixel layout. 1. Is it actually mantained? 2. Do any port really need it? Please correct me if these questions are too obvious or have been resolved before. Note that I am not a

Re: [webkit-dev] Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?

2013-09-06 Thread Javier Fernandez
Hi, On 07/31/2013 10:40 PM, Ryosuke Niwa wrote: Can't we encounter the same bug if we you multiplied the same height by 64 even if the sub pixel layout is not turned off? Or is there some parser and other component that prevents such an overflow to happen? I've been debugging and

Re: [webkit-dev] Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?

2013-09-09 Thread Javier Fernandez
Hi, On 09/06/2013 10:12 PM, Ryosuke Niwa wrote: Thanks for the analysis! Perhaps we should merge two build flags and turn on the saturated arithmetic whenever subpixel is enabled. I think that would be the ideal solution, since it has been probed enabling SUPIXEL_LAYOUT only implies actual

Re: [webkit-dev] Blog post on the contributor's meeting?

2014-04-24 Thread Javier Fernandez
Hi, On 04/24/2014 08:00 PM, Bem Jones-Bey wrote: In addition, there are many sessions from the contributor meeting that don't have notes or anything on them on the meeting page[2]. If you have anything you could add for any of the sessions, that would be very useful. I think it's a good

[webkit-dev] Enabling CSS Grid Layout runtime flag by default

2014-04-25 Thread Javier Fernandez
Hi, As we discussed in the last WebKit Contributors Meeting, I think it would be useful to have the runtime feature enabled by default. We already have a compilation flag since r164659 [1], so enabling the runtime flag by default would make easier for developers to try out and test the new

Re: [webkit-dev] Blog post on the contributor's meeting?

2014-05-01 Thread Javier Fernandez
Hi, On 04/26/2014 12:22 AM, Benjamin Poulain wrote: It would be redundant to post the same information on the WebKit blog. In my opinion, your blog post is already a good summary. I agree, but anyway, as I promised, this is mine about my experience in the meeting.

[webkit-dev] Selection and new layout models

2014-05-08 Thread Javier Fernandez
Hi, During the last WebKit Contributors Meeting we had a discussion about how to improve Selection in the new layout models. We agreed that it would be great to have a repository where we can share use cases to study the main Selection issues. At Igalia we have been working on Selection for CSS

[webkit-dev] CSS Grid Layout status review

2014-08-01 Thread Javier Fernandez
Hi all, It's been a while since Igalia started contributing to the development of the CSS Grid Layout spec in WebKit (enabled in the nightly builds since May) and we'd like to report about the implementation status to gather feedback from the community (comments, issues, questions, etc.). CSS

Re: [webkit-dev] CSS Grid Layout status review

2014-08-01 Thread Javier Fernandez
Hi Benjamin, On 08/02/2014 12:53 AM, Benjamin Poulain wrote: Do you know if Fuzzinator covers CSS Grid Layout? I don't think so. It might be a good idea to add support for Grid Layout. Could you give me some directions on how to do it ? -- javi

Re: [webkit-dev] Proposal: Remove ENABLE(SUBPIXEL_LAYOUT)

2014-08-18 Thread Javier Fernandez
Hi, On 08/18/2014 08:14 PM, Zalan Bujtas wrote: Hi Everyone, I’d like to propose removing ENABLE(SUBPIXEL_LAYOUT), as every port has it enabled. As part of this activity, I am planning to enable SATURATED_LAYOUT_ARITHMETIC by default. Thanks, Zalan. I've already opened a bug to address this

Re: [webkit-dev] MathML layout refactor proposal

2015-12-14 Thread Javier Fernandez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 12/14/2015 08:03 PM, Frédéric WANG wrote: > Le 14/12/2015 19:39, Zalan Bujtas a écrit : >> It’s great to hear that MathML is getting some proper cleanup. I >> think the proposal sounds good and I am looking forward to the >> patches. >> >>

Re: [webkit-dev] Improve selection with floats

2017-09-13 Thread Javier Fernandez
, Javier Fernandez wrote: > Hi, > > I've been working lately on some cases where selection shows an > unpredictable behavior when applied to cases with float elements; > basically, selection boundaries jump when dragging over floats. I've > found this old bug (https://webkit.org/b/10177

[webkit-dev] Improve selection with floats

2017-09-07 Thread Javier Fernandez
Hi, I've been working lately on some cases where selection shows an unpredictable behavior when applied to cases with float elements; basically, selection boundaries jump when dragging over floats. I've found this old bug (https://webkit.org/b/101771) which described some of these cases. I've

[webkit-dev] Unified sources build errors when adding new source files

2017-11-21 Thread Javier Fernandez
Hi, The patch at https://bugs.webkit.org/show_bug.cgi?id=179633 it's just a refactoring of the Grid Layout code which defines a new namespace with a bunch of Grid related utility functions, only used from the RenderGrid and GridTrackSizingAlgorithm classes. The patch adds a new entry to the

[webkit-dev] Removal of the Grid Layout runtime flag

2018-02-02 Thread Javier Fernandez
Hi, The CSS Grid Layout feature is shipped and enabled by default since Safari 10.1. It's also shipped by default in Chrome, Firefox and Edge. Do we still need the 'cssGridLayoutEnabled' runtime flag ? In my opinion it's safe to remove the flag and the conditional code we have in the CSS parser

Re: [webkit-dev] Removal of the Grid Layout runtime flag

2018-03-09 Thread Javier Fernandez
. Thanks, -- Javier On 03/02/18 00:26, Javier Fernandez wrote: > Hi, > > The CSS Grid Layout feature is shipped and enabled by default since > Safari 10.1. It's also shipped by default in Chrome, Firefox and Edge. > > Do we still need the 'cssGridLayoutEnabled' runtime flag ? &g