[webkit-dev] Testing XHR

2010-09-20 Thread Luke Macpherson
WebKit (or at least Chrome) is currently failing a bunch opera's tests located at: http://tc.labs.opera.com/apis/XMLHttpRequest/ It seems that it would be a good idea for us to make use of these tests in WebKit, so I was thinking of importing them into the codebase. This raises the question: Shoul

Re: [webkit-dev] OSX build break after system update

2010-11-16 Thread Luke Macpherson
This is preventing me from building. Is there a solution that doesn't require signing up for an Apple ID? On Fri, Oct 29, 2010 at 3:17 AM, Tony Gentilcore wrote: > > > On Wed, Oct 27, 2010 at 10:11 PM, Eric Seidel wrote: >> >> Can we just include the headers in WebKit? >> >> Or find some way to

Re: [webkit-dev] Followup to the WML discussion

2011-07-12 Thread Luke Macpherson
As a follow-up to this question, should Webkit support WCSS now that WML has been removed? There has been a patch sitting around for a while waiting to do this here: https://bugs.webkit.org/show_bug.cgi?id=59786 On Sun, Apr 24, 2011 at 6:22 PM, Adam Barth wrote: > Hi webkit-dev, > > To make prog

Re: [webkit-dev] Followup to the WML discussion

2011-07-17 Thread Luke Macpherson
Does anyone actually use XHTML-MP? On Wed, Jul 13, 2011 at 10:51 AM, Alexey Proskuryakov wrote: > > 12.07.2011, в 16:42, Luke Macpherson написал(а): > >> As a follow-up to this question, should Webkit support WCSS now that >> WML has been removed? > > > There was a

Re: [webkit-dev] Eliminate potential null pointer dereference?

2012-04-20 Thread Luke Macpherson
Changing the two loops to use the same form improves readability because it makes it clear that the form of iteration is the same between the two loops. This is a very common C pattern when dealing with lists where the behavior changes after an element is encountered. The pattern is used instead of

Re: [webkit-dev] Eliminate potential null pointer dereference?

2012-04-20 Thread Luke Macpherson
On Fri, Apr 20, 2012 at 11:07 AM, Ryosuke Niwa wrote: > Is the code reachable? It's quite possible that the code is unreachable and > therefore there is no way to hit that crash. Without a test, we can't answer > that question. That is not rationally true. A test case can show that there is a cod

[webkit-dev] Feature Announcement: CSS Variables (behind ENABLE_CSS_VARIABLES flag)

2012-05-13 Thread Luke Macpherson
Per http://www.webkit.org/coding/adding-features.html I'm working on adding CSS Variable support to WebKit. You can see the specification here: http://www.w3.org/TR/css-variables/ The patch implements a -webkit prefixed syntax of that defined by that spec. The WIP patches can be found here: https