Re: [webkit-dev] Moving to Git?

2012-03-09 Thread noam . rosenthal
On Mar 9, 2012, at 1:43 PM, ext Maciej Stachowiak wrote: It sounds like avoiding use of git-svn is the big benefit to git users and perhaps the reason this topic periodically comes up. Can anyone spell out in more detail the benefits of using straight git instead of git-svn? My main pain

[webkit-dev] [CoordinatedGraphics] bugs and what they mean

2012-08-31 Thread noam . rosenthal
Hello Recently people have expressed confusion about bug reports in bugzilla that deal with the coordinated graphics system. I wanted to help a bit with the confusion. The coordinated graphics system was contributed gradually by Qt in the last year or so, and is documented here:

Re: [webkit-dev] ANGLE on QNX / non-x11 unixoids

2012-09-04 Thread noam . rosenthal
A On Sep 4, 2012, at 8:34 AM, ext Konstantin Tokarev annu...@yandex.ru wrote: To get it compiling, I had to patch ANGLE source code and Simon Hausmann told me he is not comfortable in reviewing these patches. So here I am asking for how to proceed. Should I first try to upstream these

Re: [webkit-dev] Is there a rule to use UNUSED_PARAM ?

2012-10-01 Thread noam . rosenthal
How about ASSERT_USING and ASSERT_WITH_MESSAGE_USING? If we use a variable in an assert it's no longer unused… e.g. ASSERT_USING(timer, timer == m_resumeTimer); On Oct 1, 2012, at 6:17 PM, ext Mike Lawther mikelawt...@google.commailto:mikelawt...@google.com wrote: ASSERT_WITH_OTHERWISE_UNUSED.

[webkit-dev] New WebKit Reviewer: Caio Marcelo de Oliveira Filho

2012-10-08 Thread noam . rosenthal
I am pleased to announce that Caio (@cmarcelo) is now a WebKit reviewer. Caio has been working in many areas in the past years, starting with focus on the Qt port with improvements to the Qt/JS bridge, font test results and render-theme. More recently has also work on the UndoManager and other

Re: [webkit-dev] r- your own patches [was: Re: RenderArena: Teaching an old dog new tricks]

2012-11-16 Thread noam . rosenthal
From: ext Ryosuke Niwa rn...@webkit.orgmailto:rn...@webkit.org r+ and r- flags are supposed to be set only by reviewers. If you wanted to withdraw your patch from the review queue, then you should be clearing r? flag, instead of setting r-. If you’re uploading a WIP patch, then it should

Re: [webkit-dev] Implement threaded model of Coordinated Graphics

2012-11-16 Thread noam . rosenthal
Slava, I think the new proposal is about threading in the web process, not in the UI process like we do in Qt. I've posted some comments on the meta bug, thank you for the heads up on the mailing list! No'am From: ext Vyacheslav Ostapenko osta...@gmail.commailto:osta...@gmail.com Date: Friday,

Re: [webkit-dev] Adding Web MIDI API support to WebCore

2013-01-19 Thread noam . rosenthal
(Resending to list, having some email issues…) From: ext Maciej Stachowiak m...@apple.commailto:m...@apple.com OK, but - sending low-level MIDI commands in binary form is extremely unlikely to be the most effective way to get music out of your sound card. While in the past, games or audio

Re: [webkit-dev] RGBA8 and BGRA8 formats in WebKit

2013-01-22 Thread noam . rosenthal
I would say that the right way to go about improving pixel transfer (which is what you're trying to do, I believe...) is with OS-provided graphics surfaces; On embedded systems those are usually provided and there are of course solutions for windows and Mac. When using graphics surfaces, you

[webkit-dev] Peripheral ports (was Re: WebKit Wishes)

2013-01-31 Thread noam . rosenthal
From: ext Eric Seidel e...@webkit.orgmailto:e...@webkit.org I wish we didn’t have to worry about platforms we couldn’t test. It can’t be the job of the core maintainers to care about all the peripheral ports which contribute very little core code. Our code needs to be structured in such a

Re: [webkit-dev] WebKit Wishes

2013-02-03 Thread noam . rosenthal
On 2/3/13 7:46 PM, ext Maciej Stachowiak m...@apple.com wrote: If you're asking about phasing it out entirely, we don't have any immediate plans to deprecate or remove the WebKit1 mac API. There are quite a few Apple and third-party apps using it, and WebKit2 is not even public API on Mac OS X

Re: [webkit-dev] WebKit Wishes

2013-02-03 Thread noam . rosenthal
On 2/3/13 11:12 PM, ext Maciej Stachowiak m...@apple.com wrote: Maybe the problem is less about the WK1 API layer and more about WebCore/platform. I'm sure that's one problem, but I am still curious what Eric had in mind. Yes, me too, and I don't mean to hijack that conversation :) In many

[webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread noam . rosenthal
Hellos we don't currently have a solution in webkit's test infrastructure for testing animations on the fly, or in general for testing multiple image results in the same test. (If this was discussed before and I'm unaware of that discussion, please stop me here...) This is because ImageDiff

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread noam . rosenthal
From: webkit-dev-boun...@lists.webkit.org [webkit-dev-boun...@lists.webkit.org] on behalf of ext Robert Kroeger [rjkro...@chromium.org] How would the test wait for the animation to happen? Tests that use timeouts seem more likely to be flaky from what

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread noam . rosenthal
From: ext Ryosuke Niwa rn...@webkit.orgmailto:rn...@webkit.org I'd like to propose a solution, and would welcome some feedback on whether it's a good one... The idea is that you would be able to programatically retrieve the current snapshot into a canvas ImageData, and then compare the pixel

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-09 Thread noam . rosenthal
From: ext Benjamin Poulain benja...@webkit.orgmailto:benja...@webkit.org Date: Saturday, February 9, 2013 12:52 AM To: Noam Rosenthal noam.rosent...@nokia.commailto:noam.rosent...@nokia.com Cc: rn...@webkit.orgmailto:rn...@webkit.org rn...@webkit.orgmailto:rn...@webkit.org, webkit-dev

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-09 Thread noam . rosenthal
From: ext Benjamin Poulain benja...@webkit.orgmailto:benja...@webkit.org This is the situation I am afraid with a solution where pixels would be evaluated from JavaScript. You can test, but you lack visibility why something is correct or incorrect. Text tests, ref-tests and pixel tests have a

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-09 Thread noam . rosenthal
free :) Noam From: ext Benjamin Poulain benja...@webkit.orgmailto:benja...@webkit.org Date: Saturday, February 9, 2013 10:57 AM To: Noam Rosenthal noam.rosent...@nokia.commailto:noam.rosent...@nokia.com Cc: rn...@webkit.orgmailto:rn...@webkit.org rn...@webkit.orgmailto:rn...@webkit.org, webkit-dev

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-09 Thread noam . rosenthal
Oops, forgot to reply to the list. From: Noam Rosenthal noam.rosent...@nokia.commailto:noam.rosent...@nokia.com From: ext Simon Fraser simon.fra...@apple.commailto:simon.fra...@apple.com The existing pauseAnimation DRT API can stop an animation mid-flight, to allow for reliable snapshotting. Why

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-13 Thread noam . rosenthal
From: ext Benjamin Poulain benja...@webkit.orgmailto:benja...@webkit.org Date: Thursday, February 14, 2013 8:07 AM To: Dongsung Huang luxte...@company100.netmailto:luxte...@company100.net Cc: webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-13 Thread noam . rosenthal
From: ext Benjamin Poulain benja...@webkit.orgmailto:benja...@webkit.org Date: Thursday, February 14, 2013 8:36 AM To: Noam Rosenthal noam.rosent...@nokia.commailto:noam.rosent...@nokia.com Cc: luxte...@company100.netmailto:luxte...@company100.net luxte...@company100.netmailto:luxte

[webkit-dev] CSS filter behavior change - what is our policy?

2013-03-14 Thread Noam Rosenthal
Hellos How do we go about rendering behavior changes that affect features that are enabled on shipping browsers? I'm specifically referring to http://trac.webkit.org/changeset/139770 The brightness filter is enabled by default on chrome and Safari if I remember correctly, and now pages that use

Re: [webkit-dev] CSS filter behavior change - what is our policy?

2013-03-14 Thread Noam Rosenthal
brightness and target both new browsers and currently shipping browsers? On Thu, Mar 14, 2013 at 9:07 PM, Noam Rosenthal n...@webkit.org wrote: I'm not so worried about existing content, as there's not that much of it and web developers can always adapt it, but unlike other bleeding edge features

Re: [webkit-dev] New web-facing canvas feature: opaque attribute

2013-03-15 Thread Noam Rosenthal
On Fri, Mar 15, 2013 at 9:19 AM, Gregg Tavares g...@google.com wrote: I don't understand the opposition to alpha You set colors in Canvas2d with rgb or rgba. That 'a' in rgba stands for alpha. You can set a global alpha for drawing with context.globalAlpha You read data from getImageData

Re: [webkit-dev] Current status of threaded compositor for WebKit Gtk

2013-04-15 Thread Noam Rosenthal
Replying from right address this time... On Mon, Apr 15, 2013 at 9:23 AM, Noam Rosenthal n...@webkit.org wrote: Thanks Gwang-Yoon Yes, I would like to get rid of TextureMapperImageBuffer, and we can do that once Qt-WebKit1 can move to the threaded compositor. I would like to use

Re: [webkit-dev] PSA: WebKit2 and DrawingAreaImpl

2013-10-02 Thread Noam Rosenthal
Thanks for the heads up, Anders I've created a bug for this, https://bugs.webkit.org/show_bug.cgi?id=122207 On Wed, Oct 2, 2013 at 3:19 AM, Anders Carlsson ander...@apple.com wrote: Hello, I just wanted to let everyone know that we (Apple) are moving away from DrawingAreaImpl and always

Re: [webkit-dev] The SrcN responsive images proposal

2013-11-07 Thread Noam Rosenthal
Designing this proposal around code formatting is a non-issue in my opinion and it surely didn't stop SVG from providing just one d attribute for path. Following the your logic, it should be d-N. Sure, path d=… is primarily meant to be written by software. Please don't try to use

Re: [webkit-dev] The SrcN responsive images proposal

2013-11-07 Thread Noam Rosenthal
On Fri, Nov 8, 2013 at 12:50 AM, Timothy Hatcher timo...@apple.com wrote: On Nov 7, 2013, at 2:43 PM, Tab Atkins Jr. jackalm...@gmail.com wrote: I'm pretty sure the argument is almost entirely around hand-authoring, where experience with style='' shows that lists-of-lists are bad. Until

Re: [webkit-dev] Help regarding rendering in webkit2 port of haiku

2019-06-10 Thread Noam Rosenthal
~ (reposting from webkit email) Hello! I suggest starting by learning one of the other ports - like GTK - how the whole flow works from the windowing system to WebCore to the graphics system. Read the code, run it in debug mode and put breakpoints, get those aha moments of how it all works

Re: [webkit-dev] Help regarding rendering in webkit2 port of haiku

2019-06-10 Thread Noam Rosenthal
On Mon, Jun 10, 2019 at 10:33 AM Adrien Destugues wrote: > On Mon, Jun 10, 2019 at 09:37:06AM +0300, Noam Rosenthal wrote: > > ~ (reposting from webkit email) > > Hi, > > Another limitation we hit on some websites is that it is not possible > for us to create too many dr

Re: [webkit-dev] Content-DPR: Image resolution optimization at CDN/transport layer

2019-11-11 Thread Noam Rosenthal
On Mon, Nov 11, 2019 at 12:13 AM Maciej Stachowiak wrote: > - Is there a specification for Content-DPR? All I could find in bugzila > and elsewhere is links to < > https://httpwg.org/http-extensions/client-hints.html>, which does not > mention Content-DPR at all). > In a nutshell, the spec is in

Re: [webkit-dev] Content-DPR: Image resolution optimization at CDN/transport layer

2019-11-12 Thread Noam Rosenthal
On Mon, Nov 11, 2019 at 10:13 PM Maciej Stachowiak wrote: > > > On Nov 11, 2019, at 4:37 AM, Noam Rosenthal wrote: > > > > On Mon, Nov 11, 2019 at 12:13 AM Maciej Stachowiak wrote: > >> - Is there a specification for Content-DPR? All I could find in bug

Re: [webkit-dev] Content-DPR: Image resolution optimization at CDN/transport layer

2019-11-12 Thread Noam Rosenthal
On Tue, Nov 12, 2019 at 3:28 AM Alexey Proskuryakov wrote: > > > 10 нояб. 2019 г., в 1:16 AM, Noam Rosenthal написал(а): > > Also, as a response to the view that this should be part of markup, I > would argue that those transparent decisions by the servers should not >

[webkit-dev] Content-DPR: Image resolution optimization at CDN/transport layer

2019-11-10 Thread Noam Rosenthal
Hola I would like to open a discussion that has started a few years back and has never reached a consensus: https://bugs.webkit.org/show_bug.cgi?id=145380 In a nutshell: content-dpr is a response-only header for images, that allows servers at transient layers (CDNs/proxies) to optimize images

Re: [webkit-dev] Content-DPR: Image resolution optimization at CDN/transport layer

2019-11-10 Thread Noam Rosenthal
On Sun, Nov 10, 2019 at 9:41 PM Maciej Stachowiak wrote: > > Is this header useful without the DPR client-hint? > Absolutely. A server/CDN can decide to serve an image with a particular content-dpr without knowing the client's actual DPR. > On Nov 10, 2019, at 1:16 AM, Noam Rose

[webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-02-26 Thread Noam Rosenthal
Hola I was approached by the Wikimedia foundation to implement the paint timing API for WebKit (yay). I think this is a good feature to have for webkit, and I wanted to hear thoughts about it before I begin. The feature was enabled in Chrome for quite a while, and is potentially very useful for

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-02-26 Thread Noam Rosenthal
On Wed, Feb 26, 2020 at 9:29 PM Maciej Stachowiak wrote: > I also suggest to start with "first-paint" as it's perhaps a bit less > "internal" than FCP, and can provide a performance-regression metric with a > lesser degree of risk regarding exposing internals / privacy. > > > First paint that’s

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-02-26 Thread Noam Rosenthal
(resending from correct address) On Wed, Feb 26, 2020 at 8:08 PM Maciej Stachowiak wrote: > > Some quick comments: > > the definition of First Contentful Paint here in the spec: < > https://www.w3.org/TR/paint-timing/#sec-terminology> does not match the > definition stated at

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-03-01 Thread Noam Rosenthal
> > > The first visually non-empty milestone almost always happens way before > this point. The above is just a fallback to make sure we eventually hit > this milestone. For example, if a document is totally blank even after > loading the document and all subresources, we want to paint it instead

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-03-01 Thread Noam Rosenthal
On Mon, Mar 2, 2020 at 12:21 AM Maciej Stachowiak wrote: > > > On Mar 1, 2020, at 2:07 PM, Noam Rosenthal wrote: > > >> The first visually non-empty milestone almost always happens way before >> this point. The above is just a fallback to make sure we event

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-03-01 Thread Noam Rosenthal
On Mon, Mar 2, 2020 at 1:18 AM Maciej Stachowiak wrote: > > > On Mar 1, 2020, at 2:57 PM, Noam Rosenthal wrote: > > > > On Mon, Mar 2, 2020 at 12:21 AM Maciej Stachowiak wrote: > >> >> >> On Mar 1, 2020, at 2:07 PM, Noam Rosenthal wrote: >> >

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-03-01 Thread Noam Rosenthal
On Mon, Mar 2, 2020 at 2:37 AM Maciej Stachowiak wrote: > > > On Mar 1, 2020, at 4:19 PM, Noam Rosenthal wrote: > OK, to summarize what I got from this > - we want the spec and webkit painting to be as close as possible > - The spec needs to be clearer/less buggy

Re: [webkit-dev] Content-DPR: Image resolution optimization at CDN/transport layer

2020-03-04 Thread Noam Rosenthal
On Thu, Mar 5, 2020 at 4:24 AM Maciej Stachowiak wrote: > > >> There has been a lot of work done on the spec front since the comments > above, and I think we're ready for a re-review the state. > * The next pull request: https://github.com/whatwg/html/pull/5112 has > been thumbed up to make it

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-02-27 Thread Noam Rosenthal
On Thu, Feb 27, 2020 at 12:17 PM Yoav Weiss wrote: > > > On Wed, Feb 26, 2020 at 11:33 PM Ryosuke Niwa wrote: > >> >> I don't think we should do that. For starters, Chrome's painting strategy >> while loading a web page is very different from that of Safari / WebKit. We >> would freeze the

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-02-27 Thread Noam Rosenthal
On Thu, Feb 27, 2020 at 12:46 PM Noam Rosenthal wrote: > > > On Thu, Feb 27, 2020 at 12:17 PM Yoav Weiss wrote: > >> >> >> On Wed, Feb 26, 2020 at 11:33 PM Ryosuke Niwa wrote: >> >>> >>> I don't think we should do that. For starters, C

Re: [webkit-dev] Content-DPR: Image resolution optimization at CDN/transport layer

2020-03-02 Thread Noam Rosenthal
On Mon, Nov 11, 2019 at 10:13 PM Maciej Stachowiak wrote: > > > On Nov 11, 2019, at 4:37 AM, Noam Rosenthal wrote: > > > > On Mon, Nov 11, 2019 at 12:13 AM Maciej Stachowiak wrote: > >> - Is there a specification for Content-DPR? All I could find in bug

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-03-03 Thread Noam Rosenthal
On Tue, Mar 3, 2020 at 10:18 AM Ryosuke Niwa wrote: > Sorry for the delay. I had other other things to take care of first. > > Based on the discussion we had (between Maciej, Simon, Alan, and I), we > should take the following items into account for WebKit's first meaningful > paint heuristics:

Re: [webkit-dev] WebKit position on Paint Timing / (first paint, first contentful paint)

2020-03-03 Thread Noam Rosenthal
On Tue, Mar 3, 2020 at 10:36 AM Ryosuke Niwa wrote: > > By the way, do you know what the status / interests at Mozilla? Given > WebKit's painting / navigation behavior / implementation is still pretty > close to Blink, it would be a good idea to reach out to Mozilla to make > sure whatever in

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-05-11 Thread Noam Rosenthal
unds sensible. How do we go about doing that? > > I’d like to hear from others on maturity of the spec and readiness of the > code. > > - Maciej > > On May 11, 2020, at 11:44 AM, Noam Rosenthal wrote: > > Following the discussion with Simon in > https://bugs

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-05-12 Thread Noam Rosenthal
On Tue, May 12, 2020 at 10:28 AM Maciej Stachowiak wrote: > > > On May 11, 2020, at 9:53 PM, Noam Rosenthal wrote: > > > > On Tue, May 12, 2020 at 1:36 AM Maciej Stachowiak wrote: > >> >> I noticed from comments in one of the Radars that the patch may re

[webkit-dev] Suggesting to enable paint timing by default

2020-05-11 Thread Noam Rosenthal
Following the discussion with Simon in https://bugs.webkit.org/show_bug.cgi?id=78011 Since we have a pretty stable spec (https://w3c.github.io/paint-timing/), lots of passing web platform tests, other browser vendor support and a working implementation of first contentful paint, I am planning to

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-05-27 Thread Noam Rosenthal
Following up on this. > FOn Tue, May 12, 2020 at 10:28 AM Maciej Stachowiak wrote: > >> >> >> On May 11, 2020, at 9:53 PM, Noam Rosenthal wrote: >> >> >> >> On Tue, May 12, 2020 at 1:36 AM Maciej Stachowiak wrote: >> >>> >

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-07-13 Thread Noam Rosenthal
On Wed, May 27, 2020 at 12:04 PM Yoav Weiss wrote: > +Ryosuke Niwa +Alex Christensen > who were involved in the spec discussions. > > On Wed, May 27, 2020 at 10:29 AM Noam Rosenthal wrote: > >> >> >> Following up on this. >> >>> FOn Tue, May 1

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-07-13 Thread Noam Rosenthal
abled I have a patch for enabling it by default here: https://bugs.webkit.org/show_bug.cgi?id=211736 We mainly need to test that measuring paint timing doesn't (badly) influence loading performance. > > Cheers, > Keith > > On Jul 13, 2020, at 3:02 AM, Noam Rosenthal wrote: > &g

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-07-17 Thread Noam Rosenthal
On Thu, Jul 16, 2020 at 11:03 PM Keith Miller wrote: > Results appear to be neutral on the page load time benchmark, so you > should be good on that front. I don’t know who the best person to vet the > maturity of the code is though, sorry. > Thanks a lot Keith, I appreciate it! @Maciej