Re: [webkit-dev] chromium-cg-mac results

2012-01-04 Thread Stephen Chenney
5. Moving forward, reviewers and committers take care not to re-add expectations when committing pending patches. While I expect svn will warn in most cases, I doubt that it will catch everything. 6. Won't fix any bugs related to chromium-cg results. Stephen. On Wed, Jan 4, 2012 at 9:10 AM,

Re: [webkit-dev] Running v8 in the major platform ports (win and mac)

2012-01-31 Thread Stephen Chenney
The Chromium port uses v8 for all platforms. Is that not what you would like? Stephen. On Mon, Jan 30, 2012 at 7:41 PM, Ryan Ackley ryanack...@gmail.com wrote: I want to use Webkit for a project I'm working on but I would prefer the v8 JavaScript engine for a variety of reasons. I did see

Re: [webkit-dev] handling failing tests (test_expectations, Skipped files, etc.)

2012-04-10 Thread Stephen Chenney
There is a significant practical problem to turn the tree red and work with someone to rebaseline the tests. It takes multiple hours for some bots to build and test a given patch. That means, at any moment, you will have maybe tens and in some cases hundreds of failing tests associated with some

Re: [webkit-dev] Transformations precision: double - float

2012-05-21 Thread Stephen Chenney
Ideally WebKit would avoid casts by consistently using either double or floats everywhere a floating point representation is needed. I don't think it's as simple as adding a typedef, but maybe it is. In any event it would have to be spelled out in the style guide. My gut feeling is that floats

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-12 Thread Stephen Chenney
On Wed, Jul 11, 2012 at 6:07 PM, Alec Flett alecfl...@chromium.org wrote: I absolutely do not buy that the cost of keeping comments up to date and the cost of out-of-date comments outweighs the benefits - that has NEVER been my experience and if anything the benefits of comments grow as the

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-12 Thread Stephen Chenney
On Thu, Jul 12, 2012 at 3:44 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, Jul 12, 2012 at 10:53 AM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Jul 12, 2012 at 10:43 AM, Stephen Chenney schen...@chromium.org wrote: As several people have shown, it is quite easy to come up

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-13 Thread Stephen Chenney
On Thu, Jul 12, 2012 at 5:31 PM, Maciej Stachowiak m...@apple.com wrote: On Jul 12, 2012, at 1:47 PM, Stephen Chenney schen...@chromium.org wrote: On Thu, Jul 12, 2012 at 3:44 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, Jul 12, 2012 at 10:53 AM, Ryosuke Niwa rn...@webkit.org

Re: [webkit-dev] add NeedsRebaseline keyword to TestExpectations as a way to hande updating pixel tests?

2012-10-04 Thread Stephen Chenney
I also like this idea. I particularly like the side effect of making it clear when a patch is modifying a test result that is itself not necessarily up to date. I suggest a policy that says you must rebaseline a test before committing a patch that would change that test (if the test is marked as

Re: [webkit-dev] On returning mutable pointers from const methods

2012-10-25 Thread Stephen Chenney
I second the principle. I ran into this kind of code pattern recently in fonts and was unnerved by the thought of a mutable pointer emerging from a const method. I am not at all certain that we can simply make the change without some heavy refactoring. On the one hand, there are some long

Re: [webkit-dev] Int/FloatPoint and Int/FloatSize

2013-01-03 Thread Stephen Chenney
On Thu, Jan 3, 2013 at 3:14 PM, Peter Kasting pkast...@google.com wrote: On Thu, Jan 3, 2013 at 11:36 AM, Shawn Singh shawnsi...@chromium.orgwrote: Cons of making a separate vector class: - offsets are sometimes treated as relative point locations, and other times treated as vectors that

[webkit-dev] Chromium bugs marked as WontFix

2013-04-08 Thread Stephen Chenney
I am making a pass to mark Chromium-specific bugs as WontFix in WebKit while adding Chromium bugs as appropriate. This is generating lots of email, which is unfortunate but unavoidable. Should you get notification of a bug you care about, and wish to track it in Chromium, please go to crbug.com