Hi,
I'm new to webkit development, and I'd like to hear opinions about the
problems I met.
Now I'm trying to fix some old layout bugs, for example:
* white space preceding br (
https://bugs.webkit.org/show_bug.cgi?id=37261)
* relative font-size (https://bugs.webkit.org/show_bug.cgi?id=18413)
Thanks Dan for reply.
2010/6/2 Dan Bernstein m...@apple.com
Hi Xianzhu,
On Jun 1, 2010, at 9:37 PM, Xianzhu Wang wrote:
Hi,
I'm new to webkit development, and I'd like to hear opinions about the
problems I met.
Now I'm trying to fix some old layout bugs, for example:
* white space
,
Xianzhu
2010/6/2 Xianzhu Wang phnix...@gmail.com
Hi,
I'm new to webkit development, and I'd like to hear opinions about the
problems I met.
Now I'm trying to fix some old layout bugs, for example:
* white space preceding br (
https://bugs.webkit.org/show_bug.cgi?id=37261)
* relative
Please try 'run-layout-tests --help' to see the command line options of
run-layout-tests script.
The '--new-test-results' and '--reset-results' options will help you
generate the expected file.
You may also want to read http://trac.webkit.org/wiki/CreatingLayoutTests to
learn the different types
Hi, developers,
I'd really like my patches to be reviewed and landed. Could any
reviewer/commiter help me? The normal review/commit queue mechanisms aren't
suitable for the the patches because the layout-tests in them are almost
always out-dated.
Thanks,
Xianzhu
2010/8/1 Xianzhu Wang phnix
Hi,
I encountered a problem yesterday that all layout tests crashed on Mac Snow
Leopard.
DumpRenderTree produces the following output when run from command line:
$ time ./DumpRenderTree
2010-08-31 10:39:25.847 DumpRenderTree[26725:903] The requested plugin at
I think a different way works: hooking window.setTimeout,
window.setInterval, window.clearTimeout and window.clearInterval after
the page is loaded and before any script is run, like the following:
(function() {
var orgSetTimeout = window.setTimeout;
window.setTimeout = function(f, t) {
Hi, Adam,
I have recently worked on several issues about line breaking. Glad to hear
your plans. Actually I'm a bit tired of waiting for responses about the
issues (and about some other 'old' layout bugs). Your involvement would
greatly help resolve them.
What I have done on these issues are as
Hi,
I saw several layout tests (e.g. fast/dom/wrapper-classes.html) containing
code like the following:
iframe onload=frameLoaded() src=data:../iframe
script
function frameLoaded() {
..
}
/script
My question is: Is this kind of usage (referencing a later-defined function
in onload
Bug filed: https://bugs.webkit.org/show_bug.cgi?id=54942
I'll work on the bug this week.
2011/2/22 Darin Adler da...@apple.com
I misread this and thought it was the unload attribute on the body element,
not an iframe element.
My answer was completely wrong for an iframe element!
--
Hi,
KURL's relative URL behavior is different between Chromium and non-Chromium
ports, because Chromium ports use KURLGoogle.cpp instead of KURL.cpp.
In KURL(base, relative), when base is a not hierarchical, WebKit's
KURL::string() returns relative, while Chromium's returns an empty string.
The
2011/5/5 Brett Wilson bre...@chromium.org
On Wed, May 4, 2011 at 2:49 AM, Maciej Stachowiak m...@apple.com wrote:
On May 4, 2011, at 2:33 AM, Xianzhu Wang wrote:
Hi,
KURL's relative URL behavior is different between Chromium and
non-Chromium
ports, because Chromium ports use
Hi,
I found that DocumentLoader will hold m_mainResourceData during its whole
life. I'm wondering if this is necessary. I searched all callers of
DocumentLoader::mainResourceData() and DocumentLoader::mainResource() and
they seem all called before or just after the document is loaded. If we
On Tue, Aug 16, 2011 at 3:41 PM, Pavel Feldman pfeld...@chromium.orgwrote:
On Tue, Aug 16, 2011 at 11:20 AM, Xianzhu Wang phnix...@gmail.com wrote:
Hi,
I found that DocumentLoader will hold m_mainResourceData during its whole
life. I'm wondering if this is necessary. I searched all callers
Hi,
I want to skip several whole directories for chromium-android because of
the related features are not available. For example, plugin/.
1. Add the following line in platform/chromium/TestExpectations:
WONTFIX SKIP ANDROID : plugin
This works for most of the tests except for some tests that
Hi,
I uploaded a patch containing a new test that passes locally, but failed on
ews (https://bugs.webkit.org/show_bug.cgi?id=98100). I have no clue how it
failed. The test doesn't seem to be flaky running locally.
I remember in some cases the bot will give a zip file containing the
results of
to see if you can
reproduce the failure.
Adam
On Tue, Oct 2, 2012 at 5:12 PM, Xianzhu Wang wangxian...@chromium.org
wrote:
Hi,
I uploaded a patch containing a new test that passes locally, but failed
on
ews (https://bugs.webkit.org/show_bug.cgi?id=98100). I have no clue how
Hi,
In https://bugs.webkit.org/attachment.cgi?id=177534, I added the symbol
into Source/WebKit2/WebKit2.def.in trying to resolve the unresolved
external error of the previous patch (
https://bugs.webkit.org/attachment.cgi?id=177506), but the error still
occurred. I have read
On Tue, Dec 4, 2012 at 3:00 PM, Xianzhu Wang wangxian...@chromium.orgwrote:
Hi,
In https://bugs.webkit.org/attachment.cgi?id=177534, I added the symbol
into Source/WebKit2/WebKit2.def.in trying to resolve the unresolved
external error of the previous patch (
https://bugs.webkit.org
On Tue, Dec 4, 2012 at 4:09 PM, Xianzhu Wang wangxian...@chromium.orgwrote:
On Tue, Dec 4, 2012 at 3:00 PM, Xianzhu Wang wangxian...@chromium.orgwrote:
Hi,
In https://bugs.webkit.org/attachment.cgi?id=177534, I added the symbol
into Source/WebKit2/WebKit2.def.in trying to resolve
.def
was not updated from the changed WebKit2.def.in (I think otherwise there
should be many other unresolved external errors). However I don't know much
of Windows build and might be incorrect.
@bfulgham, could you confirm?
Thanks,
Xianzhu
On Tue, Dec 4, 2012 at 3:00 PM, Xianzhu Wang wangxian
Hi,
The question was raised when I was trying to reduce the test case and fix
wkbug.com/110895.
Consider the following case (we use 'auto' outline style to draw focus
rings):
div style=outline: red auto thin; width: 50px; height: 50px
div style=position: absolute; top: 100px; width: 100px;
)
doesn't work. It's quite common for the outline to originate on an object
that doesn't itself paint anything but has out-of-flow descendants that do.
dave
(hy...@apple.com)
On Feb 27, 2013, at 3:27 PM, Xianzhu Wang wangxian...@chromium.org
wrote:
The question is a bit out of the scope of the bug
Hi,
ScrollableArea::scrollSize() and ScrollableArea::maximumScrollPosition()
seem to return the same value if the parameters of the scrollbars are
updated. Can we remove one of them?
I think the benefits are:
- no redundancy;
- ScrollableArea could be independent on scrollbars;
-
On Mon, Apr 1, 2013 at 3:14 PM, Simon Fraser simon.fra...@apple.com wrote:
On Apr 1, 2013, at 2:47 PM, Xianzhu Wang wangxian...@chromium.org wrote:
Hi,
ScrollableArea::scrollSize() and ScrollableArea::maximumScrollPosition()
seem to return the same value if the parameters
25 matches
Mail list logo
