[webkit-dev] sunspider slow-down

2008-07-18 Thread Zoltan Herczeg
Hi webkit developers! I have recently updated my repository from revision 35033 to revision 35231, and noticed a great (20%) perfromance loss for sunspider. My test system has a Dual-core 2.2 GHz AMD opteron cpu. Since this is a big range, I have tried some other revisions as well to find out the

Re: [webkit-dev] sunspider slow-down

2008-07-18 Thread Zoltan Herczeg
Hi All! Thank you all for your replies! I narrowed the range between r35202 and r35208, and filled a new-bug report: bug 20097. Regards, Zoltan On Jul 18, 2008, at 8:00 AM, Zoltan Herczeg wrote: Hi webkit developers! I have recently updated my repository from revision 35033 to revision

Re: [webkit-dev] How does the Javascript garbage collection work?

2008-09-11 Thread Zoltan Herczeg
Hi Josh, When a C/C++ function allocates stack space (with decreasing the stack pointer), it does not initialize the variables there. You need to initialize them by assignment operators. Reading such variables by the GC yields an error in valgrind. Cheers, Zoltan Thanks for the reply. I have

Re: [webkit-dev] Some Questions about Squirrel Fish

2009-01-21 Thread Zoltan Herczeg
Hi, - Is there any validation test suite other than Sunspider that was used to validate the SquirrelFish JIT on x86 ? SunSpider is performance benchmark not regression test. To run mozilla regression test use the following command: WebKit/WebKitTools/Scripts/run-javascriptcore-tests Two

Re: [webkit-dev] Some Questions about Squirrel Fish

2009-01-24 Thread Zoltan Herczeg
Hi! - is there any port on top of ARM based platforms? We can announce now that we have started to work on the ARM-JIT port of WebKit here. We have implemented cachable function calls and exception handling first, since these require communication between high level C++ functions and JIT code

Re: [webkit-dev] Tamarin VM inside WebKit

2009-01-26 Thread Zoltan Herczeg
Hi, Is there any plan to have the Tamarin (http://www.mozilla.org/projects/tamarin ) inside WebKit? No. well, that is a short answer :) We did some experiments with Tamarin VM (NanoJIT compiler) as the JIT engine for JavaScriptCore. We have implemented about two third of SquirellFish

Re: [webkit-dev] want to port JIT to MIPS - patchImmediate

2009-02-26 Thread Zoltan Herczeg
Hi, jit GetByIdSelf methods caches the structure ID (see the line starting with Jump structureCheck = ...) and the offset in the PropertyStorage (see DataLabel32 displacementLabel = ...) in the jit code itself. StructureID-s are required to check that the input JSValue is the same JSObject which

Re: [webkit-dev] want to port JIT to MIPS - stack/code segment alignment

2009-02-26 Thread Zoltan Herczeg
Hi, I am not sure I understand your questions. The code blocks are allocated by mmap() or VirtualAlloc(), thus they are aligned to 4K. Smaller chunks are aligned by roundUpAllocationSize() function. Now the alignemt is sizeof(void*) in both x86 and ARM. See ExecutableAllocator.h The current jit

Re: [webkit-dev] want to port JIT to MIPS - stack/code segment alignment

2009-02-26 Thread Zoltan Herczeg
be not aligned to 32bit. I'll add __attribute__ ((aligned (4))) or 8. rgds joe --- On Fri, 2/27/09, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: From: Zoltan Herczeg zherc...@inf.u-szeged.hu Subject: Re: [webkit-dev] want to port JIT to MIPS - stack/code segment alignment To: webkit-dev

Re: [webkit-dev] Question about JavaScriptCore's JSEvaluateScript function.

2009-03-02 Thread Zoltan Herczeg
Hi, that is intended, since the context pointer is the current CallFrame/ExecState. WebKit creates its own stack (called RegisterFile) to run JavaScript. The stack base of the current function is pointed by CallFrame (similar to ebp in x86, or fp in ARM architectures). When you call a JS

Re: [webkit-dev] Question about JavaScriptCore's JSEvaluateScript function.

2009-03-02 Thread Zoltan Herczeg
Thanks for your answer. Then, in the callback function (such as GetPropertyCallback), is it ok to use the original context pointer created at beginning? Or the ctx passed to the callback must be used instead? Regards James Su On Mon, Mar 2, 2009 at 4:52 PM, Zoltan Herczeg zherc...@inf.u

Re: [webkit-dev] want to port JIT to MIPS - how patchOffset* constant determined?

2009-03-03 Thread Zoltan Herczeg
apperciate if sb can do it or help me to do it. rgds joe --- On Sat, 2/28/09, x yz last...@yahoo.com wrote: From: x yz last...@yahoo.com Subject: Re: [webkit-dev] want to port JIT to MIPS - which calling convention is used here? To: webkit-dev@lists.webkit.org, Zoltan Herczeg zherc

Re: [webkit-dev] want to port JIT to MIPS - how patchOffset* constant determined?

2009-03-03 Thread Zoltan Herczeg
to the 9? rgds joe --- On Wed, 3/4/09, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: From: Zoltan Herczeg zherc...@inf.u-szeged.hu Subject: Re: [webkit-dev] want to port JIT to MIPS - how patchOffset* constant determined? To: webkit-dev@lists.webkit.org Date: Wednesday, March 4, 2009, 3:45 AM

Re: [webkit-dev] print the uchar variables

2009-03-10 Thread Zoltan Herczeg
Hi, %ls prints string arguments (like UChar*) for UChar, %lc should be used. Zoltan Hi all I am learning the webkit source codes, and there are many variables whose type is UChar, Now I want to print the variables, if I use the sentence wprintf(L%ls\n,variable); ,it will print

Re: [webkit-dev] about the class of jscell and jsvalueptr

2009-03-23 Thread Zoltan Herczeg
Hi, JSCell is a small memory block, which is maintaned by the garbage collector. It is 32 byte on 32 bit machines and 64 byte in 64 bit machines (see JavaScriptCore/runtime/collector.cpp). JSValuePtr is the basic data type structure of JavaScript. It can be a pointer to a JSCell or an immediate

Re: [webkit-dev] How to build javaScript Syntax tree

2009-03-24 Thread Zoltan Herczeg
Hi, perhaps you should check out parser/grammar.y instead of the c++ functions. The grammar.cpp and .h is generated by bison, and not easy to understand. Zoltan Hi all Now I am learning at JavaScriptCore, but I don't kown how to build javaScript syntax tree through c++ functions, please tell

Re: [webkit-dev] Announce the ARM port of JIT

2009-04-03 Thread Zoltan Herczeg
Hi, Thanks :) we put all those constants into the constant pool. ARM supports position independent code efficently, since its program counter is a regular register as well. We can load, modify or even jump to the addresses which are stored in the constant pool. Constant pools are dynamically put

Re: [webkit-dev] Announce the ARM port of JIT

2009-04-03 Thread Zoltan Herczeg
Hi, after I read my mail again I am not sure it is clear what I wanted to say. current operation: - push instruction. It will either a) push the current instruction b) push he constant pool, and push the current instruction - utility function: the next two instruction will be tightly

[webkit-dev] Nitro-Extreme branch

2009-05-05 Thread Zoltan Herczeg
Hi, we have noticed that there is a new SquirellFish branch, called Nitro-Extreme. You mentioned before (perhaps a year ago), that you plan to change the JSNumber format to eliminate number (double) allocations. This is the aim of this branch, isn't it? Do you have any results? Is it faster than

Re: [webkit-dev] Nitro-Extreme branch

2009-05-07 Thread Zoltan Herczeg
Hi, I have made some measurements on ARM. You can read the results on our blog site: http://webkit.sed.hu/node/14 Zoltan Right now, the branch is about even with trunk on SunSpider. Geoff On May 5, 2009, at 6:11 AM, Zoltan Herczeg wrote: Hi, we have noticed that there is a new

Re: [webkit-dev] random seg fault on MIPS platform

2009-05-08 Thread Zoltan Herczeg
Hi, I don't know anything about MIPS architecture (only x86, ARM and PowerPC), but we have experienced similar things on ARM, until we have found the gcc's __clear_cache(void* begin, void* end) function. It calls a kernel utility, which flushes out the data cache (some mrc instructions can only

Re: [webkit-dev] Webkit JavaScript question

2009-05-21 Thread Zoltan Herczeg
Hi, The JavaScript engine does 3 steps: 1) Parse JS files 2) Generate SquirellFish byte code (ByteCodeGenerator.h is part of it) 3) Compile SF byte code to machine code by its JIT compiler (optional) The last step depends on the architecture (supported or not) and C++ compiler directives. If JIT

Re: [webkit-dev] Webkit JavaScript question

2009-05-22 Thread Zoltan Herczeg
codes, no interpreter. http://code.google.com/apis/v8/design.html#mach_code Thank you. On Thu, May 21, 2009 at 2:12 PM, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: Hi, The JavaScript engine does 3 steps: 1) Parse JS files 2) Generate SquirellFish byte code (ByteCodeGenerator.h is part

Re: [webkit-dev] Webkit JavaScript question

2009-05-22 Thread Zoltan Herczeg
Hi, I don't think so. It is not worth to do it on a desktop pc since interpreter is always slower than JIT. However, the story is different for embedded systems, when they enter low-memory mode. We made some experiments before, and it seems possible to switch between jit and interpreter, but I am

Re: [webkit-dev] How to dump SquirrelFish opcode and machine code

2009-05-27 Thread Zoltan Herczeg
Hi, How to dump SquirrelFish opcode and machine code? Here is what I would like to do, for each JS file that WebCore passes to SquirrelFish, configure SquirrelFish to dump opcode and machine code. Thank you for any tips. I am not sure you can do SF byte code dump out of the box since SF

[webkit-dev] Math.floor(expr1/expr2)

2009-05-28 Thread Zoltan Herczeg
Hi, we plans to make a super instruction for floor(expr1/expr2), which is an integer division (if both operands are integer numbers). We hope it would be benficial for embedded systems. I think the implementation would be similar to the JS apply() function: the fast case detects whether both

Re: [webkit-dev] stack alignment bug

2009-06-03 Thread Zoltan Herczeg
Hi, true, some architectures have strict policies for stack handling. Perhaps the worst one is PowerPC with its organized stack frame (back chains, pre-defined register save areas, etc). I think a fake stack pointer for JIT can solve the x86 compatibility problem. 1) allocate enough aligned

Re: [webkit-dev] stack alignment bug

2009-06-04 Thread Zoltan Herczeg
structure or point to double is not aligned and I'm still trying to find where they are. I'm not sure how the fake stack would be, would you mind explains a bit more? Did you face same problem? Thanks also for your articles that gives new ideas. rgds joe --- On Wed, 6/3/09, Zoltan Herczeg

Re: [webkit-dev] stack alignment bug

2009-06-04 Thread Zoltan Herczeg
what you're envisaging 'fake_sp' would be used for. I've just landed a patch to move the pushes pops in wrapper functions, and to switch put transition realloc to use a regular function call, hopefully this tidies things up a little. cheers, G. On Jun 4, 2009, at 1:19 AM, Zoltan Herczeg

Re: [webkit-dev] arm jit

2009-06-11 Thread Zoltan Herczeg
Hi guys at Apple, it looks we are in the way of the train. You have plans, we don't know about them, you have commit rights, we don't, so the tides are against us. Hints on the mailing lists are scarce, although a year ago someone from you asked whether others are interested in design

Re: [webkit-dev] arm jit

2009-06-11 Thread Zoltan Herczeg
If you're interested in review or commit rights, they're granted based on a track record of good work, good judgement, and good collaboration. You can read more about the policy here: http://webkit.org/coding/commit-review-policy.html . Please work on your collaboration skills. Right now,

Re: [webkit-dev] Memory usage for Webkit

2009-06-11 Thread Zoltan Herczeg
Hi, http://webkit.sed.hu/node/15 As you can see on the charts there, you should consider the whole environment not just WebKit alone. Large amount of resources are allocated by other libs as well. Zoltan On 2009-06-11, at 12:50, James Howlett wrote: Hi, Is there any plan to reduce the

[webkit-dev] Name of a JS function

2009-06-16 Thread Zoltan Herczeg
Hi, how can I extract the name of a JS function in JIT.cpp? Zoltan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Name of a JS function

2009-06-16 Thread Zoltan Herczeg
On Jun 16, 2009, at 3:55 AM, Zoltan Herczeg wrote: Hi, how can I extract the name of a JS function in JIT.cpp? Zoltan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] ARM JIT and related issues

2009-06-17 Thread Zoltan Herczeg
Hi, 1) The armv7 port is separate from the armv6 work, and uses the thumb2 instruction set. Both ports are (I hope!) useful. We hope it as well. 2) We would have liked to let the community know about the arm v7 port sooner. Unfortunately, we were not at liberty to disclose it until the

Re: [webkit-dev] Building WebKit on ARM

2009-06-17 Thread Zoltan Herczeg
Hi, 1.Want to know the build instructions for building WebKit on OMAP 3530? WebKit is written in c++, so you don't need to do anything special for your CPU. Just run WebKitTools/Scripts/build-webkit 2.Does the WebKit source need to be changed(makefile) so that it builds for OMAP 3530? If

[webkit-dev] JavaScriptCore enhancements

2009-07-03 Thread Zoltan Herczeg
Hi, we hope the general arm-jit will soon go to mainline, so we could have enough time to countinue our work on other JSC enhancements. We would like to hear your opinion about them (Are they still valid? Has someone else already been working on it? Which one is important for you?): - runtime

Re: [webkit-dev] Iterating SunSpider

2009-07-06 Thread Zoltan Herczeg
Hi, Can future versions of the SunSpider driver be made so that they won't become irrelevant over time? I feel the weighting is more of an issue here than the total runtime. Eventually some tests become dominant, and the gain (or loss) on them almost determine the final results. Besides,

[webkit-dev] Calling gc::collect() before the program exits

2009-07-27 Thread Zoltan Herczeg
Hi, by default, gc::collect() is triggered by a timer at regular intervals. In QtLauncher, gc::collect() is not called in any other way, so the remaining JS objects cause memory leaks when QtLauncher exits. Although this approach may not be considered a bug, since the program soon quits, I would

[webkit-dev] freeing static variables

2009-07-29 Thread Zoltan Herczeg
Hi all, Valgrind reports a lot of memory leaks when QtLauncher quits, because many static local variables are not freed. I did a little research and realized there is no consistent way to define static variables in webkit: WebCore/css/CSSSelector.cpp: CSSSelector::extractPseudoType() using a

Re: [webkit-dev] freeing static variables

2009-07-30 Thread Zoltan Herczeg
Hi, any thoughts on this? I hope my qestion was clear :) I would like to pack the static declarations into wrapper classes, so we can add platform and/or compilation mode (debug/release) dependent functionality to all static variables (i.e: freeing them on exit). Zoltan Hi all, Valgrind

Re: [webkit-dev] freeing static variables

2009-08-04 Thread Zoltan Herczeg
will help to the leak hunters in the future. Cheers, Zoltan On Thursday 30 July 2009 02:55:18 am Zoltan Herczeg wrote: Hi, any thoughts on this? I hope my qestion was clear :) I would like to pack the static declarations into wrapper classes, so we can add platform and/or compilation mode (debug

Re: [webkit-dev] Can someone give current status for Webkit/GTK build under mingw

2009-08-05 Thread Zoltan Herczeg
Hi, Im not sure if Im asking the right place yes :), such qestions should go to webkit-help Cheers, Zoltan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] New marking model for GC collected objects

2009-09-01 Thread Zoltan Herczeg
Hi Oliver, it seems on ARM using WTF_USE_JSVALUE32, the internal value of a date object is sometimes freed by the garbage collector. More specifically: The double (millisecond) representation of a date object (returned by a new Date expression) is stored in JSWrapperObject: m_internalValue. This

Re: [webkit-dev] New marking model for GC collected objects

2009-09-02 Thread Zoltan Herczeg
Darin has already submitted a big patch to the bug report, which hopefully solve all of these issues. Zoltan In WTF_USE_JSVALUE32 DateInstance needs to override createStrucutre to remove the HasDefaultMark bit --Oliver On Sep 2, 2009, at 6:54 AM, Zoltan Herczeg wrote: Hi Geoff

Re: [webkit-dev] [webkit-help] webkit cross compilation error

2009-09-23 Thread Zoltan Herczeg
Hi, -m64 means: generate code for 64 bit machines. ARM is not a 64 bit architecture. Does your Ubuntu use a x86-64 kernel? Which WebKit platform do you use? Perhaps a mechanism detected your architecture and pass this flag to WebKit to make optimized code for your machine. Zoltan hi, i'm

Re: [webkit-dev] Leak reports during shutdown

2009-09-29 Thread Zoltan Herczeg
Hi Kevin, WebKit approach is NOT to free memory before quit to make the quit process as fast as possible. The memory manager should free the unfreed objects. However, this approach makes really hard to find the real leaks (which are unreferenced objects). In my experince the unfreed (non-leak)

[webkit-dev] compileOpCallSetupArgs

2009-10-07 Thread Zoltan Herczeg
Hi, I am not sure this is a bug, so I am curios about your opinion. Currently, I am trying to enable JSVALUE32_64 on ARM. First step, as usual, with all optimizations disabled. Unfortunately, I got a crash. If JIT_OPTIMIZE_CALL is disabled, callee is loaded to regT1 and regT2, while if enabled,

[webkit-dev] jit, unordered compare

2009-10-12 Thread Zoltan Herczeg
Hi, My stougle with USE_JSVALUE32_64 still continues on ARM. In emit_op_jfalse, there is a comparison here (fpRegT0 contains 0.0): addJump(branchDouble(DoubleEqual, fpRegT0, fpRegT1), target + 2); In x86, if either operand is NaN, the zero flag is set by definition (ucomisd instruction). I have

Re: [webkit-dev] jit, unordered compare

2009-10-12 Thread Zoltan Herczeg
a BEQ or BNE is used afterwards) or to test for unorderedness (in the V flag). Gavin, do you have any ideas here? Geoff On Oct 12, 2009, at 4:05 AM, Zoltan Herczeg wrote: Hi, My stougle with USE_JSVALUE32_64 still continues on ARM. In emit_op_jfalse, there is a comparison here (fpRegT0

Re: [webkit-dev] jit, unordered compare

2009-10-16 Thread Zoltan Herczeg
Hi fortunately, no, I don't need double branch here. cmpvs reg0, reg0 is a conditional instruction, which only executes if the v flag is set. My proposal would be to add a new DoubleCondition called DoubleEqualOrNAN, or something similar to clarify what we expect from the conditional branch.

Re: [webkit-dev] JIT for arm is dependant on gcc

2009-10-21 Thread Zoltan Herczeg
Hi, these entry/leave functions are implemented in assembly for all ports. It is faster this way. (Previously, the jit generated these functions, but the reviewers convinced us to do this way). External .asm files would be a nightmare, since we have to create (and maintain) the build rules for

Re: [webkit-dev] JIT for arm is dependant on gcc

2009-10-21 Thread Zoltan Herczeg
as I haven't used 3 parameter assembler language before although I'm sure I could do this with a couple of hours research. Can you maybe show me how to get the jit to generate this for this toolchain? Jason. -Original Message- From: Zoltan Herczeg [mailto:zherc...@inf.u-szeged.hu

Re: [webkit-dev] jit for arm

2009-11-17 Thread Zoltan Herczeg
Hi, seems the original mail was sent to both webkit-dev and webkit-help. My reply was on webkit-help, and the discussion continued there. https://lists.webkit.org/pipermail/webkit-help/2009-November/000380.html Perhaps we should clarify better the purpose of these mailing lists, since if people

[webkit-dev] improving String::append()

2009-12-03 Thread Zoltan Herczeg
Hi, according to my measurements, a large chunk of WebKit memory consumption comes from WebCore::TextResourceDecoder::decode (loader/TextResourceDecoder.cpp:818) which calls String::append (String.cpp:82). The comment there says: // FIXME: This is extremely inefficient. I would volunteer to

[webkit-dev] TARGET_OS_EMBEDDED

2009-12-04 Thread Zoltan Herczeg
Hi, it would be a great to have a macro in WebKit, which would be enabled on embedded systems. We could replace macros like PLATFORM(SYMBIAN) in TextCodecQt.cpp to this new macro. However, TARGET_OS_EMBEDDED macro enables WTF_PLATFORM_IPHONE. Well, not only symbian and iPhone exist in embedded

Re: [webkit-dev] ARM JIT for WinCE

2010-01-07 Thread Zoltan Herczeg
Hi Patrick, hm, I feel I found something. Please have a look at JavaScriptCore/jit/JITOpcodes.cpp : privateCompileCTIMachineTrampolines. The second one, when JSVALUE32_64 is disabled. If JIT_OPTIMIZE_NATIVE_CALL is enabled, a specialized code is generated to call native builtin functions (like

Re: [webkit-dev] ARM JIT for WinCE

2010-01-08 Thread Zoltan Herczeg
Hi, the dateProtoFuncGetTimezoneOffset does not use the argList argument, while functionPrint does. Perhaps passing this argument is still not yet WinCE compatible. ArgList contains a pointer to the arguments (JSValue pointers), and the length of the arguments. This structure is 8 bytes on 32 bit

Re: [webkit-dev] parallel rendering in WebKit

2010-02-20 Thread Zoltan Herczeg
Hi, thanks for all of your for your help. I would be worried about correctness - if painting is not complete by the time the paint method returns, then you could get flashes of intermediate states showing up onscreen. We plan to do the painting on a background image. When all the painting

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-09 Thread Zoltan Herczeg
Hi, It's also a big help when peers (which aren't necessarily WebKit reviewers) look over it and give review-style feedback as well. Especially when said peers know more about that code than any of the official reviewers. Is that really help? Sometimes when a patch looks good to me, it

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Zoltan Herczeg
But in cases like the SharedBuffer one, there is no mystery about who allocated the memory. The mystery is typically who is holding on to a reference to it. I have a technique to capture ref/deref problems with gdb. When the object is created (inside the object constructor), I just put a

[webkit-dev] parallel painting

2010-04-03 Thread Zoltan Herczeg
Hi, I am working on a parallel painting feature for WebKit (bug id: 36883). Basically it records the painting commands on the main thread, and replay them on a painting thread. The gain would be that the recording operation is cheap. Currently it is Qt specific, but I could make it more platform

Re: [webkit-dev] parallel painting

2010-04-06 Thread Zoltan Herczeg
Hi, Thank all of you for your feedbacks! Let's continue this discussion in the bug report, I will provide more details there. Zoltan On Sat, Apr 3, 2010 at 9:32 PM, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: Hi, I am working on a parallel painting feature for WebKit (bug id: 36883

Re: [webkit-dev] parallel painting

2010-04-06 Thread Zoltan Herczeg
, style resolution, or javascript execution/bindings. -eric On Sat, Apr 3, 2010 at 10:32 PM, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: Hi, I am working on a parallel painting feature for WebKit (bug id: 36883). Basically it records the painting commands on the main thread, and replay

Re: [webkit-dev] Announcing WebKit2

2010-04-09 Thread Zoltan Herczeg
Hi! Your wiki says: DrawingArea - an abstraction for a cross-process drawing area. Multiple drawing strategies are possible, the simplest is just a shared memory bitmap. Could you tell me more about it? I am working on a parallel painting feature (GraphicsContext commands can be forwarded to

Re: [webkit-dev] Coming Soon: new-run-webkit-tests

2010-04-09 Thread Zoltan Herczeg
We should make the new tool record the order so order-specific failures can be explored. A custom random generator would be enough. The seed can be given by a user or a just starts with a random value which is reported when the test finish. Much easier to share seed-revision pairs than

Re: [webkit-dev] Function Property Names

2010-05-03 Thread Zoltan Herczeg
Hi, https://bugs.webkit.org/show_bug.cgi?id=32561 Zoltan Is there any way to map specific bytecode instruction instances to the position in the source code of the JavaScript code they correspond to? -- View this message in context:

Re: [webkit-dev] parallel controls in JavaScriptCore engine

2010-06-28 Thread Zoltan Herczeg
Hi, why don't you simply use a workaround? script function success() { alert(Success); continueTask(true); } function failure() { alert(Failure); continueTask(false); } function continueTask(success) { x= 10+1; } /script Zoltan Hello, As part of my project, we

Re: [webkit-dev] How to integrate the SFX JIT for SH4 in the webkit svn tree.

2010-07-17 Thread Zoltan Herczeg
Hi, nice job, Haithem. This page explains how to contribute code to WebKit: http://webkit.org/coding/contributing.html You may find helpful the bugzilla entries for other JSC-JIT ports: ARM: https://bugs.webkit.org/show_bug.cgi?id=24986 MIPS: https://bugs.webkit.org/show_bug.cgi?id=30144 Both

Re: [webkit-dev] SIL Open Font License and WebKit

2010-07-20 Thread Zoltan Herczeg
We can't really download them from stixfonts.org. Alex, wouldn't be possible to contact them and ask some help? Maybe they could offer us an acceptable solution. Zoltan ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] review queue crazy idea

2010-07-22 Thread Zoltan Herczeg
Patches sit in the queue for numerous reasons. Some of us used to scan the queue every day. But I've stopped doing that. Now I scan it more like once a week or two. There is no good way to find which patches might I have a chance of reviewing, so you end up spending 30 minutes just to

[webkit-dev] ANGLE

2010-08-13 Thread Zoltan Herczeg
Hi, ANGLE looks like a graphics helper library. Why it is placed in the root WebKit directory? Perhaps WebCore/platform/graphics or some kind of /3rparty directory would be better, wouldn't it? Regards, Zoltan ___ webkit-dev mailing list

Re: [webkit-dev] WebKit/Cairo build errors

2010-11-25 Thread Zoltan Herczeg
Hi, try webkit-help, which is the right place for such qestions. Regards, Zoltan Hi, I'm having problems building WebKit Cairo port (from 23/11 nightly). First it gives an error on RenderMediaControls.cpp which includes CoreGraphics/CoreGraphics.h and it shouldn't (right? this is part of

Re: [webkit-dev] Stability problems involving Javascript GC

2010-12-17 Thread Zoltan Herczeg
On 6 December 2010 22:31, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: Crash in WTF::fastMalloc? Such things only happen if something overwrites memory areas belongs to the memory manager (i.e overwrites some bytes before or after a block returned by malloc). Try some valgrind

Re: [webkit-dev] Stability problems involving Javascript GC

2010-12-17 Thread Zoltan Herczeg
It is possible to add macros to the code to help valgrind know which areas are being used by a custom allocator.  (See VALGRIND_MALLOCLIKE_BLOCK and VALGRIND_FREELIKE_BLOCK, for example.)  I'm not sure if they're useful in this situation, but they're worth taking a look at. I see. That

Re: [webkit-dev] Renaming directories

2010-12-18 Thread Zoltan Herczeg
LayoutTests = Tests That would kill the new Ttab is enough to enter the Tools directory feature :P I like the Ltab for generic tests. Cheers, Zoltan ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Renaming directories

2010-12-18 Thread Zoltan Herczeg
Hm, thinking a bit about it I realized these renamings could help the usability of the source code. I actually use a lot the WebKitBuild directory, and would be happy if it would be renamed to Build (= Btab), and Scripts could go to the root directory. In that case, LayoutTests = Tests would be be

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Zoltan Herczeg
Like it. I only have a few questions: * Where would the build (WebKitBuild) directory would go? Perhaps a Build/ would fit in the root directory. * Some manual-tests belong to the regression tests, and some are belong to the performance test. Would be good to separate them. * I think the build

[webkit-dev] Rounding issues on different platforms

2011-06-07 Thread Zoltan Herczeg
Hi, If you maintain some bots, and you saw rounding issues which makes 1px difference on let's say 32 and 64 bit environments for several layout tests, you may interested in this bug: https://bugs.webkit.org/show_bug.cgi?id=62204 I try to explain what exactly happens there, and it could be used

Re: [webkit-dev] parallel painting

2011-06-10 Thread Zoltan Herczeg
if the graphics layer is incredibly slow. In most WebKit ports we do not see very much time ... On Sat, Apr 3, 2010 at 10:32 PM, Zoltan Herczeg zherc...@inf.u-szeged.hu mailto:zherc...@inf.u-szeged.hu wrote: Hi, I am working on a parallel painting feature

Re: [webkit-dev] JavaScripCore on Android

2011-06-30 Thread Zoltan Herczeg
Hi, ThreadSpecific contains the platform dependent TLS (Thread Local Storage) implementation for WebKit. In Platform.h: #if PLATFORM(ANDROID) #define WTF_USE_PTHREADS 1 ... Thus, Android should use pthread.h (Please check this line in your Source/JavaScriptCore/wtf/Platform.h) You could try

Re: [webkit-dev] Removing ENABLE_SINGLE_THREADED and ENABLE_JSC_MULTIPLE_THREADS

2011-09-08 Thread Zoltan Herczeg
Hi, I like this idea. Multicore cpus are getting widespread even in the low-end devices nowadays. Regards, Zoltan Hi folks. To help move WebKit and JavaScriptCore forward, I'd like to remove old platform cruft that creates particular pain points for development. To that end, I'd like to

Re: [webkit-dev] squirrefish extreme on Arm.

2011-11-26 Thread Zoltan Herczeg
Hi, WebKit supports ARM and Thumb2 instructions sets (called ARMv7). You can find them here (or in your own source code): http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/assembler SquirrelFish Extreme is just a codename for the JavaScript JIT compiler (and Nitro is another). The JIT

Re: [webkit-dev] WebKit branch to support multiple VMs (e.g., Dart)

2011-12-05 Thread Zoltan Herczeg
It's not quite true that multiple languages are exposed to the web. One Turing-complete language is exposed, and any Turing-complete language can be compiled to any other Turing-complete language. The fact that some developers compile their favorite languages to JS doesn't mean that we should

Re: [webkit-dev] WebKit branch to support multiple VMs (e.g., Dart)

2011-12-06 Thread Zoltan Herczeg
Hi Anton, I am sorry if it didn't sound clear enough in our original message, but we're not proposing a new language support, but we're proposing a patch which allows others runtimes to run along with JS in the browser. and they mostly replied to that (including some solution ideas like

Re: [webkit-dev] Arm conditional instructions support

2011-12-12 Thread Zoltan Herczeg
Hi! Condition cc=ALL is the default function parameter in C++ (http://www.learncpp.com/cpp-tutorial/77-default-parameters/). There is no conditional instruction support in MacroAssembler level in SFX, but some lower-level optimizations use conditional execution. Regards, Zoltan Hi! I found

[webkit-dev] Custom written css lexer

2011-12-12 Thread Zoltan Herczeg
Hi, I am working on rewriting the css lexer, and someone suggested that it should be mentioned to a broader community, since we can drop the flex tool dependency from WebKit which affects all build systems. This mail is just a note, since the patch is not yet ready.

Re: [webkit-dev] Top 100 sites browsing tests proprosal

2012-01-21 Thread Zoltan Herczeg
Just be careful with copyright issues. Regards, Zoltan Go for it. Adam On Sat, Jan 21, 2012 at 2:12 AM, Sergio Villar Senin svil...@igalia.com wrote: Hi, I've been thinking about this for some time now, but only a recent bug I'm constantly hitting these days

Re: [webkit-dev] Top 100 sites browsing tests proprosal

2012-01-23 Thread Zoltan Herczeg
But are you planning to run test builds against live websites? That's not very polite on people's servers (i certainly wouldn't like anyone stress-testing my own servers for their benefit). And like some other people said, tests that rely on network randomness are not very reliable indicators

[webkit-dev] Grafikus teamnek

2012-03-03 Thread Zoltan Herczeg
Sziasztok! Jatszottam penteken OpenGL-el egy kicsit (MAC-en gluttal szepen ment), es arra gondoltam hogy elindulas keppen csinalhatnank valami brainstormingot az egesz temarol. Nem tudom ki mennyire ismeri az OpenGL es OpenVG mukodeset (en sem tulsagosan). Eszerint:

Re: [webkit-dev] Grafikus teamnek

2012-03-03 Thread Zoltan Herczeg
Oops sorry. Ignore this mail. Regards, Zoltan Sziasztok! Jatszottam penteken OpenGL-el egy kicsit (MAC-en gluttal szepen ment), es arra gondoltam hogy elindulas keppen csinalhatnank valami brainstormingot az egesz temarol. Nem tudom ki mennyire ismeri az OpenGL es OpenVG mukodeset (en sem

Re: [webkit-dev] Anyone using NEON code on ARM builds?

2012-03-21 Thread Zoltan Herczeg
Hi, btw if anyone interested about the details of this optimization you can read more about it here: http://blogs.arm.com/software-enablement/699-using-arm-neon-to-accelerate-scalable-vector-graphics-in-webkit-by-up-to-4X/ Regards, Zoltan Hi Jonathan, On 21/03/2012, at 12:56 AM, Jonathan

[webkit-dev] Transformations precision: double - float

2012-05-21 Thread Zoltan Herczeg
Hi, is there any reason why the transformations in WebKit use doubles? We could optimize some functions further with ARM SIMD if they would be floats. Is there any objection to make them float if the change would have no other side effects except some rounding because of the lower precision?

Re: [webkit-dev] can we stop using Skipped files?

2012-06-08 Thread Zoltan Herczeg
Hi, I don't see why it would make sense to keep two parallel tools for this once all the workflow bugs people have are addressed. The reason is easy. In the past when people tried to add new features to NRWT, they were not allowed to because the feature is not useful for NRWT devs. Eventually

Re: [webkit-dev] can we stop using Skipped files?

2012-06-08 Thread Zoltan Herczeg
Hi Dirk, At any rate, I believe we are definitely open to adding new features; feel free to suggest them or work on them! I am happy to hear that. https://bugs.webkit.org/show_bug.cgi?id=88680 This is definitely a right step! And it looks like still a lot of things to do before NRWT reach

Re: [webkit-dev] DFG, inline functions compileing

2012-06-17 Thread Zoltan Herczeg
Where are they compiled twice? If in the object file, than it is ok, since the compiler must provide a standalone function for even inline ones. It is needed if the function is passed as pointer. These extra functions should be thrown out by the linker in the final binary. Regards, Zoltan It's

Re: [webkit-dev] SH4, MIPS, and legacy-ARM assemblers in JavaScriptCore

2012-06-22 Thread Zoltan Herczeg
Hi Filip, we (Gabor Loki and me) are the maintainers of the traditional ARM port, and we are willing to fix all issues. Just let us know what we need to do. You can assign the necessary bug reports to us and we are available in the #squirrelfish (or #webkit) channel as well. Regards, Zoltan Hi

Re: [webkit-dev] SH4, MIPS, and legacy-ARM assemblers in JavaScriptCore

2012-06-22 Thread Zoltan Herczeg
bot cycles discovering all the cases that we missed. This consumes a lot of time that would be better spent working on the higher level portions of the JIT, that benefit all platforms. --Oliver On Jun 21, 2012, at 11:44 PM, Zoltan Herczeg wrote: Hi Filip, we (Gabor Loki and me

Re: [webkit-dev] SH4, MIPS, and legacy-ARM assemblers in JavaScriptCore

2012-06-22 Thread Zoltan Herczeg
I don't want adding instructions to SH4, MIPS, and legacy ARM to be a blocker for JSC work. I didn't say you have to wait. I just said you should notify us that something is coming which will break the build. Regards, Zoltan ___ webkit-dev mailing

Re: [webkit-dev] SH4, MIPS, and legacy-ARM assemblers in JavaScriptCore

2012-06-23 Thread Zoltan Herczeg
, Zoltan Herczeg zherc...@webkit.org wrote: I don't want adding instructions to SH4, MIPS, and legacy ARM to be a blocker for JSC work. I didn't say you have to wait. I just said you should notify us that something is coming which will break the build. Regards, Zoltan

  1   2   >