Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?
El mar, 20-08-2013 a las 10:41 -0700, Martin Robinson escribió: On Mon, Aug 19, 2013 at 10:16 PM, Ryosuke Niwa rn...@webkit.org wrote: Are Qt and GTK+ (and other) ports intentionally returning false in shouldShowPlaceholderWhenFocused? Or is this just an oversight due to the fact the default implementation returned false? I just confirmed that the native GTK+ behavior is for placeholder text to disappear when a text entry is focused. I believe for GTK+ this method should return false. I think that removing the placeholder text when starting typing instead of when the entry is focused is indeed a good idea. I implemented the placeholder text in GTK+ following the WebKit approach, so maybe we can change it in both places. --Martin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- Carlos Garcia Campos http://pgp.rediris.es:11371/pks/lookup?op=getsearch=0xF3D322D0EC4582C3 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?
+1 -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Carlos Garcia Campos Sent: Wednesday, August 21, 2013 3:08 PM To: Martin Robinson Cc: WebKit Development Subject: Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused? El mar, 20-08-2013 a las 10:41 -0700, Martin Robinson escribió: On Mon, Aug 19, 2013 at 10:16 PM, Ryosuke Niwa rn...@webkit.org wrote: Are Qt and GTK+ (and other) ports intentionally returning false in shouldShowPlaceholderWhenFocused? Or is this just an oversight due to the fact the default implementation returned false? I just confirmed that the native GTK+ behavior is for placeholder text to disappear when a text entry is focused. I believe for GTK+ this method should return false. I think that removing the placeholder text when starting typing instead of when the entry is focused is indeed a good idea. I implemented the placeholder text in GTK+ following the WebKit approach, so maybe we can change it in both places. --Martin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- Carlos Garcia Campos http://pgp.rediris.es:11371/pks/lookup?op=getsearch=0xF3D322D0EC4582C3 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?
El mar, 20-08-2013 a las 23:41 -0700, Ryosuke Niwa escribió: Does that mean we want the new Mac behavior (i.e. shouldShowPlaceholderWhenFocused returning true) everywhere? I think so unless any GTK+ port maintainer disagree, but consistency with the platform is important too, so I'll first check with GNOME designers if they are ok with changing that in GTK+. Ryosuke Niwa On Tue, Aug 20, 2013 at 11:35 PM, Kangil Han kangil@samsung.com wrote: +1 -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Carlos Garcia Campos Sent: Wednesday, August 21, 2013 3:08 PM To: Martin Robinson Cc: WebKit Development Subject: Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused? El mar, 20-08-2013 a las 10:41 -0700, Martin Robinson escribió: On Mon, Aug 19, 2013 at 10:16 PM, Ryosuke Niwa rn...@webkit.org wrote: Are Qt and GTK+ (and other) ports intentionally returning false in shouldShowPlaceholderWhenFocused? Or is this just an oversight due to the fact the default implementation returned false? I just confirmed that the native GTK+ behavior is for placeholder text to disappear when a text entry is focused. I believe for GTK + this method should return false. I think that removing the placeholder text when starting typing instead of when the entry is focused is indeed a good idea. I implemented the placeholder text in GTK+ following the WebKit approach, so maybe we can change it in both places. --Martin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- Carlos Garcia Campos http://pgp.rediris.es:11371/pks/lookup?op=getsearch=0xF3D322D0EC4582C3 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- Carlos Garcia Campos http://pgp.rediris.es:11371/pks/lookup?op=getsearch=0xF3D322D0EC4582C3 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?
On Tuesday 20 August 2013, Ryosuke Niwa wrote: Hi, Once my patch for https://bugs.webkit.org/show_bug.cgi?id=120049 is landed, Mac port will no longer return false in shouldShowPlaceholderWhenFocused. Mac, Windows, and EFL all return true in this function. Are Qt and GTK+ (and other) ports intentionally returning false in shouldShowPlaceholderWhenFocused? Or is this just an oversight due to the fact the default implementation returned false? I think in our case the method is simply not implemented. Honestly even after investigating it I am still not sure exactly what it does. What is a placeholder in the context of a text-edit, and why should it be visible when focused,; is it not visible when not focused, or only visible when not focused? Sometimes I think a little more method documentation in WebCore would be a good idea. Regards `Allan ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?
On Aug 20, 2013, at 5:43 AM, Allan Sandfeld Jensen k...@carewolf.com wrote:What is a placeholder in the context of a text-editPlaceholder text is text telling you what to type, like in this example:data:text/html,input placeholder="Title"why should it be visible when focusedThis is something that changed in Mac user interface. In older versions of the Mac UI, when you clicked to place an insertion point in the text field or tabbed into the field, the placeholder text would disappear.In newer versions, the placeholder text does not disappear until you type a character:That’s what this function was about; implementing both styles.-- Darin___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?
On Mon, Aug 19, 2013 at 10:16 PM, Ryosuke Niwa rn...@webkit.org wrote: Are Qt and GTK+ (and other) ports intentionally returning false in shouldShowPlaceholderWhenFocused? Or is this just an oversight due to the fact the default implementation returned false? I just confirmed that the native GTK+ behavior is for placeholder text to disappear when a text entry is focused. I believe for GTK+ this method should return false. --Martin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?
Thanks for the confirmation, Martin! I've started to wonder if we can tie this to the editing behavior instead. Isn't this more about the platform UI than each framework? If so, it'll be nice to check the behavior on Windows and simply make the placeholder text behavior change based on the underlying operating system. - R. Niwa On Tue, Aug 20, 2013 at 10:41 AM, Martin Robinson mrobin...@webkit.orgwrote: On Mon, Aug 19, 2013 at 10:16 PM, Ryosuke Niwa rn...@webkit.org wrote: Are Qt and GTK+ (and other) ports intentionally returning false in shouldShowPlaceholderWhenFocused? Or is this just an oversight due to the fact the default implementation returned false? I just confirmed that the native GTK+ behavior is for placeholder text to disappear when a text entry is focused. I believe for GTK+ this method should return false. --Martin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?
On Tuesday 20 August 2013, Darin Adler wrote: That’s what this function was about; implementing both styles. Thanks. I guess for Qt we would enable it on Mac, but keep it disabled elsewhere to stay consistent with the host platform. Best regards `Allan ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?
On Tue, Aug 20, 2013 at 1:52 PM, Ryosuke Niwa rn...@webkit.org wrote: Thanks for the confirmation, Martin! I've started to wonder if we can tie this to the editing behavior instead. Isn't this more about the platform UI than each framework? +1 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?
FYI. Chromium and Firefox have shouldShowPlaceHolderWhenFocused==true behavior in all platforms. Web authors can specify shouldShowPlaceHolderWhenFocused==false behavior with CSS if the default is shouldShowPlaceHolderWhenFocused==true, but they can't specify shouldShowPlaceHolderWhenFocused==true behavior if the default is shouldShowPlaceHolderWhenFocused==false. On Tue, Aug 20, 2013 at 2:16 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, Once my patch for https://bugs.webkit.org/show_bug.cgi?id=120049 is landed, Mac port will no longer return false in shouldShowPlaceholderWhenFocused. Mac, Windows, and EFL all return true in this function. Are Qt and GTK+ (and other) ports intentionally returning false in shouldShowPlaceholderWhenFocused? Or is this just an oversight due to the fact the default implementation returned false? - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?
Hi, Once my patch for https://bugs.webkit.org/show_bug.cgi?id=120049 is landed, Mac port will no longer return false in shouldShowPlaceholderWhenFocused. Mac, Windows, and EFL all return true in this function. Are Qt and GTK+ (and other) ports intentionally returning false in shouldShowPlaceholderWhenFocused? Or is this just an oversight due to the fact the default implementation returned false? - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
