Re: [webkit-dev] Ask for review in BigInt Patch

[Caio Lima]

Hi all.

Could any JSC reviewer take a look into my BigInt Patches? Right now I
have 4 patches uploaded asking for review.

https://bugs.webkit.org/show_bug.cgi?id=182214
https://bugs.webkit.org/show_bug.cgi?id=183721
https://bugs.webkit.org/show_bug.cgi?id=184327
https://bugs.webkit.org/show_bug.cgi?id=184474

Some of these patches are blocking others like the addition and
subtraction operations
(https://bugs.webkit.org/show_bug.cgi?id=179002) and mod operation
(https://bugs.webkit.org/show_bug.cgi?id=184327).

Best regards,
Caio.

2018-04-17 23:52 GMT-03:00 Caio Lima :
> Hi all.
>
> After the landing of https://bugs.webkit.org/show_bug.cgi?id=182470 I
> rebased pending patches of BigInt that I'm waiting review. Here is the
> current List:
>
> https://bugs.webkit.org/show_bug.cgi?id=182214
> https://bugs.webkit.org/show_bug.cgi?id=183721
> https://bugs.webkit.org/show_bug.cgi?id=183996
>
> Could anyone take a look on these bugs?
>
> Regards,
> Caio.
>
>
> 2018-03-19 4:36 GMT-03:00 Caio Lima :
>> Hi all.
>>
>> It's been a while I am asking for review into BigInt Patches but get
>> no answer. I have 4 Patches in the queue to be reviewed but some of
>> them are dependent one to another. The addition of SpecBigInt
>> (https://bugs.webkit.org/show_bug.cgi?id=182470) is blocking BigInt
>> Unary "+" and "-" operation
>> (https://bugs.webkit.org/show_bug.cgi?id=182214) that is then blocking
>> support for addition operations
>> (https://bugs.webkit.org/show_bug.cgi?id=179002) and will block other
>> future Patches. I think the addition of SpecBigInt
>> (https://bugs.webkit.org/show_bug.cgi?id=182470) is the one that
>> should be reviewed first. Is there any better approach of how I could
>> get review on them? It is starting to be time consuming rebasing all
>> these dependent patches downstream.
>>
>> Regards,
>> Caio.
>>
>> Em qua, 14 de mar de 2018 às 21:08, Caio Lima  
>> escreveu:
>>>
>>> Hi all.
>>>
>>> Pinging this review request.
>>>
>>> Em sáb, 10 de mar de 2018 às 18:29, Caio Lima  
>>> escreveu:

 Hi All.

 I am working into some BigInt patches  and right now I'm looking for
 someone to review the following Patch
 (https://bugs.webkit.org/show_bug.cgi?id=182470). Saam reviewed it
 once, but since he is not available, he advised me to ask some other
 reviewer to take a look. Could anyone take a look on that?

 Regards,
 Caio.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Ask for review in BigInt Patch

[Caio Lima]

Hi all.

It's been a while I am asking for review into BigInt Patches but get
no answer. I have 4 Patches in the queue to be reviewed but some of
them are dependent one to another. The addition of SpecBigInt
(https://bugs.webkit.org/show_bug.cgi?id=182470) is blocking BigInt
Unary "+" and "-" operation
(https://bugs.webkit.org/show_bug.cgi?id=182214) that is then blocking
support for addition operations
(https://bugs.webkit.org/show_bug.cgi?id=179002) and will block other
future Patches. I think the addition of SpecBigInt
(https://bugs.webkit.org/show_bug.cgi?id=182470) is the one that
should be reviewed first. Is there any better approach of how I could
get review on them? It is starting to be time consuming rebasing all
these dependent patches downstream.

Regards,
Caio.

Em qua, 14 de mar de 2018 às 21:08, Caio Lima  escreveu:
>
> Hi all.
>
> Pinging this review request.
>
> Em sáb, 10 de mar de 2018 às 18:29, Caio Lima  escreveu:
>>
>> Hi All.
>>
>> I am working into some BigInt patches  and right now I'm looking for
>> someone to review the following Patch
>> (https://bugs.webkit.org/show_bug.cgi?id=182470). Saam reviewed it
>> once, but since he is not available, he advised me to ask some other
>> reviewer to take a look. Could anyone take a look on that?
>>
>> Regards,
>> Caio.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Ask for review in BigInt Patch

[Caio Lima]

Olá Leo!

I'm getting some tests from Test262,  but I'm not running them directly
with the Test262-harness. If you need any help, let me know.

Em sáb, 10 de mar de 2018 às 21:05, Leo Balter  escreveu:

> Olá Caio!
>
> I'm game to fetch your work and run it against the recent changes in
> Test262, but I also imagined you're already doing it. I'll give it a try
> anyway as I'm particularly interested in this new feature implementation.
>
>
>
> On Sat, Mar 10, 2018 at 12:29 PM, Caio Lima  wrote:
>
>> Hi All.
>>
>> I am working into some BigInt patches  and right now I'm looking for
>> someone to review the following Patch
>> (https://bugs.webkit.org/show_bug.cgi?id=182470). Saam reviewed it
>> once, but since he is not available, he advised me to ask some other
>> reviewer to take a look. Could anyone take a look on that?
>>
>> Regards,
>> Caio.
>>
> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>>
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Ask for review in BigInt Patch

[Leo Balter]

Olá Caio!

I'm game to fetch your work and run it against the recent changes in
Test262, but I also imagined you're already doing it. I'll give it a try
anyway as I'm particularly interested in this new feature implementation.



On Sat, Mar 10, 2018 at 12:29 PM, Caio Lima  wrote:

> Hi All.
>
> I am working into some BigInt patches  and right now I'm looking for
> someone to review the following Patch
> (https://bugs.webkit.org/show_bug.cgi?id=182470). Saam reviewed it
> once, but since he is not available, he advised me to ask some other
> reviewer to take a look. Could anyone take a look on that?
>
> Regards,
> Caio.
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Ask for review in BigInt Patch

[Caio Lima]

Hi All.

I am working into some BigInt patches  and right now I'm looking for
someone to review the following Patch
(https://bugs.webkit.org/show_bug.cgi?id=182470). Saam reviewed it
once, but since he is not available, he advised me to ask some other
reviewer to take a look. Could anyone take a look on that?

Regards,
Caio.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev