Re: [webkit-dev] Clearing old reviews from the queue

2020-02-16 Thread Dean Jackson
> On 16 Feb 2020, at 17:46, Alexey Proskuryakov wrote: > > > >> 16 февр. 2020 г., в 7:52, Dean Jackson написал(а): >> >> Does anyone oppose clearing all review requests that are older than 6 >> months? (or 1 year?) > > Looking at ancient patches in the review queue, quite a few look like

Re: [webkit-dev] Clearing old reviews from the queue

2020-02-16 Thread Alexey Proskuryakov
> 16 февр. 2020 г., в 7:52, Dean Jackson написал(а): > > Does anyone oppose clearing all review requests that are older than 6 months? > (or 1 year?) Looking at ancient patches in the review queue, quite a few look like they should still work (e.g. adding new tests). So said that we are not

Re: [webkit-dev] Clearing old reviews from the queue

2020-02-16 Thread Ryosuke Niwa
Sounds reasonable to me although I’d suggest older than 1 year instead of 6 months since I don’t think 6 months is long enough to render a patch completely obsolete in many cases. - R. Niwa On Sun, Feb 16, 2020 at 07:53 Dean Jackson wrote: > Does anyone oppose clearing all review requests that

[webkit-dev] Clearing old reviews from the queue

2020-02-16 Thread Dean Jackson
Does anyone oppose clearing all review requests that are older than 6 months? (or 1 year?) I tried to use the bugzilla API to do this, but I couldn't work out how to detect the attachment state properly. I looked at the source code for the queue page and it uses custom SQL :) (It's easy to do