Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-08 Thread Ryosuke Niwa
Seems like there is a consensus here. Here's a patch to codify it in our code style guidelines: https://bugs.webkit.org/show_bug.cgi?id=204021 On Mon, Nov 4, 2019 at 8:06 AM Alex Christensen wrote: > When the lambda is mutable or has a trailing return type, the () is > currently required by the

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-04 Thread Alex Christensen
When the lambda is mutable or has a trailing return type, the () is currently required by the C++ grammar, so we can’t say to always omit (). We could say to always have it, to only have it when necessary, or have no code style guideline. I think we should always have spaces before and after,

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Ryosuke Niwa
On Sat, Nov 2, 2019 at 8:25 PM Ryosuke Niwa wrote: > > On Sat, Nov 2, 2019 at 7:54 PM Chris Dumez wrote: > >> >> >> On Nov 2, 2019, at 7:38 PM, Ryosuke Niwa wrote: >> >>  >> >> On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto wrote: >> >>> >>> On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa wrote:

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Chris Dumez
> On Nov 2, 2019, at 7:38 PM, Ryosuke Niwa wrote: > >  > >> On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto wrote: >> >>> On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa wrote: On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro wrote: >>> On Fri, Nov 1, 2019 at 11:19 am,

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Ryosuke Niwa
On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto wrote: > > On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa wrote: > >> On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro >> wrote: >> >>> On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote: >>> > Namely, some people write a lambda as: >>> > auto x =

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-01 Thread Zalan Bujtas
I've been using the short form in the layout code for a while now and never mistaken it for code block start & end. That being said I don't have strong preference on this. Alan. On Fri, Nov 1, 2019 at 4:37 PM Ryosuke Niwa wrote: > On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro > wrote: >