Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-09-12 Thread Guillaume Emont
Quoting Filip Pizlo (2017-09-05 10:37:16) > There isn’t anyone maintaining the 32-not JIT ports to the level of quality > we have in our 64-not ports. Making 32-bit use the 64-bit cloop would be a > quality progression for actual users of 32-bit. > Hi, I would like to chip in as one of the

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-09-07 Thread Yusuke SUZUKI
re. (I'm opposed to adding 32bit support to FTL). > > -Filip > > > > > > -Original Message- > > From: webkit-dev [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf > Of Filip Pizlo > > Sent: Tuesday, September 5, 2017 8:37 AM > > To: Adrian Perez de C

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-09-05 Thread Filip Pizlo
n Perez de Castro <ape...@igalia.com> > Cc: webkit-dev@lists.webkit.org > Subject: Re: [webkit-dev] Bring back ARMv6 support to JSC > > There isn’t anyone maintaining the 32-not JIT ports to the level of quality > we have in our 64-not ports. Making 32-bit use the 64-bit cloop wou

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-09-05 Thread Filip Pizlo
There isn’t anyone maintaining the 32-not JIT ports to the level of quality we have in our 64-not ports. Making 32-bit use the 64-bit cloop would be a quality progression for actual users of 32-bit. -Filip > On Sep 5, 2017, at 8:02 AM, Adrian Perez de Castro wrote: > >>

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-09-05 Thread Adrian Perez de Castro
On Tue, 5 Sep 2017 16:38:09 +0200, Osztrogonác Csaba wrote: > [...] > > Maybe it will be hard to say good bye to 32-bit architecutres > for many people, but please, it's 2017 now, the first ARMv8 SoC > is out 4 years ago, the first AMD64 CPU is out 14 years ago. While

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-09-05 Thread Osztrogonác Csaba
Hi, I expected exactly this proposal when Apple announced the 64-bit only iOS 11 near 3 months ago. ( I should have bet. :) ) I can understand that 32-bit is only an unnecessary barrier for you and you don't want to bear the maintenance cost of it when there isn't a significant amount of

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-09-05 Thread Filip Pizlo
I think that JIT support on platforms that don’t get regular tuning doesn’t make sense. I think we should: - Remove JIT support for 32-bit platforms - Remove JIT support for Windows - Remove JSVALUE32_64 - Use cloop In 64-bit mode on 32-bit platforms and Windows. I think this approach would be

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-09-05 Thread Caio Lima
Hi guys,I've posted this on the bug thread, but I would also like to revive the discussion here. After our last discussion, I put some effort to enable IC for ARMv6 into JIT layers and now I finally collected some results for that. Now, we have regressions just into 2 tests in SunSpider (they

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-08-01 Thread Caio Lima
Hi all. FYI, I keep the last weeks investigating the issue with ARMv6 IC and I was able to find the source of the bug and apply a quick fix to run benchmarks again to get results. I just ran V8Spider, Octane and Kraken by now and I'm attaching the results in this email. We found some test cases

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-13 Thread Caio Lima
Yes. It probably will take a while to process on device, but I'll run it. Em qui, 13 de jul de 2017 às 17:50, Saam barati escreveu: > And ARES6. > > - Saam > > > On Jul 13, 2017, at 1:50 PM, Saam barati wrote: > > Can you please run Octane and Kraken too?

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-13 Thread Saam barati
And ARES6. - Saam > On Jul 13, 2017, at 1:50 PM, Saam barati wrote: > > Can you please run Octane and Kraken too? > > - Saam > >> On Jul 13, 2017, at 7:47 AM, Caio Lima > > wrote: >> >> Finally I got the results from

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-13 Thread Saam barati
Can you please run Octane and Kraken too? - Saam > On Jul 13, 2017, at 7:47 AM, Caio Lima wrote: > > Finally I got the results from the last benchmark run. The results > shows that the speed-ups are considerable comparing with CLoop > version, since we get faster results

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-13 Thread Filip Pizlo
The fact that V8Spider is regressed indicates major problems with the JIT on ARMv6. I think that it would be better to work on fixing this JIT outside trunk, and then come back with patches once you have a speed up. In the future we shouldn’t allow partially-working JIT ports to land. -Filip

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-13 Thread Caio Lima
Finally I got the results from the last benchmark run. The results shows that the speed-ups are considerable comparing with CLoop version, since we get faster results in a big number of tests and regress in a minor number of scripts. I would like to get feedback from you as well, but IMHO enabling

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-05 Thread Filip Pizlo
To be clear, I’m concerned that the 32-bit JIT backends have such bad tuning for these embedded platforms that it’s just pure badness. Until you can prove that you can change this, I think that porting should focus on making the cloop great. Then, we can rip out support for weird CPUs rather

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-05 Thread Caio Lima
2017-07-05 18:25 GMT-03:00 Filip Pizlo : > You need to establish that the JIT is a performance progression over the > LLInt on ARMv6. I am opposed to more ARMv6 patches landing until there is > some evidence provided that you’re actually getting speed-ups. It makes sense. I

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-05 Thread Carlos Alberto Lopez Perez
On 05/07/17 23:24, Saam barati wrote: > What’s the testing plan here? Do y'all plan to add a bot that ensures ARMv6 > stays working? > > - Saam We do. I will deploy one at https://build-webkit.igalia.com/waterfall?category=misc ASAP (hopefully this week), and then propose a patch to move it to

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-05 Thread Filip Pizlo
You need to establish that the JIT is a performance progression over the LLInt on ARMv6. I am opposed to more ARMv6 patches landing until there is some evidence provided that you’re actually getting speed-ups. -Filip > On Jun 13, 2017, at 6:48 PM, Caio Lima wrote: > >

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-05 Thread Saam barati
What’s the testing plan here? Do y'all plan to add a bot that ensures ARMv6 stays working? - Saam > On Jun 13, 2017, at 6:48 PM, Caio Lima wrote: > > Hi All. > > Some of you guys might know me through the work I have been doing in > JSC. The experience working with