Re: [webkit-dev] CC on reviewed bugs
Hi, It is a very old issue and I already proposed to fix it 2 years before: https://bugs.webkit.org/show_bug.cgi?id=124047 and once again: https://lists.webkit.org/pipermail/webkit-dev/2014-October/026944.html It is a known and fixed bugzilla issue in bugzilla 4.4 (3.5 year ago!). As far as I know we still use bugzilla 4.2(.11) which reached of its end of life in 2015 Dec 22 - https://www.bugzilla.org/news/ One more reason to upgrade our bugzilla: https://bugs.webkit.org/show_bug.cgi?id=55882 br, Ossy Michael Catanzaro írta: On Thu, 2016-01-07 at 13:09 -0800, Brian Burg wrote: The only reason that normal commenting will CC you is that the [X] Add me to CC list is checked by default. I agree it would be reasonable to duplicate that behavior when commenting via the review tool. To do this, you’d have to modify “sub update()” in attachment.cgi, and pass in some new parameter. I recommend filing a bug so we can deliberate how to implement it. -Brian OK: https://bugs.webkit.org/show_bug.cgi?id=152854 Thanks, Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] CC on reviewed bugs
The only reason that normal commenting will CC you is that the [X] Add me to CC list is checked by default. I agree it would be reasonable to duplicate that behavior when commenting via the review tool. To do this, you’d have to modify “sub update()” in attachment.cgi, and pass in some new parameter. I recommend filing a bug so we can deliberate how to implement it. -Brian > On Jan 7, 2016, at 12:48 PM, Michael Catanzarowrote: > > Hi, > > I notice that when my only comment on a bug is the comment added using > the WebKit review feature, I do not get CCed on the bug and so do not > notice follow-up responses to my review. > > It would be awesome if auto-CC could be implemented. I always want to > be CCed on bugs with patches I have reviewed. > > Please be careful to CC yourself manually in the meantime. > > Michael > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] CC on reviewed bugs
On Thu, 2016-01-07 at 13:09 -0800, Brian Burg wrote: > The only reason that normal commenting will CC you is that the [X] > Add me to CC list is checked by default. > I agree it would be reasonable to duplicate that behavior when > commenting via the review tool. > > To do this, you’d have to modify “sub update()” in attachment.cgi, > and pass in some new parameter. > I recommend filing a bug so we can deliberate how to implement it. > > -Brian OK: https://bugs.webkit.org/show_bug.cgi?id=152854 Thanks, Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev