Re: [webkit-dev] Clarifying feature flags

2018-11-07 Thread Darin Adler
A while ago Kentaro Hara did some IDL keyword cleanup.

One of the best things he did was to make a single file with a list of all the 
keywords. In that case he was able to set things up so that if the file was 
inaccurate the build would fail; not sure if that’s practical for the various 
feature flags, but it’s helpful to have a single place. Here’s a link to an 
interesting WebKit mailing list message about one of the steps in that 
>.

I’d love us to find a similar way to “manage” and make it so someone can look 
over the entire list of feature flags and conditionals so we can spot problems 
easily.

— Darin___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Clarifying feature flags

2018-11-06 Thread Don . Olmstead
Any thoughts on what it would look like? If there are preferences we can work 
off of that.

From: webkit-dev  On Behalf Of Simon Fraser
Sent: Monday, November 5, 2018 11:41 AM
To: Olmstead, Don 
Cc: webkit-dev@lists.webkit.org
Subject: Re: [webkit-dev] Clarifying feature flags

On Nov 5, 2018, at 6:01 PM, don.olmst...@sony.com<mailto:don.olmst...@sony.com> 
wrote:

I'm really interested in other people's thoughts on this.


Agreed that this would be great to clean up. We’ve accrued a lot of junk in 
this area.

Simon



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Clarifying feature flags

2018-11-05 Thread Simon Fraser
> On Nov 5, 2018, at 6:01 PM, don.olmst...@sony.com wrote:
>  
> I'm really interested in other people's thoughts on this.
>  

Agreed that this would be great to clean up. We’ve accrued a lot of junk in 
this area.

Simon



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev