Re: [webkit-dev] Disabling the JIT
chinmaya sn (chins) wrote: Just curious, how would you verify if JavaScript in your browser has JIT support or not? I added this in the interpreter constructor: #if ENABLE(JIT) printf(JIT enabled\n); #else printf(JIT disabled\n); #endif As an update. Building with JAVASCRIPTCORE_JIT=no works if I start from a fresh SVN checkout that hasn't been built without that option before. -- View this message in context: http://old.nabble.com/Disabling-the-JIT-tp28378562p28401613.html Sent from the Webkit mailing list archive at Nabble.com. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Disabling the JIT
Just curious, how would you verify if JavaScript in your browser has JIT support or not? On Tue, Apr 27, 2010 at 3:10 PM, Nyx mch...@cs.mcgill.ca wrote: Another way would be to set export QMAKEARGS=$QMAKEARGS DEFINES+=ENABLE_JIT=0 before building. Ok. I tried this approach. I have a build script that looks like this: QTDIR=/usr/share/qt4/ export QMAKEARGS=$QMAKEARGS DEFINES+=ENABLE_JIT=0 WebKit/WebKitTools/Scripts/build-webkit --qt It builds, but the JIT is not disabled. It seems that the new argument is simply ignored. I also tried adding #define ENABLE_JIT 0 at the top of the Interpreter.cpp file in JavaScriptCore. This builds, but produces a segmentation fault. I will try doing the WebKit/WebKitTools/Scripts/build-webkit --qt JAVASCRIPTCORE_JIT=no with a fresh SVN checkout... Is there any equivalent of make clean script, as a completment to build-webkit? -- View this message in context: http://old.nabble.com/Disabling-the-JIT-tp28378562p28382091.html Sent from the Webkit mailing list archive at Nabble.com. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- -- chinmaya sn ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Disabling the JIT
If you want to set the flags manually, you should write CXXFLAGS+=... instead of CXXFLAGS=. However, the first method what you tried is right, so if it is crashing then smg wrong with the JIT. What platform (Architecture, OS, qt-version) do you use? On 04/27/2010 05:41 PM, Nyx wrote: I am trying to disable the JIT when building the QT version of webkit so that I can instrument the interpreter for profiling purposes. I have been googling around and found a few suggestions, which so far have all not worked: If I run the following build command: WebKit/WebKitTools/Scripts/build-webkit --qt JAVASCRIPTCORE_JIT=no WebKit builds, but when I try to run it: WebKit/WebKitTools/Scripts/run-launcher --qt It crashes as soon as I try to load a page that uses JavaScript (eg: google). Someone also suggested building WebKit as follows: WebKit/WebKitTools/Scripts/build-webkit --qt --makeargs='CXXFLAGS=-DENABLE_JIT=0' This works *once*, but if I try to run build-webkit a second time, I get lots of nonsensical compilation errors, which I can't seem to get rid of, even if I try to build without -DENABLE_JIT=0... Any help would be appreciated, - Max ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Disabling the JIT
If you want to set the flags manually, you should write CXXFLAGS+=... instead of CXXFLAGS=. Thanks. I will be trying that. However, the first method what you tried is right, so if it is crashing then smg wrong with the JIT. What platform (Architecture, OS, qt-version) do you use? Ubuntu 9.10, x86 32 bit, qt package is libqt4-dev (4.5.3). I would assume the problem is in fact with the JIT, because it happens when I browse away from the blank page to google.com, which is when the JavaScript interpreter gets instantiated. By the way, I intend to be messing around with the interpreter a fair bit. Is running buld-webkit every time I make a change to the source really the way to go about this, or is there a more efficient way? -- View this message in context: http://old.nabble.com/Disabling-the-JIT-tp28378562p28379151.html Sent from the Webkit mailing list archive at Nabble.com. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Disabling the JIT
On 04/27/2010 07:02 PM, Nyx wrote: If you want to set the flags manually, you should write CXXFLAGS+=... instead of CXXFLAGS=. Another way would be to set export QMAKEARGS=$QMAKEARGS DEFINES+=ENABLE_JIT=0 before building. However, the first method what you tried is right, so if it is crashing then smg wrong with the JIT. What platform (Architecture, OS, qt-version) do you use? Ubuntu 9.10, x86 32 bit, qt package is libqt4-dev (4.5.3). I would assume Your qt version is fairly old, if you want to develop, you probably need a newer version from upstream (eg. 4.6.2). the problem is in fact with the JIT, because it happens when I browse away from the blank page to google.com, which is when the JavaScript interpreter gets instantiated. That is strange. Did you checkout the source from svn? Did you mess around in the code? By the way, I intend to be messing around with the interpreter a fair bit. Is running buld-webkit every time I make a change to the source really the way to go about this, or is there a more efficient way? If you do not change things which are related to generated code, you can also use make -C WebKitBuild/Release (or Debug respectively), but it is probably safer to use build-webkit, which also builds incrementally, but generates the needed code, if there was a change, and runs qmake. BR; Andras ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Disabling the JIT
Another way would be to set export QMAKEARGS=$QMAKEARGS DEFINES+=ENABLE_JIT=0 before building. Will try it too. That is strange. Did you checkout the source from svn? Did you mess around in the code? Yes. I checked it out last night from the trunk. -- View this message in context: http://old.nabble.com/Disabling-the-JIT-tp28378562p28380211.html Sent from the Webkit mailing list archive at Nabble.com. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Disabling the JIT
Another way would be to set export QMAKEARGS=$QMAKEARGS DEFINES+=ENABLE_JIT=0 before building. Ok. I tried this approach. I have a build script that looks like this: QTDIR=/usr/share/qt4/ export QMAKEARGS=$QMAKEARGS DEFINES+=ENABLE_JIT=0 WebKit/WebKitTools/Scripts/build-webkit --qt It builds, but the JIT is not disabled. It seems that the new argument is simply ignored. I also tried adding #define ENABLE_JIT 0 at the top of the Interpreter.cpp file in JavaScriptCore. This builds, but produces a segmentation fault. I will try doing the WebKit/WebKitTools/Scripts/build-webkit --qt JAVASCRIPTCORE_JIT=no with a fresh SVN checkout... Is there any equivalent of make clean script, as a completment to build-webkit? -- View this message in context: http://old.nabble.com/Disabling-the-JIT-tp28378562p28382091.html Sent from the Webkit mailing list archive at Nabble.com. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Disabling the JIT
On Apr 27, 2010, at 2:10 PM, Nyx wrote: I also tried adding #define ENABLE_JIT 0 at the top of the Interpreter.cpp file in JavaScriptCore. This builds, but produces a segmentation fault. This would not work as you would end up with some parts of WebKit compiled with the jit enabled, and some not. If you want to try forcing the jit to be disabled with a #define you need to do it in Platform.h --Oliver ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
