Re: [webkit-dev] Dropping support for WML?
I am Sorry for my previous email. My internal signature was included in the email. Please ignore the signature. Kent, do you make a bug for your suggestion ? - gyuyoung I think it's ok to keep WML code if we can avoid the form control issue. We can terminate the form control abstraction for HTML and WML. e.g. - Merge dom/InputElement to html/HTMLInputElement - Merge dom/InputElement to wml/WMLInputElement - Remove dom/InputElement - Copy RenderTextControlSingleLine as RenderTextControlWML - RenderTextControlSingleLine only supports HTMLInputElement - RenderTextControlWML only supports WMLInputElement We would have some duplicated code. But it would be better than the current situation. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Dropping support for WML?
I think it's ok to keep WML code if we can avoid the form control issue. We can terminate the form control abstraction for HTML and WML. e.g. - Merge dom/InputElement to html/HTMLInputElement - Merge dom/InputElement to wml/WMLInputElement - Remove dom/InputElement - Copy RenderTextControlSingleLine as RenderTextControlWML - RenderTextControlSingleLine only supports HTMLInputElement - RenderTextControlWML only supports WMLInputElement We would have some duplicated code. But it would be better than the current situation. On Fri, Apr 8, 2011 at 10:08, Darin Adler da...@apple.com wrote: On Apr 8, 2011, at 2:09 AM, Ryosuke Niwa wrote: We have been discussing the possibility of dropping WML support in WebKit on IRC for a while now because • None of core ports (Mac, Windows, GTK, Qt, Chromium) use it by default • Maintenance cost is high I’ll just add one other thing: HTML form element implementations have factoring that are twisted and complicated because of WML in a way that makes working on those classes unpleasant for me. It would make form work considerably easier if we drop WML support. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Dropping support for WML?
Blackberry needs to continue to support WML, but we are using our own (legacy) code as a plugin, so removing it from webkit is mostly fine with us. We just use two pieces of the WML code, to deal with the different loading model required by WML: In FrameLoader::shouldReload: // All WML decks are supposed to be reloaded, even within the same URL fragment if (frameContainsWMLContent(m_frame)) return true; In FrameLoader::loadItem: // All WML decks should go through the real load mechanism, not the scroll-to-anchor code // FIXME: Why do WML decks have this different behavior? // Are WML decks incompatible with HTML5 pushState/replaceState which require inter-document history navigations? // Should this new API be disabled for WML pages, or does WML need to update their mechanism to act like normal loads? // If scroll-to-anchor navigations were broken for WML and required them to have different loading behavior, then // state object loads are certainly also broken for them. if (frameContainsWMLContent(m_frame)) sameDocumentNavigation = false; (And we overrode frameContainsWMLContent to detect that a frame has our plugin loaded, rather than using the default test.) So if these are removed we will probably need to add them back in #if PLATFORM(BLACKBERRY) guards. From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Ryosuke Niwa Sent: Friday, April 08, 2011 5:10 AM To: WebKit Development Subject: [webkit-dev] Dropping support for WML? Greetings all, We have been discussing the possibility of dropping WML support in WebKit on IRC for a while now because 1. None of core ports (Mac, Windows, GTK, Qt, Chromium) use it by default 2. Maintenance cost is high I know Samsung is using the feature but they're not sure if they'll be supporting it in the future. Are there are other folks who are actively using WML? Best regards. Ryosuke Niwa Software Engineer Google Inc. - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Dropping support for WML?
-- Forwarded message -- From: Gyuyoung Kim gyuyoung@samsung.com Date: 2011/4/10 Subject: Re: [webkit-dev] webkit-dev Digest, Vol 71, Issue 8 To: webkit-dev@lists.webkit.org Cc: Krzysztof Czech k.cz...@samsung.com, 임상석 sangseok@samsung.com I know Samsung is using the feature but they're not sure if they'll be supporting it in the future. Are there are other folks who are actively using WML? We're using WML in WebKit trunk now. Even though, there are some maintenance difficulties, I think WML needs to be maintained for some time. BTW, as far as I know, there are some bugs in WML. So, we have plan to contribute our patches soon. - Gyuyoung Kim ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Dropping support for WML?
I have a related question - what sort of test coverage is there for WML currently on the core bots? Do any of the core bots compile with WML enabled? I've made and reviewed a few changes to WML code made parallel to changes to the HTML forms code in the past and have made the WML edits essentially blindly. I don't know if I've made the WML code better or worse in the process and have no way to check. I'm not even sure how to tell if WML still compiles after my patches. If the code is completely untested (as I somehow suspect it is) than I think it's more dangerous to leave the code in than to take it out, given that it is likely to accumulate more and more bugs as the related code changes. - James On Tue, Apr 12, 2011 at 9:57 AM, Ryosuke Niwa rn...@webkit.org wrote: -- Forwarded message -- From: Gyuyoung Kim gyuyoung@samsung.com Date: 2011/4/10 Subject: Re: [webkit-dev] webkit-dev Digest, Vol 71, Issue 8 To: webkit-dev@lists.webkit.org Cc: Krzysztof Czech k.cz...@samsung.com, 임상석 sangseok@samsung.com I know Samsung is using the feature but they're not sure if they'll be supporting it in the future. Are there are other folks who are actively using WML? We're using WML in WebKit trunk now. Even though, there are some maintenance difficulties, I think WML needs to be maintained for some time. BTW, as far as I know, there are some bugs in WML. So, we have plan to contribute our patches soon. - Gyuyoung Kim ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Dropping support for WML?
2011/4/8 谢愈挺 xyts...@gmail.com Re: Dropping support for WML? I am using WML. It is useful. Hope someone can update it. Hi, thanks for the reply. Are you affiliated with any company or open source project? If so, would you mind telling us which and if your company or project is going to support WML in the long term? - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Dropping support for WML?
On Fri, Apr 8, 2011 at 3:01 AM, Dirk Schulze d...@dschulze.com wrote: If you search in the ChangeLogs, you'll see that we still get bug fixes and build fixes for WML. As far as I checked, much of changes in WML are due to changes in Core DOM and other parts of WebCore. See http://trac.webkit.org/log/trunk/Source/WebCore/wml But it seems it is not the case for WML yet. Also, I am unsure if None of the core ports use it by defautl is a strong argument here. Do you use WML? I'm simply interested in statistics not arguments for or against the idea of dropping the feature because we're most likely going to talk about this at the contributor's meeting. - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Dropping support for WML?
On Apr 8, 2011, at 2:09 AM, Ryosuke Niwa wrote: We have been discussing the possibility of dropping WML support in WebKit on IRC for a while now because • None of core ports (Mac, Windows, GTK, Qt, Chromium) use it by default • Maintenance cost is high I’ll just add one other thing: HTML form element implementations have factoring that are twisted and complicated because of WML in a way that makes working on those classes unpleasant for me. It would make form work considerably easier if we drop WML support. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Dropping support for WML?
On Fri, Apr 8, 2011 at 10:08 AM, Darin Adler da...@apple.com wrote: On Apr 8, 2011, at 2:09 AM, Ryosuke Niwa wrote: We have been discussing the possibility of dropping WML support in WebKit on IRC for a while now because • None of core ports (Mac, Windows, GTK, Qt, Chromium) use it by default • Maintenance cost is high I’ll just add one other thing: HTML form element implementations have factoring that are twisted and complicated because of WML in a way that makes working on those classes unpleasant for me. It would make form work considerably easier if we drop WML support. This is possibly the main practical argument for dropping it. I totally agree. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Dropping support for WML?
On Apr 8, 2011, at 2:09 AM, Ryosuke Niwa wrote: Are there are other folks who are actively using WML? I realized that I pushed us off topic a little and wanted to remind everyone of the real point of this thread. Ryosuke specifically said he wants to get the data about who is using WML. So please do reply if you have any information about this. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
